From: Julien Grall <julien.grall@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr_Tyshchenko@epam.com,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Andrii Anisov <andrii_anisov@epam.com>
Subject: [Xen-devel] [PATCH MM-PART3 v2 08/12] xen/arm: mm: Remove enum xenmap_operation
Date: Tue, 14 May 2019 13:31:21 +0100 [thread overview]
Message-ID: <20190514123125.29086-9-julien.grall@arm.com> (raw)
Message-ID: <20190514123121.VQc_G42CNjHL4mlX9jcGwBTqFETKel3jvxI24YGcKJk@z> (raw)
In-Reply-To: <20190514123125.29086-1-julien.grall@arm.com>
The enum xenmap_operation is not used anymore. So remove it.
Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>
---
Changes in v2:
- Add Andrii's reviewed-by
---
xen/arch/arm/mm.c | 24 ++++++++----------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 86e1faeeb5..651e296041 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -974,13 +974,6 @@ static int create_xen_table(lpae_t *entry)
return 0;
}
-enum xenmap_operation {
- INSERT,
- REMOVE,
- MODIFY,
- RESERVE
-};
-
/* Sanity check of the entry */
static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
{
@@ -1040,8 +1033,8 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
return true;
}
-static int xen_pt_update_entry(enum xenmap_operation op, unsigned long addr,
- mfn_t mfn, unsigned int flags)
+static int xen_pt_update_entry(unsigned long addr, mfn_t mfn,
+ unsigned int flags)
{
lpae_t pte, *entry;
lpae_t *third = NULL;
@@ -1099,8 +1092,7 @@ static int xen_pt_update_entry(enum xenmap_operation op, unsigned long addr,
static DEFINE_SPINLOCK(xen_pt_lock);
-static int xen_pt_update(enum xenmap_operation op,
- unsigned long virt,
+static int xen_pt_update(unsigned long virt,
mfn_t mfn,
unsigned long nr_mfns,
unsigned int flags)
@@ -1131,7 +1123,7 @@ static int xen_pt_update(enum xenmap_operation op,
for( ; addr < addr_end; addr += PAGE_SIZE )
{
- rc = xen_pt_update_entry(op, addr, mfn, flags);
+ rc = xen_pt_update_entry(addr, mfn, flags);
if ( rc )
break;
@@ -1156,24 +1148,24 @@ int map_pages_to_xen(unsigned long virt,
unsigned long nr_mfns,
unsigned int flags)
{
- return xen_pt_update(INSERT, virt, mfn, nr_mfns, flags);
+ return xen_pt_update(virt, mfn, nr_mfns, flags);
}
int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
{
- return xen_pt_update(RESERVE, virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE);
+ return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE);
}
int destroy_xen_mappings(unsigned long v, unsigned long e)
{
ASSERT(v <= e);
- return xen_pt_update(REMOVE, v, INVALID_MFN, (e - v) >> PAGE_SHIFT, 0);
+ return xen_pt_update(v, INVALID_MFN, (e - v) >> PAGE_SHIFT, 0);
}
int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags)
{
ASSERT(s <= e);
- return xen_pt_update(MODIFY, s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags);
+ return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags);
}
enum mg { mg_clear, mg_ro, mg_rw, mg_rx };
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-14 12:31 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 12:31 [PATCH MM-PART3 v2 00/12] xen/arm: Provide a generic function to update Xen PT Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 01/12] xen/arm: lpae: Add a macro to generate offsets from an address Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:21 ` Stefano Stabellini
2019-06-11 18:27 ` Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 02/12] xen/arm: mm: Rename create_xen_entries() to xen_pt_update() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:23 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 03/12] xen/arm: mm: Move out of xen_pt_update() the logic to update an entry Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:29 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 04/12] xen/arm: mm: Only increment mfn when valid in xen_pt_update Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:37 ` Stefano Stabellini
2019-06-11 19:56 ` [Xen-devel] Checking INVALID_MFN in mfn_add (WAS: Re: [PATCH MM-PART3 v2 04/12] xen/arm: mm: Only increment mfn when valid in xen_pt_update) Julien Grall
2019-06-11 20:24 ` Andrew Cooper
2019-06-12 12:47 ` Julien Grall
2019-06-12 15:57 ` Stefano Stabellini
2019-06-12 7:53 ` Jan Beulich
2019-05-14 12:31 ` [PATCH MM-PART3 v2 05/12] xen/arm: mm: Introduce _PAGE_PRESENT and _PAGE_POPULATE Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 22:35 ` Stefano Stabellini
2019-06-12 13:00 ` Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 06/12] xen/arm: mm: Sanity check any update of Xen page tables Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 0:10 ` Stefano Stabellini
2019-06-12 14:48 ` Julien Grall
2019-06-12 15:54 ` Stefano Stabellini
2019-06-12 15:58 ` Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 07/12] xen/arm: mm: Rework xen_pt_update_entry to avoid use xenmap_operation Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:22 ` Stefano Stabellini
2019-05-14 12:31 ` Julien Grall [this message]
2019-05-14 12:31 ` [Xen-devel] [PATCH MM-PART3 v2 08/12] xen/arm: mm: Remove enum xenmap_operation Julien Grall
2019-06-11 22:38 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 09/12] xen/arm: mm: Use {, un}map_domain_page() to map/unmap Xen page-tables Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:25 ` Stefano Stabellini
2019-06-13 8:07 ` Julien Grall
2019-06-13 17:55 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 10/12] xen/arm: mm: Rework Xen page-tables walk during update Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:52 ` Stefano Stabellini
2019-06-13 8:20 ` Julien Grall
2019-06-13 17:59 ` Stefano Stabellini
2019-06-13 21:32 ` Julien Grall
2019-06-13 22:57 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 11/12] xen/arm: mm: Don't open-code Xen PT update in {set, clear}_fixmap() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:33 ` Stefano Stabellini
2019-06-13 8:31 ` Julien Grall
2019-06-13 18:51 ` Stefano Stabellini
2019-06-13 21:21 ` Julien Grall
2019-06-13 22:55 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 12/12] xen/arm: mm: Remove set_pte_flags_on_range() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:41 ` Stefano Stabellini
2019-06-13 8:51 ` Julien Grall
2019-06-13 18:04 ` Stefano Stabellini
2019-06-13 21:22 ` Julien Grall
2019-05-29 17:23 ` [PATCH MM-PART3 v2 00/12] xen/arm: Provide a generic function to update Xen PT Julien Grall
2019-05-29 17:23 ` [Xen-devel] " Julien Grall
2019-06-10 10:08 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514123125.29086-9-julien.grall@arm.com \
--to=julien.grall@arm.com \
--cc=Oleksandr_Tyshchenko@epam.com \
--cc=andrii_anisov@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).