From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
George.Dunlap@eu.citrix.com, dario.faggioli@citrix.com,
xen-devel@lists.xenproject.org, roger.pau@citrix.com
Subject: Re: [PATCH 05/10] xl_cmdimpl: improve return codes for memset commands
Date: Fri, 1 Apr 2016 16:33:52 +0200 [thread overview]
Message-ID: <alpine.OSX.2.20.1604011630040.9476@mac> (raw)
In-Reply-To: <1459514413-18682-6-git-send-email-paulinaszubarczyk@gmail.com>
On Fri, 1 Apr 2016, Paulina Szubarczyk wrote:
> - Use EXIT_{SUCCESS,FAILURE} for main_mem*() function
> - Use 0/1 as return values of set_memory_{max,target}
>
> Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
> ---
> tools/libxl/xl_cmdimpl.c | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 7ee6953..31f037f 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3380,15 +3380,15 @@ static int set_memory_max(uint32_t domid, const char *mem)
> memorykb = parse_mem_size_kb(mem);
> if (memorykb == -1) {
> fprintf(stderr, "invalid memory size: %s\n", mem);
> - exit(3);
> + exit(EXIT_FAILURE);
IMHO (I would like to hear others' opinion) but I think you can just
return 1 here instead of exiting.
> }
>
> if (libxl_domain_setmaxmem(ctx, domid, memorykb)) {
> fprintf(stderr, "cannot set domid %d static max memory to : %s\n", domid, mem);
> - return EXIT_FAILURE;
> + return 1;
> }
>
> - return EXIT_SUCCESS;
> + return 0;
> }
>
> int main_memmax(int argc, char **argv)
> @@ -3404,7 +3404,11 @@ int main_memmax(int argc, char **argv)
> domid = find_domain(argv[optind]);
> mem = argv[optind + 1];
>
> - return set_memory_max(domid, mem);
> + if (set_memory_max(domid, mem)) {
> + return EXIT_FAILURE;
> + }
> +
> + return EXIT_SUCCESS;
> }
>
> static int set_memory_target(uint32_t domid, const char *mem)
> @@ -3414,15 +3418,15 @@ static int set_memory_target(uint32_t domid, const char *mem)
> memorykb = parse_mem_size_kb(mem);
> if (memorykb == -1) {
> fprintf(stderr, "invalid memory size: %s\n", mem);
> - exit(3);
> + exit(EXIT_FAILURE);
Same here.
> }
>
> if (libxl_set_memory_target(ctx, domid, memorykb, 0, /* enforce */ 1)) {
> fprintf(stderr, "cannot set domid %d dynamic max memory to : %s\n", domid, mem);
> - return EXIT_FAILURE;
> + return 1;
> }
>
> - return EXIT_SUCCESS;
> + return 0;
> }
>
> int main_memset(int argc, char **argv)
> @@ -3438,7 +3442,11 @@ int main_memset(int argc, char **argv)
> domid = find_domain(argv[optind]);
> mem = argv[optind + 1];
>
> - return set_memory_target(domid, mem);
> + if (set_memory_target(domid, mem)) {
> + return EXIT_FAILURE;
> + }
> +
> + return EXIT_SUCCESS;
> }
>
> static int cd_insert(uint32_t domid, const char *virtdev, char *phys)
> --
> 1.9.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-01 14:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 12:40 [PATCH 00/10] xl: improve coding style and return more failure on failure for more xl commands Paulina Szubarczyk
2016-04-01 12:40 ` [PATCH 01/10] libxl_pci: improve return codes " Paulina Szubarczyk
2016-04-01 14:00 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 02/10] libxl-pci: clean unused return variable Paulina Szubarczyk
2016-04-01 14:13 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 03/10] libxl_pci: Return error code for more pci-* functions Paulina Szubarczyk
2016-04-01 14:20 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 04/10] xl: improve return code for freemem function Paulina Szubarczyk
2016-04-01 14:24 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 05/10] xl_cmdimpl: improve return codes for memset commands Paulina Szubarczyk
2016-04-01 14:33 ` Roger Pau Monné [this message]
2016-04-04 11:38 ` George Dunlap
2016-04-01 12:40 ` [PATCH 06/10] xl_cmdimpl: improve return codes for cd-insert commands Paulina Szubarczyk
2016-04-01 14:41 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 07/10] Add return codes for pci-detach, pci-attach, pci-asssignable-add, and pci-assignable-remove Paulina Szubarczyk
2016-04-01 12:40 ` [PATCH 08/10] libxl: improve main_tmem_* return codes Paulina Szubarczyk
2016-04-01 14:50 ` Roger Pau Monné
2016-04-01 15:09 ` Konrad Rzeszutek Wilk
2016-04-01 12:40 ` [PATCH 09/10] libxl: Fix libxl_set_memory_target return value Paulina Szubarczyk
2016-04-01 14:55 ` Roger Pau Monné
2016-04-04 11:40 ` George Dunlap
2016-04-06 10:33 ` Paulina Szubarczyk
2016-04-01 12:40 ` [PATCH 10/10] libxl: libxl_tmem functions improving coding style Paulina Szubarczyk
2016-04-01 15:14 ` Konrad Rzeszutek Wilk
2016-04-01 15:39 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.20.1604011630040.9476@mac \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=paulinaszubarczyk@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).