From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
George.Dunlap@eu.citrix.com, dario.faggioli@citrix.com,
xen-devel@lists.xenproject.org, roger.pau@citrix.com
Subject: Re: [PATCH 10/10] libxl: libxl_tmem functions improving coding style
Date: Fri, 1 Apr 2016 17:39:39 +0200 [thread overview]
Message-ID: <alpine.OSX.2.20.1604011656300.9476@mac> (raw)
In-Reply-To: <1459514413-18682-11-git-send-email-paulinaszubarczyk@gmail.com>
On Fri, 1 Apr 2016, Paulina Szubarczyk wrote:
> In accordance with CODING_SYTLE:
> - Use 'r' for return values to functions whose return values are a
> different error space (like xc_tmem_control, xc_tmem_auth)
>
> Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
> ---
> tools/libxl/libxl.c | 58 ++++++++++++++++++++++++++---------------------------
> 1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 6bb2f82..5794ade 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -6107,14 +6107,14 @@ uint32_t libxl_vm_get_start_time(libxl_ctx *ctx, uint32_t domid)
>
> char *libxl_tmem_list(libxl_ctx *ctx, uint32_t domid, int use_long)
> {
> - int rc;
> + int r;
> char _buf[32768];
> GC_INIT(ctx);
>
> - rc = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_LIST, domid, 32768, use_long,
> + r = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_LIST, domid, 32768, use_long,
> _buf);
> - if (rc < 0) {
> - LOGEV(ERROR, rc, "Can not get tmem list");
> + if (r < 0) {
> + LOGEV(ERROR, r, "Can not get tmem list");
> GC_FREE;
> return NULL;
> }
> @@ -6125,36 +6125,36 @@ char *libxl_tmem_list(libxl_ctx *ctx, uint32_t domid, int use_long)
>
> int libxl_tmem_freeze(libxl_ctx *ctx, uint32_t domid)
> {
> - int rc;
> + int r;
> GC_INIT(ctx);
>
> - rc = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_FREEZE, domid, 0, 0,
> + r = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_FREEZE, domid, 0, 0,
> NULL);
> - if (rc < 0) {
> - LOGEV(ERROR, rc, "Can not freeze tmem pools");
> + if (r < 0) {
> + LOGEV(ERROR, r, "Can not freeze tmem pools");
> GC_FREE;
> return ERROR_FAIL;
> }
>
> GC_FREE;
> - return rc;
> + return r;
This is conceptually wrong IMHO, you are returning an error code that's
not in libxl space from a libxl function (although due to the "return"
above this is always going to be 0). I would just return 0 here, or add an
"out" label, keep rc and set it in the error case above replacing the
return with a goto out.
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-04-01 15:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 12:40 [PATCH 00/10] xl: improve coding style and return more failure on failure for more xl commands Paulina Szubarczyk
2016-04-01 12:40 ` [PATCH 01/10] libxl_pci: improve return codes " Paulina Szubarczyk
2016-04-01 14:00 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 02/10] libxl-pci: clean unused return variable Paulina Szubarczyk
2016-04-01 14:13 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 03/10] libxl_pci: Return error code for more pci-* functions Paulina Szubarczyk
2016-04-01 14:20 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 04/10] xl: improve return code for freemem function Paulina Szubarczyk
2016-04-01 14:24 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 05/10] xl_cmdimpl: improve return codes for memset commands Paulina Szubarczyk
2016-04-01 14:33 ` Roger Pau Monné
2016-04-04 11:38 ` George Dunlap
2016-04-01 12:40 ` [PATCH 06/10] xl_cmdimpl: improve return codes for cd-insert commands Paulina Szubarczyk
2016-04-01 14:41 ` Roger Pau Monné
2016-04-01 12:40 ` [PATCH 07/10] Add return codes for pci-detach, pci-attach, pci-asssignable-add, and pci-assignable-remove Paulina Szubarczyk
2016-04-01 12:40 ` [PATCH 08/10] libxl: improve main_tmem_* return codes Paulina Szubarczyk
2016-04-01 14:50 ` Roger Pau Monné
2016-04-01 15:09 ` Konrad Rzeszutek Wilk
2016-04-01 12:40 ` [PATCH 09/10] libxl: Fix libxl_set_memory_target return value Paulina Szubarczyk
2016-04-01 14:55 ` Roger Pau Monné
2016-04-04 11:40 ` George Dunlap
2016-04-06 10:33 ` Paulina Szubarczyk
2016-04-01 12:40 ` [PATCH 10/10] libxl: libxl_tmem functions improving coding style Paulina Szubarczyk
2016-04-01 15:14 ` Konrad Rzeszutek Wilk
2016-04-01 15:39 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.20.1604011656300.9476@mac \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=paulinaszubarczyk@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).