xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <stefanos@xilinx.com>, Volodymyr_Babchuk@epam.com
Subject: Re: [Xen-devel] [PATCH v5 1/7] xen/arm: pass node to device_tree_for_each_node
Date: Tue, 13 Aug 2019 18:25:05 +0100	[thread overview]
Message-ID: <b6fa1f2b-52e8-b7ac-df32-aab9d81b4ca8@arm.com> (raw)
In-Reply-To: <20190812222844.9636-1-sstabellini@kernel.org>

Hi,

On 8/12/19 11:28 PM, Stefano Stabellini wrote:
> Add a new parameter to device_tree_for_each_node: node, the node to
> start the search from. Passing 0 triggers the old behavior.
> 
> Set min_depth to depth of the current node + 1 and replace the for
> loop with a do/while loop to avoid scanning siblings of the initial node
> passed as an argument.
> 
> We need this change because in follow-up patches we want to be able to
> use reuse device_tree_for_each_node to call a function for each children
> nodes of a provided node and the node itself.

I have to say this would be fairly confusing for reserved-memory because 
you are only expecting to parse the subnode.

Furthermore, in the unlikely event to first node does have a property 
"regs", then #address-cells and #size-cells is going to be incorrect (we 
don't look up for its parent...).

So I think it would be best to consider to ignore the first node. This 
should not be an issue as none of the user care about the root node (i.e 
/). It would also makes the interface more straightforward.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-08-13 17:25 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 22:28 [Xen-devel] [PATCH v5 0/7] reserved-memory in dom0 Stefano Stabellini
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 1/7] xen/arm: pass node to device_tree_for_each_node Stefano Stabellini
2019-08-13 13:45   ` Volodymyr Babchuk
2019-08-14 22:12     ` Stefano Stabellini
2019-08-13 17:25   ` Julien Grall [this message]
2019-08-14 22:11     ` Stefano Stabellini
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 2/7] xen/arm: make process_memory_node a device_tree_node_func Stefano Stabellini
2019-08-13 14:14   ` Volodymyr Babchuk
2019-08-14 22:35     ` Stefano Stabellini
2019-08-15  9:12       ` Julien Grall
2019-08-15 11:20       ` Volodymyr Babchuk
2019-08-15 11:24         ` Julien Grall
2019-08-15 11:29           ` Julien Grall
2019-08-15 12:14             ` Volodymyr Babchuk
2019-08-15 12:33               ` Julien Grall
2019-08-15 13:51                 ` Volodymyr Babchuk
2019-08-15 14:15                   ` Julien Grall
2019-08-13 17:37   ` Julien Grall
2019-08-14 22:54     ` Stefano Stabellini
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions Stefano Stabellini
2019-08-13 14:23   ` Volodymyr Babchuk
2019-08-13 14:46     ` Julien Grall
2019-08-13 15:14       ` Volodymyr Babchuk
2019-08-13 15:15         ` Julien Grall
2019-08-13 15:39           ` Volodymyr Babchuk
2019-08-14 12:48   ` Julien Grall
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 4/7] xen/arm: early_print_info print reserved_mem Stefano Stabellini
2019-08-13 14:28   ` Volodymyr Babchuk
2019-08-13 14:47     ` Julien Grall
2019-08-14 22:21       ` Stefano Stabellini
2019-08-14 12:52   ` Julien Grall
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 5/7] xen/arm: handle reserved-memory in consider_modules and dt_unreserved_regions Stefano Stabellini
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions Stefano Stabellini
2019-08-13 14:34   ` Volodymyr Babchuk
2019-08-13 14:55     ` Julien Grall
2019-08-14 22:40       ` Stefano Stabellini
2019-08-15  9:15         ` Julien Grall
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 7/7] xen/arm: add reserved-memory regions to the dom0 memory node Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6fa1f2b-52e8-b7ac-df32-aab9d81b4ca8@arm.com \
    --to=julien.grall@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=stefanos@xilinx.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).