[Xen-devel] [OSSTEST PATCH] ts-xen-install: Drop gdb= parameter

[Xen-devel] [OSSTEST PATCH] ts-xen-install: Drop gdb= parameter

[Ian Jackson]

This has been there forever and I doubt anyone has ever used it.

Andrew Cooper tells me that it needs an L or H suffix so probably
doesn't work.  Recent changes to more conspicuously report command
line parsing failures highlighted this issue.

Suggested-by: Andrew Cooper <Andrew.Cooper3@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 ts-xen-install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-xen-install b/ts-xen-install
index 154f78c7..d8e9d7e6 100755
--- a/ts-xen-install
+++ b/ts-xen-install
@@ -197,7 +197,7 @@ sub setupboot () {
 				: 'com1');
 
     if ( $cons eq "com1" ) {
-	$xenhopt .= " com1=$c{Baud},8n1 console=com1,vga gdb=com1";
+	$xenhopt .= " com1=$c{Baud},8n1 console=com1,vga";
     } elsif ( $cons eq "dtuart" ) {
 	$xenhopt .= " console=dtuart";
 	my $dtuart= get_host_property($ho, 'XenDTUARTPath', undef);
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [OSSTEST PATCH] ts-xen-install: Drop gdb= parameter

[Andrew Cooper]

On 19/12/2019 15:07, Ian Jackson wrote:
> This has been there forever and I doubt anyone has ever used it.
>
> Andrew Cooper tells me that it needs an L or H suffix so probably
> doesn't work.  Recent changes to more conspicuously report command
> line parsing failures highlighted this issue.
>
> Suggested-by: Andrew Cooper <Andrew.Cooper3@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

http://xenbits.xen.org/docs/unstable/misc/xen-command-line.html#gdb

It needs an L or H suffix to instruct Xen how to mux the console with
the gdb remote protocol based on the high bit on 8-bit clean line.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel