* [Xen-devel] [PATCH] livepatch: Identify the object file create-diff-object dislikes
@ 2019-08-27 15:38 Andrew Cooper
2019-08-27 15:45 ` Konrad Rzeszutek Wilk
2019-08-27 15:45 ` Ross Lagerwall
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Cooper @ 2019-08-27 15:38 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Ross Lagerwall, Konrad Rzeszutek Wilk
... rather than leaving the user with no hint as to where to debug next.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Ross Lagerwall <ross.lagerwall@citrix.com>
---
livepatch-build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/livepatch-build b/livepatch-build
index 7068faf..b198c97 100755
--- a/livepatch-build
+++ b/livepatch-build
@@ -140,7 +140,7 @@ function create_patch()
die "no core file found, run 'ulimit -c unlimited' and try to recreate"
fi
# create-diff-object returns 3 if no functional change is found
- [[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || ERROR=$(expr $ERROR "+" 1)
+ [[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || { ERROR=$(expr $ERROR "+" 1); warn "create-diff-object $i rc $rc"; }
if [[ $rc -eq 0 ]]; then
CHANGED=1
fi
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] livepatch: Identify the object file create-diff-object dislikes
2019-08-27 15:38 [Xen-devel] [PATCH] livepatch: Identify the object file create-diff-object dislikes Andrew Cooper
@ 2019-08-27 15:45 ` Konrad Rzeszutek Wilk
2019-08-27 15:45 ` Ross Lagerwall
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2019-08-27 15:45 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Ross Lagerwall
On August 27, 2019 11:38:39 AM EDT, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>... rather than leaving the user with no hint as to where to debug
>next.
>
>Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>---
>CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>CC: Ross Lagerwall <ross.lagerwall@citrix.com>
>---
> livepatch-build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/livepatch-build b/livepatch-build
>index 7068faf..b198c97 100755
>--- a/livepatch-build
>+++ b/livepatch-build
>@@ -140,7 +140,7 @@ function create_patch()
>die "no core file found, run 'ulimit -c unlimited' and try to recreate"
> fi
> # create-diff-object returns 3 if no functional change is found
>- [[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || ERROR=$(expr $ERROR "+"
>1)
>+ [[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || { ERROR=$(expr $ERROR
>"+" 1); warn "create-diff-object $i rc $rc"; }
> if [[ $rc -eq 0 ]]; then
> CHANGED=1
> fi
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] livepatch: Identify the object file create-diff-object dislikes
2019-08-27 15:38 [Xen-devel] [PATCH] livepatch: Identify the object file create-diff-object dislikes Andrew Cooper
2019-08-27 15:45 ` Konrad Rzeszutek Wilk
@ 2019-08-27 15:45 ` Ross Lagerwall
1 sibling, 0 replies; 3+ messages in thread
From: Ross Lagerwall @ 2019-08-27 15:45 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Konrad Rzeszutek Wilk
On 08/27/2019 04:38 PM, Andrew Cooper wrote:
> ... rather than leaving the user with no hint as to where to debug next.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Thanks
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-27 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-27 15:38 [Xen-devel] [PATCH] livepatch: Identify the object file create-diff-object dislikes Andrew Cooper
2019-08-27 15:45 ` Konrad Rzeszutek Wilk
2019-08-27 15:45 ` Ross Lagerwall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).