From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Petre Pircalabu <ppircalabu@bitdefender.com>,
xen-devel@lists.xenproject.org
Cc: "Tamas K Lengyel" <tamas@tklengyel.com>, "Wei Liu" <wl@xen.org>,
"Razvan Cojocaru" <rcojocaru@bitdefender.com>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Julien Grall" <julien.grall@arm.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 4/9] vm_event: Remove "ring" suffix from vm_event_check_ring
Date: Fri, 31 May 2019 16:32:24 -0700 [thread overview]
Message-ID: <c2d6c522-7c70-bcce-8d3a-d919227e0c3b@citrix.com> (raw)
In-Reply-To: <9e731967741fac6046a3a862964ac61ba7cababc.1559224640.git.ppircalabu@bitdefender.com>
On 30/05/2019 07:18, Petre Pircalabu wrote:
> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
> index 3505589..1dd3e48 100644
> --- a/xen/common/vm_event.c
> +++ b/xen/common/vm_event.c
> @@ -277,7 +277,7 @@ void vm_event_put_request(struct domain *d,
> RING_IDX req_prod;
> struct vcpu *curr = current;
>
> - if( !vm_event_check_ring(ved))
> + if( !vm_event_check(ved))
Ideally with fixing up this style error, as you're changing the line.
This can be fixed on commit.
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Petre Pircalabu <ppircalabu@bitdefender.com>,
<xen-devel@lists.xenproject.org>
Cc: "Tamas K Lengyel" <tamas@tklengyel.com>, "Wei Liu" <wl@xen.org>,
"Razvan Cojocaru" <rcojocaru@bitdefender.com>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Julien Grall" <julien.grall@arm.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 4/9] vm_event: Remove "ring" suffix from vm_event_check_ring
Date: Fri, 31 May 2019 16:32:24 -0700 [thread overview]
Message-ID: <c2d6c522-7c70-bcce-8d3a-d919227e0c3b@citrix.com> (raw)
Message-ID: <20190531233224.0FDHojedaY5rvM4CyD515Tlebg9ulIVlr84vHqPl6co@z> (raw)
In-Reply-To: <9e731967741fac6046a3a862964ac61ba7cababc.1559224640.git.ppircalabu@bitdefender.com>
On 30/05/2019 07:18, Petre Pircalabu wrote:
> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
> index 3505589..1dd3e48 100644
> --- a/xen/common/vm_event.c
> +++ b/xen/common/vm_event.c
> @@ -277,7 +277,7 @@ void vm_event_put_request(struct domain *d,
> RING_IDX req_prod;
> struct vcpu *curr = current;
>
> - if( !vm_event_check_ring(ved))
> + if( !vm_event_check(ved))
Ideally with fixing up this style error, as you're changing the line.
This can be fixed on commit.
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-31 23:32 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 14:18 [PATCH 0/9] Per vcpu vm_event channels Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-05-30 14:18 ` [PATCH 1/9] tools/libxc: Consistent usage of xc_vm_event_* interface Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-05-31 23:01 ` Andrew Cooper
2019-05-31 23:01 ` [Xen-devel] " Andrew Cooper
2019-06-04 14:23 ` Petre Ovidiu PIRCALABU
2019-06-04 16:07 ` Andrew Cooper
2019-05-30 14:18 ` [PATCH 2/9] vm_event: Define VM_EVENT type Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-05-31 23:26 ` Andrew Cooper
2019-05-31 23:26 ` [Xen-devel] " Andrew Cooper
2019-06-03 22:22 ` Tamas K Lengyel
2019-06-03 22:22 ` [Xen-devel] " Tamas K Lengyel
2019-06-03 22:26 ` Tamas K Lengyel
2019-06-03 22:26 ` [Xen-devel] " Tamas K Lengyel
2019-06-04 16:09 ` Andrew Cooper
2019-06-04 10:12 ` Petre Ovidiu PIRCALABU
2019-06-04 10:12 ` [Xen-devel] " Petre Ovidiu PIRCALABU
2019-06-03 15:51 ` Jan Beulich
2019-06-03 15:51 ` [Xen-devel] " Jan Beulich
2019-05-30 14:18 ` [PATCH 3/9] vm_event: Make ‘local’ functions ‘static’ Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-05-31 23:28 ` Andrew Cooper
2019-05-31 23:28 ` [Xen-devel] " Andrew Cooper
2019-06-02 0:36 ` Tamas K Lengyel
2019-06-02 0:36 ` [Xen-devel] " Tamas K Lengyel
2019-05-30 14:18 ` [PATCH 4/9] vm_event: Remove "ring" suffix from vm_event_check_ring Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-05-31 23:32 ` Andrew Cooper [this message]
2019-05-31 23:32 ` Andrew Cooper
2019-06-05 15:52 ` Tamas K Lengyel
2019-05-30 14:18 ` [PATCH 5/9] vm_event: Simplify vm_event interface Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-05-31 23:43 ` Andrew Cooper
2019-05-31 23:43 ` [Xen-devel] " Andrew Cooper
2019-06-01 0:06 ` Andrew Cooper
2019-06-01 0:06 ` [Xen-devel] " Andrew Cooper
2019-06-03 15:33 ` Petre Ovidiu PIRCALABU
2019-06-03 15:33 ` [Xen-devel] " Petre Ovidiu PIRCALABU
2019-05-30 14:18 ` [PATCH 6/9] vm_event: Move struct vm_event_domain to vm_event.c Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-05-31 23:44 ` Andrew Cooper
2019-05-31 23:44 ` [Xen-devel] " Andrew Cooper
2019-06-03 11:28 ` Petre Ovidiu PIRCALABU
2019-06-03 11:28 ` [Xen-devel] " Petre Ovidiu PIRCALABU
2019-06-05 15:53 ` Tamas K Lengyel
2019-05-30 14:18 ` [PATCH 7/9] vm_event: Decouple implementation details from interface Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-05-30 14:18 ` [PATCH 8/9] vm_event: Add vm_event_ng interface Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-06-04 14:43 ` Andrew Cooper
2019-06-05 17:01 ` Petre Ovidiu PIRCALABU
2019-06-06 8:37 ` Jan Beulich
2019-06-06 13:48 ` Petre Ovidiu PIRCALABU
2019-06-06 14:16 ` Jan Beulich
2019-05-30 14:18 ` [PATCH 9/9] xen-access: Add support for " Petre Pircalabu
2019-05-30 14:18 ` [Xen-devel] " Petre Pircalabu
2019-06-04 16:04 ` Andrew Cooper
2019-05-30 15:27 ` [PATCH 0/9] Per vcpu vm_event channels Tamas K Lengyel
2019-05-30 15:27 ` [Xen-devel] " Tamas K Lengyel
2019-05-31 7:07 ` Petre Ovidiu PIRCALABU
2019-05-31 7:07 ` [Xen-devel] " Petre Ovidiu PIRCALABU
2019-06-01 0:25 ` Andrew Cooper
2019-06-01 0:25 ` [Xen-devel] " Andrew Cooper
2019-06-03 14:04 ` Petre Ovidiu PIRCALABU
2019-06-03 14:04 ` [Xen-devel] " Petre Ovidiu PIRCALABU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2d6c522-7c70-bcce-8d3a-d919227e0c3b@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=ppircalabu@bitdefender.com \
--cc=rcojocaru@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).