* [PATCH] xen/arm64: livepatch: Fix build after 03957f58db
@ 2019-05-21 14:29 Julien Grall
2019-05-21 14:29 ` [Xen-devel] " Julien Grall
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Julien Grall @ 2019-05-21 14:29 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Julien Grall, sstabellini
Commit 03957f58db "xen/const: Extend the existing macro BIT to take a
suffix in parameter" didn't convert all the callers of the macro BIT.
This will result to a build breakage when enabling Livepatch on arm64.
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/arch/arm/arm64/livepatch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/arm64/livepatch.c b/xen/arch/arm/arm64/livepatch.c
index 2247b925a0..5c75779284 100644
--- a/xen/arch/arm/arm64/livepatch.c
+++ b/xen/arch/arm/arm64/livepatch.c
@@ -208,7 +208,7 @@ static int reloc_insn_imm(enum aarch64_reloc_op op, void *dest, u64 val,
sval >>= lsb;
/* Extract the value bits and shift them to bit 0. */
- imm_mask = (BIT(lsb + len) - 1) >> lsb;
+ imm_mask = (BIT(lsb + len, UL) - 1) >> lsb;
imm = sval & imm_mask;
/* Update the instruction's immediate field. */
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Xen-devel] [PATCH] xen/arm64: livepatch: Fix build after 03957f58db
2019-05-21 14:29 [PATCH] xen/arm64: livepatch: Fix build after 03957f58db Julien Grall
@ 2019-05-21 14:29 ` Julien Grall
2019-05-21 14:31 ` Andrew Cooper
2019-05-21 15:36 ` Stefano Stabellini
2 siblings, 0 replies; 8+ messages in thread
From: Julien Grall @ 2019-05-21 14:29 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Julien Grall, sstabellini
Commit 03957f58db "xen/const: Extend the existing macro BIT to take a
suffix in parameter" didn't convert all the callers of the macro BIT.
This will result to a build breakage when enabling Livepatch on arm64.
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/arch/arm/arm64/livepatch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/arm64/livepatch.c b/xen/arch/arm/arm64/livepatch.c
index 2247b925a0..5c75779284 100644
--- a/xen/arch/arm/arm64/livepatch.c
+++ b/xen/arch/arm/arm64/livepatch.c
@@ -208,7 +208,7 @@ static int reloc_insn_imm(enum aarch64_reloc_op op, void *dest, u64 val,
sval >>= lsb;
/* Extract the value bits and shift them to bit 0. */
- imm_mask = (BIT(lsb + len) - 1) >> lsb;
+ imm_mask = (BIT(lsb + len, UL) - 1) >> lsb;
imm = sval & imm_mask;
/* Update the instruction's immediate field. */
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: livepatch: Fix build after 03957f58db
2019-05-21 14:29 [PATCH] xen/arm64: livepatch: Fix build after 03957f58db Julien Grall
2019-05-21 14:29 ` [Xen-devel] " Julien Grall
@ 2019-05-21 14:31 ` Andrew Cooper
2019-05-21 14:31 ` [Xen-devel] " Andrew Cooper
2019-05-21 15:36 ` Stefano Stabellini
2 siblings, 1 reply; 8+ messages in thread
From: Andrew Cooper @ 2019-05-21 14:31 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: sstabellini
On 21/05/2019 15:29, Julien Grall wrote:
> Commit 03957f58db "xen/const: Extend the existing macro BIT to take a
> suffix in parameter" didn't convert all the callers of the macro BIT.
>
> This will result to a build breakage when enabling Livepatch on arm64.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm64: livepatch: Fix build after 03957f58db
2019-05-21 14:31 ` Andrew Cooper
@ 2019-05-21 14:31 ` Andrew Cooper
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Cooper @ 2019-05-21 14:31 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: sstabellini
On 21/05/2019 15:29, Julien Grall wrote:
> Commit 03957f58db "xen/const: Extend the existing macro BIT to take a
> suffix in parameter" didn't convert all the callers of the macro BIT.
>
> This will result to a build breakage when enabling Livepatch on arm64.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: livepatch: Fix build after 03957f58db
2019-05-21 14:29 [PATCH] xen/arm64: livepatch: Fix build after 03957f58db Julien Grall
2019-05-21 14:29 ` [Xen-devel] " Julien Grall
2019-05-21 14:31 ` Andrew Cooper
@ 2019-05-21 15:36 ` Stefano Stabellini
2019-05-21 15:36 ` [Xen-devel] " Stefano Stabellini
2019-05-21 15:37 ` Julien Grall
2 siblings, 2 replies; 8+ messages in thread
From: Stefano Stabellini @ 2019-05-21 15:36 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, sstabellini, Andrew Cooper
On Tue, 21 May 2019, Julien Grall wrote:
> Commit 03957f58db "xen/const: Extend the existing macro BIT to take a
> suffix in parameter" didn't convert all the callers of the macro BIT.
>
> This will result to a build breakage when enabling Livepatch on arm64.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/arch/arm/arm64/livepatch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/livepatch.c b/xen/arch/arm/arm64/livepatch.c
> index 2247b925a0..5c75779284 100644
> --- a/xen/arch/arm/arm64/livepatch.c
> +++ b/xen/arch/arm/arm64/livepatch.c
> @@ -208,7 +208,7 @@ static int reloc_insn_imm(enum aarch64_reloc_op op, void *dest, u64 val,
> sval >>= lsb;
>
> /* Extract the value bits and shift them to bit 0. */
> - imm_mask = (BIT(lsb + len) - 1) >> lsb;
> + imm_mask = (BIT(lsb + len, UL) - 1) >> lsb;
> imm = sval & imm_mask;
>
> /* Update the instruction's immediate field. */
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm64: livepatch: Fix build after 03957f58db
2019-05-21 15:36 ` Stefano Stabellini
@ 2019-05-21 15:36 ` Stefano Stabellini
2019-05-21 15:37 ` Julien Grall
1 sibling, 0 replies; 8+ messages in thread
From: Stefano Stabellini @ 2019-05-21 15:36 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, sstabellini, Andrew Cooper
On Tue, 21 May 2019, Julien Grall wrote:
> Commit 03957f58db "xen/const: Extend the existing macro BIT to take a
> suffix in parameter" didn't convert all the callers of the macro BIT.
>
> This will result to a build breakage when enabling Livepatch on arm64.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/arch/arm/arm64/livepatch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/livepatch.c b/xen/arch/arm/arm64/livepatch.c
> index 2247b925a0..5c75779284 100644
> --- a/xen/arch/arm/arm64/livepatch.c
> +++ b/xen/arch/arm/arm64/livepatch.c
> @@ -208,7 +208,7 @@ static int reloc_insn_imm(enum aarch64_reloc_op op, void *dest, u64 val,
> sval >>= lsb;
>
> /* Extract the value bits and shift them to bit 0. */
> - imm_mask = (BIT(lsb + len) - 1) >> lsb;
> + imm_mask = (BIT(lsb + len, UL) - 1) >> lsb;
> imm = sval & imm_mask;
>
> /* Update the instruction's immediate field. */
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: livepatch: Fix build after 03957f58db
2019-05-21 15:36 ` Stefano Stabellini
2019-05-21 15:36 ` [Xen-devel] " Stefano Stabellini
@ 2019-05-21 15:37 ` Julien Grall
2019-05-21 15:37 ` [Xen-devel] " Julien Grall
1 sibling, 1 reply; 8+ messages in thread
From: Julien Grall @ 2019-05-21 15:37 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel, Andrew Cooper
On 5/21/19 4:36 PM, Stefano Stabellini wrote:
> On Tue, 21 May 2019, Julien Grall wrote:
>> Commit 03957f58db "xen/const: Extend the existing macro BIT to take a
>> suffix in parameter" didn't convert all the callers of the macro BIT.
>>
>> This will result to a build breakage when enabling Livepatch on arm64.
>>
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
FIY it was already merged to unblock the build. From my understanding,
any ack from the rest is sufficient in that case.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm64: livepatch: Fix build after 03957f58db
2019-05-21 15:37 ` Julien Grall
@ 2019-05-21 15:37 ` Julien Grall
0 siblings, 0 replies; 8+ messages in thread
From: Julien Grall @ 2019-05-21 15:37 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel, Andrew Cooper
On 5/21/19 4:36 PM, Stefano Stabellini wrote:
> On Tue, 21 May 2019, Julien Grall wrote:
>> Commit 03957f58db "xen/const: Extend the existing macro BIT to take a
>> suffix in parameter" didn't convert all the callers of the macro BIT.
>>
>> This will result to a build breakage when enabling Livepatch on arm64.
>>
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
FIY it was already merged to unblock the build. From my understanding,
any ack from the rest is sufficient in that case.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-21 15:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 14:29 [PATCH] xen/arm64: livepatch: Fix build after 03957f58db Julien Grall
2019-05-21 14:29 ` [Xen-devel] " Julien Grall
2019-05-21 14:31 ` Andrew Cooper
2019-05-21 14:31 ` [Xen-devel] " Andrew Cooper
2019-05-21 15:36 ` Stefano Stabellini
2019-05-21 15:36 ` [Xen-devel] " Stefano Stabellini
2019-05-21 15:37 ` Julien Grall
2019-05-21 15:37 ` [Xen-devel] " Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).