From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>,
"George Dunlap" <george.dunlap@citrix.com>,
"Ian Jackson" <iwj@xenproject.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Paul Durrant" <paul@xen.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Daniel De Graaf" <dgdegra@tycho.nsa.gov>,
"Rahul Singh" <rahul.singh@arm.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2] xen/pci: Refactor PCI MSI interrupts related code
Date: Wed, 14 Apr 2021 09:08:53 +0200 [thread overview]
Message-ID: <ca4bef26-0869-8a56-e96c-04d3b41ffcd6@suse.com> (raw)
In-Reply-To: <f7659788-ff1b-23dd-e838-b35ae8ef9e50@xen.org>
On 13.04.2021 19:12, Julien Grall wrote:
> On 12/04/2021 11:49, Roger Pau Monné wrote:
>> On Fri, Apr 09, 2021 at 05:00:41PM +0100, Rahul Singh wrote:
>>> --- a/xen/include/xen/vpci.h
>>> +++ b/xen/include/xen/vpci.h
>>> @@ -91,6 +91,7 @@ struct vpci {
>>> /* FIXME: currently there's no support for SR-IOV. */
>>> } header;
>>>
>>> +#ifdef CONFIG_PCI_MSI_INTERCEPT
>>> /* MSI data. */
>>> struct vpci_msi {
>>> /* Address. */
>>> @@ -136,6 +137,7 @@ struct vpci {
>>> struct vpci_arch_msix_entry arch;
>>> } entries[];
>>> } *msix;
>>> +#endif /* CONFIG_PCI_MSI_INTERCEPT */
>>
>> Note that here you just remove two pointers from the struct, not that
>> I'm opposed to it, but it's not that much space that's saved anyway.
>> Ie: it might also be fine to just leave them as NULL unconditionally
>> on Arm.
>
> Can the two pointers be NULL on x86? If not, then I would prefer if they
> disappear on Arm so there is less chance to make any mistake (such as
> unconditionally accessing the pointer in common code).
Alternative proposal: How about making it effectively impossible to
de-reference the pointer on Arm by leaving the field there, but having
the struct definition available on non-Arm only?
Jan
next prev parent reply other threads:[~2021-04-14 7:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 16:00 [PATCH v2] xen/pci: Refactor PCI MSI interrupts related code Rahul Singh
2021-04-12 10:49 ` Roger Pau Monné
2021-04-12 11:28 ` Jan Beulich
2021-04-12 18:26 ` Rahul Singh
2021-04-12 16:28 ` Rahul Singh
2021-04-13 17:12 ` Julien Grall
2021-04-14 7:08 ` Jan Beulich [this message]
2021-04-14 8:28 ` Roger Pau Monné
2021-04-14 8:47 ` Jan Beulich
2021-04-14 8:28 ` Julien Grall
2021-04-14 8:05 ` Roger Pau Monné
2021-04-14 8:49 ` Julien Grall
2021-04-15 13:26 ` Roger Pau Monné
2021-04-15 13:31 ` Julien Grall
2021-04-19 7:16 ` Rahul Singh
2021-04-19 8:40 ` Roger Pau Monné
2021-04-19 11:16 ` Jan Beulich
2021-04-19 11:54 ` Julien Grall
2021-04-19 12:33 ` Jan Beulich
2021-04-20 13:45 ` Rahul Singh
2021-04-20 15:36 ` Jan Beulich
2021-04-21 8:07 ` Rahul Singh
2021-04-21 8:16 ` Roger Pau Monné
2021-04-21 9:15 ` Rahul Singh
2021-04-21 9:33 ` Jan Beulich
2021-04-21 11:55 ` Rahul Singh
2021-04-21 9:32 ` Jan Beulich
2021-04-21 9:01 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca4bef26-0869-8a56-e96c-04d3b41ffcd6@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=paul@xen.org \
--cc=rahul.singh@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).