xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: Fix xl.cfg documentation
@ 2023-06-07 13:54 Luca Fancellu
  2023-06-07 13:59 ` Michal Orzel
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Fancellu @ 2023-06-07 13:54 UTC (permalink / raw)
  To: xen-devel; +Cc: wei.chen, bertrand.marquis, Wei Liu, Anthony PERARD

A recent change to the documentation for the xl.cfg introduced a build
error, fix the issue.

Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration")
Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Apologise for the error! I think I was building an old version of the docs and
after the clarification from Andrew about refreshing the files with ./configure
I was able to reproduce the issue.
I didn't put any tag like Reported-by/Suggested-by because I don't know if they
can be put here? Anyway I guess it can be done on commit, Andrew reported the
issue and Michal was quick enough to suggest the fix before I've started working
on it :)
---
 docs/man/xl.cfg.5.pod.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 1b4e13ab647b..3979be2a590a 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -2955,6 +2955,8 @@ Currently, only the "sbsa_uart" model is supported for ARM.
 
 =back
 
+=over 4
+
 =item B<sve="vl">
 
 The `sve` parameter enables Arm Scalable Vector Extension (SVE) usage for the
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: Fix xl.cfg documentation
  2023-06-07 13:54 [PATCH] docs: Fix xl.cfg documentation Luca Fancellu
@ 2023-06-07 13:59 ` Michal Orzel
  2023-06-07 15:18   ` Andrew Cooper
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Orzel @ 2023-06-07 13:59 UTC (permalink / raw)
  To: Luca Fancellu, xen-devel
  Cc: wei.chen, bertrand.marquis, Wei Liu, Anthony PERARD


On 07/06/2023 15:54, Luca Fancellu wrote:
> 
> 
> A recent change to the documentation for the xl.cfg introduced a build
> error, fix the issue.
> 
> Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration")
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Tested and looks good.

Reviewed-by: Michal Orzel <michal.orzel@amd.com>
Tested-by: Michal Orzel <michal.orzel@amd.com>

~Michal


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: Fix xl.cfg documentation
  2023-06-07 13:59 ` Michal Orzel
@ 2023-06-07 15:18   ` Andrew Cooper
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2023-06-07 15:18 UTC (permalink / raw)
  To: Michal Orzel, Luca Fancellu, xen-devel
  Cc: wei.chen, bertrand.marquis, Wei Liu, Anthony PERARD

On 07/06/2023 2:59 pm, Michal Orzel wrote:
> On 07/06/2023 15:54, Luca Fancellu wrote:
>>
>> A recent change to the documentation for the xl.cfg introduced a build
>> error, fix the issue.
>>
>> Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration")
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Tested and looks good.
>
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>
> Tested-by: Michal Orzel <michal.orzel@amd.com>

Committed, thanks.

~Andrew


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-07 15:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-07 13:54 [PATCH] docs: Fix xl.cfg documentation Luca Fancellu
2023-06-07 13:59 ` Michal Orzel
2023-06-07 15:18   ` Andrew Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).