From: Jan Beulich <jbeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] HPET interrupt remapping during boot
Date: Wed, 9 Oct 2019 12:41:05 +0200 [thread overview]
Message-ID: <dd2b5da6-e1fc-a490-9276-8ad44721fa9e@suse.com> (raw)
In-Reply-To: <20191009101116.GA1389@Air-de-Roger.citrite.net>
On 09.10.2019 12:11, Roger Pau Monné wrote:
> And it does print the following when setting up the iommu:
>
> (XEN) ioapic 0 pin 0 not masked
> (XEN) vec=00 delivery=ExINT dest=P status=0 polarity=0 irr=0 trig=E mask=0 dest_id:00010000
>
> I wonder, shouldn't all pins of all the io-apics be masked at boot?
I think you might get different answers here depending on whether
you ask firmware or OS people. In fact there are cases where the
IO-APIC needs to be left in this state, I think, but such would
likely need properly reflecting in ACPI tables (albeit I don't
know/recall how this would be done; looking at the code ). This goes back to times
when IO-APICs were new and OSes would not even know about them,
yet they wouldn't get any interrupts to work if fiddling with
only the PIC (sitting behind IO-APIC pin 0).
See enable_IO_APIC(), where we actually use this property to
determine the pin behind which the 8259 sits.
I've seen quite many systems where in the BIOS setup you have an
option to select whether you have an "ACPI OS" (wording of course
varies). I've never checked whether this may e.g. reflect itself
in the handover state of the GSI 0 RTE.
In your testing patch, could you also log the PIC mask bytes?
There ought to be at least one unmasked; or wait - there actually
is a spurious interrupt there (right before IOMMU initialization):
(XEN) spurious 8259A interrupt: IRQ7.
Hence I wonder if there's not possibly a 2nd one once the IOMMU
has been set up.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-09 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 18:30 [Xen-devel] HPET interrupt remapping during boot Andrew Cooper
2019-10-09 9:31 ` Jan Beulich
2019-10-09 10:11 ` Roger Pau Monné
2019-10-09 10:41 ` Jan Beulich [this message]
2019-10-09 11:29 ` Roger Pau Monné
2019-10-09 12:03 ` Jan Beulich
2019-10-09 13:56 ` Roger Pau Monné
2019-10-09 14:59 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd2b5da6-e1fc-a490-9276-8ad44721fa9e@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).