From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 6/8] lib: move rbtree code
Date: Thu, 19 Nov 2020 11:23:54 +0100 [thread overview]
Message-ID: <df17ef4d-39c9-4a26-4aab-e17331e2be55@suse.com> (raw)
In-Reply-To: <eae3d402-b1d4-6fcb-06b8-ea337a26ab50@xen.org>
On 18.11.2020 18:46, Julien Grall wrote:
> On 23/10/2020 11:18, Jan Beulich wrote:
>> Build this code into an archive, which results in not linking it into
>> x86 final binaries. This saves about 1.5k of dead code.
>>
>> While moving the source file, take the opportunity and drop the
>> pointless EXPORT_SYMBOL().
>
> Given this code is borrowed from Linux, I don't think we want to remove
> them. This is to make easier to re-sync.
That's one view on it. My view is that we should get rid of
EXPORT_SYMBOL altogether (and it is a good opportunity to do so
here). Not the least because otherwise for future cloning of Linux
code we may then need to introduce further variants of this
construct for no real purpose.
>> --- a/xen/common/rbtree.c
>> +++ b/xen/lib/rbtree.c
>> @@ -25,7 +25,7 @@
>> #include <xen/rbtree.h>
>>
>> /*
>> - * red-black trees properties: http://en.wikipedia.org/wiki/Rbtree
>> + * red-black trees properties: http://en.wikipedia.org/wiki/Rbtree
>
> This looks like a spurious change.
Not really, no - while not visible here anymore, it's correcting an
instance of trailing whitespace. Following your request on an
earlier patch, I've also added half a sentence to the description
here to mention this entirely benign change.
Jan
next prev parent reply other threads:[~2020-11-19 10:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 10:15 [PATCH v2 0/8] xen: beginnings of moving library-like code into an archive Jan Beulich
2020-10-23 10:16 ` [PATCH v2 1/8] lib: split _ctype[] into its own object, under lib/ Jan Beulich
2020-11-18 17:00 ` Julien Grall
2020-10-23 10:17 ` [PATCH v2 2/8] lib: collect library files in an archive Jan Beulich
2020-11-18 17:06 ` Julien Grall
2020-11-19 10:15 ` Jan Beulich
2020-11-18 17:31 ` Julien Grall
2020-11-19 10:44 ` Jan Beulich
2020-10-23 10:17 ` [PATCH v2 3/8] lib: move list sorting code Jan Beulich
2020-11-18 17:38 ` Julien Grall
2020-11-19 10:10 ` Jan Beulich
2020-10-23 10:17 ` [PATCH v2 4/8] lib: move parse_size_and_unit() Jan Beulich
2020-11-18 17:39 ` Julien Grall
2020-11-18 17:57 ` Julien Grall
2020-11-24 0:58 ` Andrew Cooper
2020-11-24 9:30 ` Jan Beulich
2020-10-23 10:18 ` [PATCH v2 5/8] lib: move init_constructors() Jan Beulich
2020-11-18 17:42 ` Julien Grall
2020-10-23 10:18 ` [PATCH v2 6/8] lib: move rbtree code Jan Beulich
2020-11-18 17:46 ` Julien Grall
2020-11-19 10:23 ` Jan Beulich [this message]
2020-10-23 10:19 ` [PATCH v2 7/8] lib: move bsearch code Jan Beulich
2020-11-18 18:09 ` Julien Grall
2020-11-19 10:27 ` Jan Beulich
2020-11-23 22:49 ` Julien Grall
2020-11-24 0:40 ` Andrew Cooper
2020-11-24 9:39 ` Jan Beulich
2020-11-24 16:57 ` Julien Grall
2020-12-07 10:23 ` Jan Beulich
2020-12-09 9:41 ` Julien Grall
2020-12-09 14:27 ` Bertrand Marquis
2020-12-09 14:54 ` Jan Beulich
2020-12-09 15:06 ` Bertrand Marquis
2020-10-23 10:19 ` [PATCH v2 8/8] lib: move sort code Jan Beulich
2020-11-18 18:10 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df17ef4d-39c9-4a26-4aab-e17331e2be55@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).