From: chenbaodong <chenbaodong@mxnavi.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH] xen: 'keyhandler' is not used in null scheduler
Date: Thu, 30 May 2019 17:36:15 +0800 [thread overview]
Message-ID: <e0297fad-f05e-5a75-c958-7e7bb78e28a6@mxnavi.com> (raw)
In-Reply-To: <BBCA5C60-5657-47B6-8B7B-B1206AFA2561@citrix.com>
Hello George,
On 5/30/19 17:05, George Dunlap wrote:
>> On May 30, 2019, at 6:47 AM, Baodong Chen <chenbaodong@mxnavi.com> wrote:
>>
>> So remove 'keyhandler.h' include.
>> Also add 'static' prefix for 'schud_bull_def'
>>
>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
> Thanks for the patch — these changes look good. I think the title would be better something like:
>
> xen/sched_null: Superficial clean-ups
>
> Then just list both in bullet points; something like:
>
> * Remove unused dependency ‘keyhandler.’h
> * Make sched_null_def static
>
> Would you mind re-sending the patch? You can add:
>
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
Thanks for your review, resent.
> Thanks,
> -George
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: chenbaodong <chenbaodong@mxnavi.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [Xen-devel] [PATCH] xen: 'keyhandler' is not used in null scheduler
Date: Thu, 30 May 2019 17:36:15 +0800 [thread overview]
Message-ID: <e0297fad-f05e-5a75-c958-7e7bb78e28a6@mxnavi.com> (raw)
Message-ID: <20190530093615.N8IWb2i94q9gNPGjLib_OVzdXBvY9NI9-V5mEX1HarY@z> (raw)
In-Reply-To: <BBCA5C60-5657-47B6-8B7B-B1206AFA2561@citrix.com>
Hello George,
On 5/30/19 17:05, George Dunlap wrote:
>> On May 30, 2019, at 6:47 AM, Baodong Chen <chenbaodong@mxnavi.com> wrote:
>>
>> So remove 'keyhandler.h' include.
>> Also add 'static' prefix for 'schud_bull_def'
>>
>> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
> Thanks for the patch — these changes look good. I think the title would be better something like:
>
> xen/sched_null: Superficial clean-ups
>
> Then just list both in bullet points; something like:
>
> * Remove unused dependency ‘keyhandler.’h
> * Make sched_null_def static
>
> Would you mind re-sending the patch? You can add:
>
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
Thanks for your review, resent.
> Thanks,
> -George
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-30 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 5:47 [PATCH] xen: 'keyhandler' is not used in null scheduler Baodong Chen
2019-05-30 5:47 ` [Xen-devel] " Baodong Chen
2019-05-30 9:05 ` George Dunlap
2019-05-30 9:05 ` [Xen-devel] " George Dunlap
2019-05-30 9:36 ` chenbaodong [this message]
2019-05-30 9:36 ` chenbaodong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0297fad-f05e-5a75-c958-7e7bb78e28a6@mxnavi.com \
--to=chenbaodong@mxnavi.com \
--cc=George.Dunlap@citrix.com \
--cc=dfaggioli@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).