* [PATCH] common/Kconfig: sort HAS_*
@ 2020-09-22 7:47 Jan Beulich
2020-09-22 9:09 ` Julien Grall
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2020-09-22 7:47 UTC (permalink / raw)
To: xen-devel
Cc: Andrew Cooper, George Dunlap, Ian Jackson, Julien Grall, Wei Liu,
Stefano Stabellini
Later additions look to have been put at the end, with MEM_ACCESS*
somewhere in the middle. Re-sort this part of the file, in the hope that
future additions will be made noticing the intentions here.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -34,16 +34,11 @@ config HAS_EX_TABLE
config HAS_FAST_MULTIPLY
bool
-config MEM_ACCESS_ALWAYS_ON
+config HAS_IOPORTS
bool
-config MEM_ACCESS
- def_bool MEM_ACCESS_ALWAYS_ON
- prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
- ---help---
-
- Framework to configure memory access types for guests and receive
- related events in userspace.
+config HAS_KEXEC
+ bool
config HAS_MEM_PAGING
bool
@@ -51,17 +46,22 @@ config HAS_MEM_PAGING
config HAS_PDX
bool
-config HAS_UBSAN
+config HAS_SCHED_GRANULARITY
bool
-config HAS_KEXEC
+config HAS_UBSAN
bool
-config HAS_IOPORTS
+config MEM_ACCESS_ALWAYS_ON
bool
-config HAS_SCHED_GRANULARITY
- bool
+config MEM_ACCESS
+ def_bool MEM_ACCESS_ALWAYS_ON
+ prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
+ ---help---
+
+ Framework to configure memory access types for guests and receive
+ related events in userspace.
config NEEDS_LIBELF
bool
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] common/Kconfig: sort HAS_*
2020-09-22 7:47 [PATCH] common/Kconfig: sort HAS_* Jan Beulich
@ 2020-09-22 9:09 ` Julien Grall
0 siblings, 0 replies; 2+ messages in thread
From: Julien Grall @ 2020-09-22 9:09 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Cc: Andrew Cooper, George Dunlap, Ian Jackson, Wei Liu, Stefano Stabellini
Hi Jan,
On 22/09/2020 08:47, Jan Beulich wrote:
> Later additions look to have been put at the end, with MEM_ACCESS*
> somewhere in the middle. Re-sort this part of the file, in the hope that
> future additions will be made noticing the intentions here.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Julien Grall <jgrall@amazon.com>
Cheers,
>
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -34,16 +34,11 @@ config HAS_EX_TABLE
> config HAS_FAST_MULTIPLY
> bool
>
> -config MEM_ACCESS_ALWAYS_ON
> +config HAS_IOPORTS
> bool
>
> -config MEM_ACCESS
> - def_bool MEM_ACCESS_ALWAYS_ON
> - prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
> - ---help---
> -
> - Framework to configure memory access types for guests and receive
> - related events in userspace.
> +config HAS_KEXEC
> + bool
>
> config HAS_MEM_PAGING
> bool
> @@ -51,17 +46,22 @@ config HAS_MEM_PAGING
> config HAS_PDX
> bool
>
> -config HAS_UBSAN
> +config HAS_SCHED_GRANULARITY
> bool
>
> -config HAS_KEXEC
> +config HAS_UBSAN
> bool
>
> -config HAS_IOPORTS
> +config MEM_ACCESS_ALWAYS_ON
> bool
>
> -config HAS_SCHED_GRANULARITY
> - bool
> +config MEM_ACCESS
> + def_bool MEM_ACCESS_ALWAYS_ON
> + prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
> + ---help---
> +
> + Framework to configure memory access types for guests and receive
> + related events in userspace.
>
> config NEEDS_LIBELF
> bool
>
--
Julien Grall
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-22 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 7:47 [PATCH] common/Kconfig: sort HAS_* Jan Beulich
2020-09-22 9:09 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).