* [PATCH] x86/altp2m: don't consider "active" when enabling failed
@ 2021-08-25 9:31 Jan Beulich
2021-10-18 8:26 ` Ping: " Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2021-08-25 9:31 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, George Dunlap
We should not rely on guests to not use altp2m after reporting failure
of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
this case.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -4609,6 +4609,8 @@ static int do_altp2m_op(
if ( ostate )
p2m_flush_altp2m(d);
}
+ else if ( rc )
+ d->arch.altp2m_active = false;
domain_unpause_except_self(d);
break;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Ping: [PATCH] x86/altp2m: don't consider "active" when enabling failed
2021-08-25 9:31 [PATCH] x86/altp2m: don't consider "active" when enabling failed Jan Beulich
@ 2021-10-18 8:26 ` Jan Beulich
2021-10-18 13:16 ` Tamas K Lengyel
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2021-10-18 8:26 UTC (permalink / raw)
To: Andrew Cooper
Cc: George Dunlap, xen-devel, Ian Jackson, Tamas K Lengyel,
Petre Pircalabu, Alexandru Isaila
On 25.08.2021 11:31, Jan Beulich wrote:
> We should not rely on guests to not use altp2m after reporting failure
> of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
> this case.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Because of their relationship, I'm also Cc-ing the vm-event maintainers /
reviewers: Maybe one of you would care to review this one?
Jan
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -4609,6 +4609,8 @@ static int do_altp2m_op(
> if ( ostate )
> p2m_flush_altp2m(d);
> }
> + else if ( rc )
> + d->arch.altp2m_active = false;
>
> domain_unpause_except_self(d);
> break;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Ping: [PATCH] x86/altp2m: don't consider "active" when enabling failed
2021-10-18 8:26 ` Ping: " Jan Beulich
@ 2021-10-18 13:16 ` Tamas K Lengyel
2021-10-19 7:45 ` Roger Pau Monné
0 siblings, 1 reply; 4+ messages in thread
From: Tamas K Lengyel @ 2021-10-18 13:16 UTC (permalink / raw)
To: Jan Beulich
Cc: Andrew Cooper, George Dunlap, xen-devel, Ian Jackson,
Petre Pircalabu, Alexandru Isaila
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Mon, Oct 18, 2021 at 4:26 AM Jan Beulich <jbeulich@suse.com> wrote:
> On 25.08.2021 11:31, Jan Beulich wrote:
> > We should not rely on guests to not use altp2m after reporting failure
> > of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
> > this case.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Because of their relationship, I'm also Cc-ing the vm-event maintainers /
> reviewers: Maybe one of you would care to review this one?
>
> Jan
>
> > --- a/xen/arch/x86/hvm/hvm.c
> > +++ b/xen/arch/x86/hvm/hvm.c
> > @@ -4609,6 +4609,8 @@ static int do_altp2m_op(
> > if ( ostate )
> > p2m_flush_altp2m(d);
> > }
> > + else if ( rc )
> > + d->arch.altp2m_active = false;
> >
> > domain_unpause_except_self(d);
> > break;
Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>
[-- Attachment #2: Type: text/html, Size: 1501 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Ping: [PATCH] x86/altp2m: don't consider "active" when enabling failed
2021-10-18 13:16 ` Tamas K Lengyel
@ 2021-10-19 7:45 ` Roger Pau Monné
0 siblings, 0 replies; 4+ messages in thread
From: Roger Pau Monné @ 2021-10-19 7:45 UTC (permalink / raw)
To: Tamas K Lengyel
Cc: Jan Beulich, Andrew Cooper, George Dunlap, xen-devel,
Ian Jackson, Petre Pircalabu, Alexandru Isaila
On Mon, Oct 18, 2021 at 09:16:30AM -0400, Tamas K Lengyel wrote:
> On Mon, Oct 18, 2021 at 4:26 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> > On 25.08.2021 11:31, Jan Beulich wrote:
> > > We should not rely on guests to not use altp2m after reporting failure
> > > of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
> > > this case.
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
> > Because of their relationship, I'm also Cc-ing the vm-event maintainers /
> > reviewers: Maybe one of you would care to review this one?
> >
> > Jan
> >
> > > --- a/xen/arch/x86/hvm/hvm.c
> > > +++ b/xen/arch/x86/hvm/hvm.c
> > > @@ -4609,6 +4609,8 @@ static int do_altp2m_op(
> > > if ( ostate )
> > > p2m_flush_altp2m(d);
> > > }
> > > + else if ( rc )
> > > + d->arch.altp2m_active = false;
> > >
> > > domain_unpause_except_self(d);
> > > break;
>
>
> Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-19 7:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 9:31 [PATCH] x86/altp2m: don't consider "active" when enabling failed Jan Beulich
2021-10-18 8:26 ` Ping: " Jan Beulich
2021-10-18 13:16 ` Tamas K Lengyel
2021-10-19 7:45 ` Roger Pau Monné
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).