From: Julien Grall <julien.grall@arm.com> To: Baodong Chen <chenbaodong@mxnavi.com>, xen-devel@lists.xenproject.org Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com> Subject: Re: [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id' Date: Fri, 31 May 2019 11:52:08 +0100 [thread overview] Message-ID: <f3dbafae-4865-5233-3c8f-ede397c5f293@arm.com> (raw) In-Reply-To: <1559272702-13459-1-git-send-email-chenbaodong@mxnavi.com> Hi, On 5/31/19 4:18 AM, Baodong Chen wrote: > Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system. I am happy with the change, although AFAIK cpupool is not instantiated that often. Are you planning to have more instantiation of it? Cheers, > > Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com> > --- > xen/include/xen/sched-if.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h > index 92bc7a0..f0cf210 100644 > --- a/xen/include/xen/sched-if.h > +++ b/xen/include/xen/sched-if.h > @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const struct scheduler *s, > struct cpupool > { > int cpupool_id; > + unsigned int n_dom; > cpumask_var_t cpu_valid; /* all cpus assigned to pool */ > struct cpupool *next; > - unsigned int n_dom; > struct scheduler *sched; > atomic_t refcnt; > }; > -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com> To: Baodong Chen <chenbaodong@mxnavi.com>, xen-devel@lists.xenproject.org Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com> Subject: Re: [Xen-devel] [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id' Date: Fri, 31 May 2019 11:52:08 +0100 [thread overview] Message-ID: <f3dbafae-4865-5233-3c8f-ede397c5f293@arm.com> (raw) Message-ID: <20190531105208.FgwcBk5hh8QYvYYLsz2VlDj3ZykaZP32tR8bFSCDT1M@z> (raw) In-Reply-To: <1559272702-13459-1-git-send-email-chenbaodong@mxnavi.com> Hi, On 5/31/19 4:18 AM, Baodong Chen wrote: > Thus, sizeof(struct cpupool) will save 8 bytes for 64-bit system. I am happy with the change, although AFAIK cpupool is not instantiated that often. Are you planning to have more instantiation of it? Cheers, > > Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com> > --- > xen/include/xen/sched-if.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h > index 92bc7a0..f0cf210 100644 > --- a/xen/include/xen/sched-if.h > +++ b/xen/include/xen/sched-if.h > @@ -213,9 +213,9 @@ static inline void sched_free_domdata(const struct scheduler *s, > struct cpupool > { > int cpupool_id; > + unsigned int n_dom; > cpumask_var_t cpu_valid; /* all cpus assigned to pool */ > struct cpupool *next; > - unsigned int n_dom; > struct scheduler *sched; > atomic_t refcnt; > }; > -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-31 10:52 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-31 3:18 [PATCH] xen: put cpupool's member 'n_dom' after 'cpupool_id' Baodong Chen 2019-05-31 3:18 ` [Xen-devel] " Baodong Chen 2019-05-31 10:52 ` Julien Grall [this message] 2019-05-31 10:52 ` Julien Grall 2019-06-03 1:48 ` chenbaodong 2019-06-03 1:48 ` [Xen-devel] " chenbaodong 2019-06-03 9:30 ` Julien Grall 2019-06-03 9:30 ` [Xen-devel] " Julien Grall 2019-06-03 10:06 ` chenbaodong 2019-06-03 10:06 ` [Xen-devel] " chenbaodong 2019-06-17 15:19 ` Jan Beulich 2019-06-17 15:22 ` Juergen Gross
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f3dbafae-4865-5233-3c8f-ede397c5f293@arm.com \ --to=julien.grall@arm.com \ --cc=George.Dunlap@eu.citrix.com \ --cc=andrew.cooper3@citrix.com \ --cc=chenbaodong@mxnavi.com \ --cc=ian.jackson@eu.citrix.com \ --cc=jbeulich@suse.com \ --cc=konrad.wilk@oracle.com \ --cc=sstabellini@kernel.org \ --cc=tim@xen.org \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).