* [xen-unstable test] 162771: regressions - FAIL @ 2021-06-14 2:21 osstest service owner 2021-06-14 6:41 ` Juergen Gross 0 siblings, 1 reply; 4+ messages in thread From: osstest service owner @ 2021-06-14 2:21 UTC (permalink / raw) To: xen-devel, osstest-admin flight 162771 xen-unstable real [real] flight 162783 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/162771/ http://logs.test-lab.xenproject.org/osstest/logs/162783/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 162533 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 162533 test-amd64-amd64-i386-pvgrub 17 guest-localmigrate fail REGR. vs. 162533 test-amd64-amd64-amd64-pvgrub 17 guest-localmigrate fail REGR. vs. 162533 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 162533 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 162533 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 162533 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 162533 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 162533 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 162533 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 162533 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 162533 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 162533 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 162533 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 162533 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 93031fbe9f4c341a2e7950a088025ea550291433 baseline version: xen 5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1 Last test of basis 162533 2021-06-08 01:53:53 Z 6 days Failing since 162556 2021-06-08 22:39:08 Z 5 days 7 attempts Testing same since 162696 2021-06-12 11:59:49 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper <andrew.cooper3@citrix.com> Anthony PERARD <anthony.perard@citrix.com> Bobby Eshleman <bobbyeshleman@gmail.com> Christian Lindig <christian.lindig@citrix.com> Connor Davis <connojdavis@gmail.com> Dario Faggioli <dfaggioli@suse.com> Edgar E. Iglesias <edgar.iglesias@xilinx.com> George Dunlap <george.dunlap@citrix.com> Ian Jackson <iwj@xenproject.org> Jan Beulich <jbeulich@suse.com> Juergen Gross <jgross@suse.com> Julien Grall <jgrall@amazon.com> Roger Pau Monné <roger.pau@citrix.com> Stefano Stabellini <sstabellini@kernel.org> Stefano Stabellini <stefano.stabellini@xilinx.com> Tim Deegan <tim@xen.org> Wei Liu <wl@xen.org> jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 724 lines long.) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [xen-unstable test] 162771: regressions - FAIL 2021-06-14 2:21 [xen-unstable test] 162771: regressions - FAIL osstest service owner @ 2021-06-14 6:41 ` Juergen Gross 2021-06-14 11:58 ` Jan Beulich 0 siblings, 1 reply; 4+ messages in thread From: Juergen Gross @ 2021-06-14 6:41 UTC (permalink / raw) To: osstest service owner, xen-devel; +Cc: Ian Jackson, Wei Liu, Andrew Cooper [-- Attachment #1.1.1: Type: text/plain, Size: 1991 bytes --] On 14.06.21 04:21, osstest service owner wrote: > flight 162771 xen-unstable real [real] > flight 162783 xen-unstable real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/162771/ > http://logs.test-lab.xenproject.org/osstest/logs/162783/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 162533 > test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 162533 > test-amd64-amd64-i386-pvgrub 17 guest-localmigrate fail REGR. vs. 162533 > test-amd64-amd64-amd64-pvgrub 17 guest-localmigrate fail REGR. vs. 162533 Hmm, this is rather unfortunate. Those last 2 tests failed due to commit 7bd8989ab77b6ade3b, but just reverting that patch doesn't seem right to me either. The Linux kernel has a bug here: it will initially set max_pfn in the shared_info page to the size of the p2m_list (so my reasoning for above patch was wrong in this case), but when growing the p2m_list (e.g. due to ballooning or grant mapping), it will store a real pfn number in max_pfn. But even this pfn might be wrong, as only the pfn leading to allocation of a new p2m page will be stored in max_pfn, any higher new pfn having its p2m entry in the new p2m page won't result in a new max_pfn entry. As a result I think the only sane handling would be to assume the max_pfn value read from the shared_info page is really a pfn. This value should be adjusted to specify the last pfn of the related p2m page, and the resulting last p2m page should be tolerated to not be valid. Another variant would be to just revert above commit and modify the semantics of max_pfn in the shared_info page to really mean max_pfn+1. This would result in possible migration failures of ballooned Linux systems as today. Additionally I'll fix the Linux kernel, of course. Any thoughts? Juergen [-- Attachment #1.1.2: OpenPGP public key --] [-- Type: application/pgp-keys, Size: 3135 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [xen-unstable test] 162771: regressions - FAIL 2021-06-14 6:41 ` Juergen Gross @ 2021-06-14 11:58 ` Jan Beulich 2021-06-14 12:06 ` Juergen Gross 0 siblings, 1 reply; 4+ messages in thread From: Jan Beulich @ 2021-06-14 11:58 UTC (permalink / raw) To: Juergen Gross Cc: Ian Jackson, Wei Liu, Andrew Cooper, osstest service owner, xen-devel On 14.06.2021 08:41, Juergen Gross wrote: > On 14.06.21 04:21, osstest service owner wrote: >> flight 162771 xen-unstable real [real] >> flight 162783 xen-unstable real-retest [real] >> http://logs.test-lab.xenproject.org/osstest/logs/162771/ >> http://logs.test-lab.xenproject.org/osstest/logs/162783/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 162533 >> test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 162533 >> test-amd64-amd64-i386-pvgrub 17 guest-localmigrate fail REGR. vs. 162533 >> test-amd64-amd64-amd64-pvgrub 17 guest-localmigrate fail REGR. vs. 162533 > > Hmm, this is rather unfortunate. > > Those last 2 tests failed due to commit 7bd8989ab77b6ade3b, but just > reverting that patch doesn't seem right to me either. > > The Linux kernel has a bug here: it will initially set max_pfn in the > shared_info page to the size of the p2m_list (so my reasoning for above > patch was wrong in this case), but when growing the p2m_list (e.g. due > to ballooning or grant mapping), it will store a real pfn number in > max_pfn. But even this pfn might be wrong, as only the pfn leading to > allocation of a new p2m page will be stored in max_pfn, any higher new > pfn having its p2m entry in the new p2m page won't result in a new > max_pfn entry. > > As a result I think the only sane handling would be to assume the > max_pfn value read from the shared_info page is really a pfn. This would be contrary to the public interface header having /* * Number of valid entries in the p2m table(s) anchored at * pfn_to_mfn_frame_list_list and/or p2m_vaddr. */ unsigned long max_pfn; IOW the name containing "max" is misleading (should be "num" or alike), but there's no room imo to change this. > This > value should be adjusted to specify the last pfn of the related p2m > page, and the resulting last p2m page should be tolerated to not be > valid. > > Another variant would be to just revert above commit and modify the > semantics of max_pfn in the shared_info page to really mean max_pfn+1. But that's what it is already, according to the comment. Are you suggesting there was code prior to the change you've quoted that already violated this (in Xen or the tool stack, that is, not the issue you suggest has been present in Linux)? Jan > This would result in possible migration failures of ballooned Linux > systems as today. > > Additionally I'll fix the Linux kernel, of course. > > Any thoughts? > > > Juergen > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [xen-unstable test] 162771: regressions - FAIL 2021-06-14 11:58 ` Jan Beulich @ 2021-06-14 12:06 ` Juergen Gross 0 siblings, 0 replies; 4+ messages in thread From: Juergen Gross @ 2021-06-14 12:06 UTC (permalink / raw) To: Jan Beulich Cc: Ian Jackson, Wei Liu, Andrew Cooper, osstest service owner, xen-devel [-- Attachment #1.1.1: Type: text/plain, Size: 2884 bytes --] On 14.06.21 13:58, Jan Beulich wrote: > On 14.06.2021 08:41, Juergen Gross wrote: >> On 14.06.21 04:21, osstest service owner wrote: >>> flight 162771 xen-unstable real [real] >>> flight 162783 xen-unstable real-retest [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/162771/ >>> http://logs.test-lab.xenproject.org/osstest/logs/162783/ >>> >>> Regressions :-( >>> >>> Tests which did not succeed and are blocking, >>> including tests which could not be run: >>> test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 162533 >>> test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 162533 >>> test-amd64-amd64-i386-pvgrub 17 guest-localmigrate fail REGR. vs. 162533 >>> test-amd64-amd64-amd64-pvgrub 17 guest-localmigrate fail REGR. vs. 162533 >> >> Hmm, this is rather unfortunate. >> >> Those last 2 tests failed due to commit 7bd8989ab77b6ade3b, but just >> reverting that patch doesn't seem right to me either. >> >> The Linux kernel has a bug here: it will initially set max_pfn in the >> shared_info page to the size of the p2m_list (so my reasoning for above >> patch was wrong in this case), but when growing the p2m_list (e.g. due >> to ballooning or grant mapping), it will store a real pfn number in >> max_pfn. But even this pfn might be wrong, as only the pfn leading to >> allocation of a new p2m page will be stored in max_pfn, any higher new >> pfn having its p2m entry in the new p2m page won't result in a new >> max_pfn entry. >> >> As a result I think the only sane handling would be to assume the >> max_pfn value read from the shared_info page is really a pfn. > > This would be contrary to the public interface header having > > /* > * Number of valid entries in the p2m table(s) anchored at > * pfn_to_mfn_frame_list_list and/or p2m_vaddr. > */ > unsigned long max_pfn; > > IOW the name containing "max" is misleading (should be "num" or > alike), but there's no room imo to change this. Oh, how nice! :-( I have let myself been fooled by the correctly named max_pfn field in libxenguest, together with the wrong usage in the kernel. > >> This >> value should be adjusted to specify the last pfn of the related p2m >> page, and the resulting last p2m page should be tolerated to not be >> valid. >> >> Another variant would be to just revert above commit and modify the >> semantics of max_pfn in the shared_info page to really mean max_pfn+1. > > But that's what it is already, according to the comment. Are you > suggesting there was code prior to the change you've quoted that > already violated this (in Xen or the tool stack, that is, not > the issue you suggest has been present in Linux)? Reading the comment would have helped. So a plain revert is the way to go. Juergen [-- Attachment #1.1.2: OpenPGP public key --] [-- Type: application/pgp-keys, Size: 3135 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-14 12:06 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-14 2:21 [xen-unstable test] 162771: regressions - FAIL osstest service owner 2021-06-14 6:41 ` Juergen Gross 2021-06-14 11:58 ` Jan Beulich 2021-06-14 12:06 ` Juergen Gross
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).