From: Julien Grall <julien@xen.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall.oss@gmail.com>,
Elliott Mitchell <ehem+xen@m5p.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: domain_build: Ignore device nodes with invalid addresses
Date: Sat, 6 Feb 2021 08:47:18 +0000 [thread overview]
Message-ID: <f87cd0dc-fb01-bf4e-b8f9-66fceb1884f3@xen.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2102041435300.29047@sstabellini-ThinkPad-T480s>
Hi Stefano,
On 04/02/2021 22:39, Stefano Stabellini wrote:
> After the discussion with Rob, it is clear that we have to add a check
> on the node name for "pcie" in dt_bus_pci_match. However, that wouldn't
> solve the problem reported by Elliot, because in this case the node name
> is "pci" not "pcie".
I'd like to point out that in the Linux case, the problem was in the
hostbridge and not the PCI device.
>
> I suggest that we add a check for "pci" too in dt_bus_pci_match,
> although that means that our check will be slightly different from the
> equivalent Linux check. The "pci" check should come with an in-code
> comment to explain the situation and the reasons for it to be.
I'd like to follow the same approach as a Linux commit:
commit d1ac0002dd297069bb8448c2764c9c31c4668441
Author: Marc Zyngier <maz@kernel.org>
Date: Wed Aug 19 10:42:55 2020 +0100
of: address: Work around missing device_type property in pcie nodes
This means a warning should also be added.
Cheers,
--
Julien Grall
prev parent reply other threads:[~2021-02-06 8:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 17:47 [PATCH] xen/arm: domain_build: Ignore device nodes with invalid addresses Elliott Mitchell
2021-02-02 18:12 ` Julien Grall
2021-02-02 19:21 ` Julien Grall
2021-02-03 0:18 ` Stefano Stabellini
2021-02-03 17:44 ` Julien Grall
2021-02-03 22:18 ` Stefano Stabellini
2021-02-03 22:52 ` Julien Grall
2021-02-04 0:13 ` Stefano Stabellini
2021-02-04 16:29 ` Julien Grall
2021-02-04 17:56 ` Question on PCIe Device Tree bindings, Was: " Stefano Stabellini
2021-02-04 18:31 ` Rob Herring
2021-02-04 20:36 ` Stefano Stabellini
2021-02-04 21:08 ` Rob Herring
2021-02-04 21:33 ` Stefano Stabellini
2021-02-04 21:52 ` Rob Herring
2021-02-04 22:02 ` Stefano Stabellini
2021-02-05 3:32 ` Elliott Mitchell
2021-02-05 13:56 ` Rob Herring
2021-02-04 22:39 ` Stefano Stabellini
2021-02-06 8:47 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f87cd0dc-fb01-bf4e-b8f9-66fceb1884f3@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=ehem+xen@m5p.com \
--cc=julien.grall.oss@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).