[PATCH] Fix flexcan interrupt request not working on non SMP systems

[PATCH] Fix flexcan interrupt request not working on non SMP systems

[Julien Blanc]

irq_set_affinity_hint returns -EINVAL on non-SMP systems. On such
systems, setting the irq affinity is non-sense, so just remove the
call in xnintr_attach (resp. xnintr_detach) if CONFIG_SMP is not defined

Signed-off-by: Julien Blanc <julien.blanc@sprinte.eu>
---
 kernel/cobalt/dovetail/intr.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/cobalt/dovetail/intr.c b/kernel/cobalt/dovetail/intr.c
index a9459b7a8..88116c7c8 100644
--- a/kernel/cobalt/dovetail/intr.c
+++ b/kernel/cobalt/dovetail/intr.c
@@ -100,9 +100,11 @@ int xnintr_attach(struct xnintr *intr, void *cookie, const cpumask_t *cpumask)
                if (cpumask_empty(effective_mask))
                        return -EINVAL;
        }
+#ifdef CONFIG_SMP
        ret = irq_set_affinity_hint(intr->irq, effective_mask);
        if (ret)
                return ret;
+#endif

        return request_irq(intr->irq, xnintr_irq_handler, IRQF_OOB,
                        intr->name, intr);
@@ -112,7 +114,9 @@ EXPORT_SYMBOL_GPL(xnintr_attach);
 void xnintr_detach(struct xnintr *intr)
 {
        secondary_mode_only();
+#ifdef CONFIG_SMP
        irq_set_affinity_hint(intr->irq, NULL);
+#endif
        free_irq(intr->irq, intr);
 }
 EXPORT_SYMBOL_GPL(xnintr_detach);
-- 
2.39.2

Re: [PATCH] Fix flexcan interrupt request not working on non SMP systems

[Julien Blanc]

Looks like space/tabs have been messed up, sorry for this, i'm sending it again.

Le lundi 03 avril 2023 à 07:08 +0000, Julien Blanc a écrit :
> irq_set_affinity_hint returns -EINVAL on non-SMP systems. On such
> systems, setting the irq affinity is non-sense, so just remove the
> call in xnintr_attach (resp. xnintr_detach) if CONFIG_SMP is not defined
> 
> Signed-off-by: Julien Blanc <julien.blanc@sprinte.eu>
> ---
>  kernel/cobalt/dovetail/intr.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kernel/cobalt/dovetail/intr.c b/kernel/cobalt/dovetail/intr.c
> index a9459b7a8..88116c7c8 100644
> --- a/kernel/cobalt/dovetail/intr.c
> +++ b/kernel/cobalt/dovetail/intr.c
> @@ -100,9 +100,11 @@ int xnintr_attach(struct xnintr *intr, void *cookie, const cpumask_t *cpumask)
>                 if (cpumask_empty(effective_mask))
>                         return -EINVAL;
>         }
> +#ifdef CONFIG_SMP
>         ret = irq_set_affinity_hint(intr->irq, effective_mask);
>         if (ret)
>                 return ret;
> +#endif
> 
>         return request_irq(intr->irq, xnintr_irq_handler, IRQF_OOB,
>                         intr->name, intr);
> @@ -112,7 +114,9 @@ EXPORT_SYMBOL_GPL(xnintr_attach);
>  void xnintr_detach(struct xnintr *intr)
>  {
>         secondary_mode_only();
> +#ifdef CONFIG_SMP
>         irq_set_affinity_hint(intr->irq, NULL);
> +#endif
>         free_irq(intr->irq, intr);
>  }
>  EXPORT_SYMBOL_GPL(xnintr_detach);
> -- 
> 2.39.2
>