[PATCH] copperplate: sysregd: fix Makefile.am

[PATCH] copperplate: sysregd: fix Makefile.am

[Mauro S.]

To avoid following Yocto error:

   do_package_qa: QA Issue: File /usr/sbin/sysregd in package xenomai
   doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]

Signed-off-by: Mauro Salvini <mau.salvi@yahoo.com>
---
  lib/copperplate/regd/Makefile.am | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/copperplate/regd/Makefile.am 
b/lib/copperplate/regd/Makefile.am
index 3b14e9863..590a47c2f 100644
--- a/lib/copperplate/regd/Makefile.am
+++ b/lib/copperplate/regd/Makefile.am
@@ -1,14 +1,14 @@
  sbin_PROGRAMS = sysregd
  -CPPFLAGS = 			\
+sysregd_CPPFLAGS = 			\
  	@XENO_USER_CFLAGS@	\
  	@XENO_FUSE_CFLAGS@	\
  	-I$(top_srcdir)/lib	\
  	-I$(top_srcdir)/include
  -LDFLAGS = $(XENO_POSIX_WRAPPERS)
+sysregd_LDFLAGS = $(XENO_POSIX_WRAPPERS)
  -LDADD = 			\
+sysregd_LDADD = 			\
  	../libcopperplate@CORE@.la	\
  	@XENO_CORE_LDADD@	\
  	@XENO_USER_LDADD@	\
-- 
2.17.1

Re: [PATCH] copperplate: sysregd: fix Makefile.am

[Jan Kiszka]

On 22.02.23 13:51, Mauro S. wrote:
> 
> To avoid following Yocto error:
> 
>   do_package_qa: QA Issue: File /usr/sbin/sysregd in package xenomai
>   doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
> 
> Signed-off-by: Mauro Salvini <mau.salvi@yahoo.com>
> ---
>  lib/copperplate/regd/Makefile.am | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/copperplate/regd/Makefile.am
> b/lib/copperplate/regd/Makefile.am
> index 3b14e9863..590a47c2f 100644
> --- a/lib/copperplate/regd/Makefile.am
> +++ b/lib/copperplate/regd/Makefile.am
> @@ -1,14 +1,14 @@
>  sbin_PROGRAMS = sysregd
>  -CPPFLAGS =             \
> +sysregd_CPPFLAGS =             \
>      @XENO_USER_CFLAGS@    \
>      @XENO_FUSE_CFLAGS@    \
>      -I$(top_srcdir)/lib    \
>      -I$(top_srcdir)/include
>  -LDFLAGS = $(XENO_POSIX_WRAPPERS)
> +sysregd_LDFLAGS = $(XENO_POSIX_WRAPPERS)
>  -LDADD =             \
> +sysregd_LDADD =             \
>      ../libcopperplate@CORE@.la    \
>      @XENO_CORE_LDADD@    \
>      @XENO_USER_LDADD@    \

This was heavily mangled. Please check your mail client settings or use
git send-email.

Besides that, some explanation why making the same settings
program-only, rather than global, would be good to see in the commit
message.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [PATCH] copperplate: sysregd: fix Makefile.am

[Mauro S.]

Il 22/02/23 14:29, Jan Kiszka ha scritto:
> On 22.02.23 13:51, Mauro S. wrote:
>>
>> To avoid following Yocto error:
>>
>>    do_package_qa: QA Issue: File /usr/sbin/sysregd in package xenomai
>>    doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
>>
>> Signed-off-by: Mauro Salvini <mau.salvi@yahoo.com>
>> ---
>>   lib/copperplate/regd/Makefile.am | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/copperplate/regd/Makefile.am
>> b/lib/copperplate/regd/Makefile.am
>> index 3b14e9863..590a47c2f 100644
>> --- a/lib/copperplate/regd/Makefile.am
>> +++ b/lib/copperplate/regd/Makefile.am
>> @@ -1,14 +1,14 @@
>>   sbin_PROGRAMS = sysregd
>>   -CPPFLAGS =             \
>> +sysregd_CPPFLAGS =             \
>>       @XENO_USER_CFLAGS@    \
>>       @XENO_FUSE_CFLAGS@    \
>>       -I$(top_srcdir)/lib    \
>>       -I$(top_srcdir)/include
>>   -LDFLAGS = $(XENO_POSIX_WRAPPERS)
>> +sysregd_LDFLAGS = $(XENO_POSIX_WRAPPERS)
>>   -LDADD =             \
>> +sysregd_LDADD =             \
>>       ../libcopperplate@CORE@.la    \
>>       @XENO_CORE_LDADD@    \
>>       @XENO_USER_LDADD@    \
> 
> This was heavily mangled. Please check your mail client settings or use
> git send-email.
> 
> Besides that, some explanation why making the same settings
> program-only, rather than global, would be good to see in the commit
> message.
> 

Ok sorry, I will resend it with git send-email (I need some time to 
manage it to work with yahoo/oauth2...)

> Jan
> 
-- 
Mauro S.