From: Jan Kiszka <jan.kiszka@siemens.com>
To: Mauro Salvini <mau.salvi@yahoo.com>, xenomai@lists.linux.dev
Subject: Re: [PATCH v2] copperplate: sysregd: fix Makefile.am
Date: Thu, 23 Feb 2023 18:41:29 +0100 [thread overview]
Message-ID: <e9607eaa-6ad0-be28-d06f-b3021c1cf6b3@siemens.com> (raw)
In-Reply-To: <20230222140543.19880-1-mau.salvi@yahoo.com>
On 22.02.23 15:05, Mauro Salvini wrote:
> Settings in this Makefile.am are done without the sysregd_
> prepend, differently from other tools (e.g. utils/corectl)
>
Ok, in here seems to be the underlying reason:
https://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html
Summery:
"Thus, you should never redefine a user variable such as CPPFLAGS in Makefile.am."
Now, just for CPPFLAGS in utils:
utils/analogy/Makefile.am:CPPFLAGS = \
utils/autotune/Makefile.am:autotune_CPPFLAGS = \
utils/can/Makefile.am:AM_CPPFLAGS = \
utils/chkkconf/Makefile.am:chkkconf_CPPFLAGS = \
utils/corectl/Makefile.am:corectl_CPPFLAGS = \
utils/hdb/Makefile.am:hdb_CPPFLAGS = \
utils/net/Makefile.am:CPPFLAGS = -I$(top_srcdir)/kernel/drivers/net/stack/include
utils/ps/Makefile.am:CPPFLAGS = \
utils/slackspot/Makefile.am:CPPFLAGS = \
So there is more work to be done. Patches welcome!
Jan
> This also avoids following Yocto error:
>
> do_package_qa: QA Issue: File /usr/sbin/sysregd in package xenomai
> doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
>
> Signed-off-by: Mauro Salvini <mau.salvi@yahoo.com>
> ---
> lib/copperplate/regd/Makefile.am | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/copperplate/regd/Makefile.am b/lib/copperplate/regd/Makefile.am
> index 3b14e9863..590a47c2f 100644
> --- a/lib/copperplate/regd/Makefile.am
> +++ b/lib/copperplate/regd/Makefile.am
> @@ -1,14 +1,14 @@
> sbin_PROGRAMS = sysregd
>
> -CPPFLAGS = \
> +sysregd_CPPFLAGS = \
> @XENO_USER_CFLAGS@ \
> @XENO_FUSE_CFLAGS@ \
> -I$(top_srcdir)/lib \
> -I$(top_srcdir)/include
>
> -LDFLAGS = $(XENO_POSIX_WRAPPERS)
> +sysregd_LDFLAGS = $(XENO_POSIX_WRAPPERS)
>
> -LDADD = \
> +sysregd_LDADD = \
> ../libcopperplate@CORE@.la \
> @XENO_CORE_LDADD@ \
> @XENO_USER_LDADD@ \
--
Siemens AG, Technology
Competence Center Embedded Linux
prev parent reply other threads:[~2023-02-23 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230222140543.19880-1-mau.salvi.ref@yahoo.com>
2023-02-22 14:05 ` [PATCH v2] copperplate: sysregd: fix Makefile.am Mauro Salvini
2023-02-23 17:41 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9607eaa-6ad0-be28-d06f-b3021c1cf6b3@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=mau.salvi@yahoo.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).