* Re: [PATCH v2] copperplate: sysregd: fix Makefile.am
2023-02-22 14:05 ` [PATCH v2] copperplate: sysregd: fix Makefile.am Mauro Salvini
@ 2023-02-23 17:41 ` Jan Kiszka
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2023-02-23 17:41 UTC (permalink / raw)
To: Mauro Salvini, xenomai
On 22.02.23 15:05, Mauro Salvini wrote:
> Settings in this Makefile.am are done without the sysregd_
> prepend, differently from other tools (e.g. utils/corectl)
>
Ok, in here seems to be the underlying reason:
https://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html
Summery:
"Thus, you should never redefine a user variable such as CPPFLAGS in Makefile.am."
Now, just for CPPFLAGS in utils:
utils/analogy/Makefile.am:CPPFLAGS = \
utils/autotune/Makefile.am:autotune_CPPFLAGS = \
utils/can/Makefile.am:AM_CPPFLAGS = \
utils/chkkconf/Makefile.am:chkkconf_CPPFLAGS = \
utils/corectl/Makefile.am:corectl_CPPFLAGS = \
utils/hdb/Makefile.am:hdb_CPPFLAGS = \
utils/net/Makefile.am:CPPFLAGS = -I$(top_srcdir)/kernel/drivers/net/stack/include
utils/ps/Makefile.am:CPPFLAGS = \
utils/slackspot/Makefile.am:CPPFLAGS = \
So there is more work to be done. Patches welcome!
Jan
> This also avoids following Yocto error:
>
> do_package_qa: QA Issue: File /usr/sbin/sysregd in package xenomai
> doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
>
> Signed-off-by: Mauro Salvini <mau.salvi@yahoo.com>
> ---
> lib/copperplate/regd/Makefile.am | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/copperplate/regd/Makefile.am b/lib/copperplate/regd/Makefile.am
> index 3b14e9863..590a47c2f 100644
> --- a/lib/copperplate/regd/Makefile.am
> +++ b/lib/copperplate/regd/Makefile.am
> @@ -1,14 +1,14 @@
> sbin_PROGRAMS = sysregd
>
> -CPPFLAGS = \
> +sysregd_CPPFLAGS = \
> @XENO_USER_CFLAGS@ \
> @XENO_FUSE_CFLAGS@ \
> -I$(top_srcdir)/lib \
> -I$(top_srcdir)/include
>
> -LDFLAGS = $(XENO_POSIX_WRAPPERS)
> +sysregd_LDFLAGS = $(XENO_POSIX_WRAPPERS)
>
> -LDADD = \
> +sysregd_LDADD = \
> ../libcopperplate@CORE@.la \
> @XENO_CORE_LDADD@ \
> @XENO_USER_LDADD@ \
--
Siemens AG, Technology
Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 2+ messages in thread