From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 7/8] Makefile: don't delete dist tarballs directly by name
Date: Thu, 05 Nov 2020 17:58:49 -0800 [thread overview]
Message-ID: <xmqqa6vvgs9y.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <0cbe821b-092d-a5f9-e2ab-13a3c01e9a02@ramsayjones.plus.com> (Ramsay Jones's message of "Fri, 6 Nov 2020 01:44:18 +0000")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> I did have a patch #9 that moved the removal of the tarballs from
> the 'clean' target to the 'distclean' target (that is move the new
> 'iterate over the dist-tars file' code). However, I wasn't convinced
> that it was a better place for it.
I am not either, other than "things created by 'make distX' cleaned
by 'make distclean'---that sounds consistent" ;-).
> Also, just moving the new removal code would not alter the concerns
> about it that you express above. So, we need to address that either
> way.
"make distclean" can still depend on GIT-VERSION-FILE and your daily
cleaning needs can use "make clean" that cleans only the files that
can be cleaned without knowing what GIT_VERSION is, no? That way,
we do not have to use dist-tars file at all, no?
next prev parent reply other threads:[~2020-11-06 1:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 21:09 [PATCH 7/8] Makefile: don't delete dist tarballs directly by name Ramsay Jones
2020-11-05 22:01 ` Junio C Hamano
2020-11-05 23:05 ` Junio C Hamano
2020-11-06 1:44 ` Ramsay Jones
2020-11-06 1:58 ` Junio C Hamano [this message]
2020-11-06 2:39 ` Ramsay Jones
2020-11-06 17:53 ` Junio C Hamano
2020-11-06 20:23 ` Ramsay Jones
2020-11-06 1:36 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa6vvgs9y.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.