From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 7/8] Makefile: don't delete dist tarballs directly by name
Date: Thu, 05 Nov 2020 15:05:40 -0800 [thread overview]
Message-ID: <xmqqeel7h0aj.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <xmqqr1p7h38t.fsf@gitster.c.googlers.com> (Junio C. Hamano's message of "Thu, 05 Nov 2020 14:01:54 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> diff --git a/.gitignore b/.gitignore
>> index 6232d33924..425b8cc2a4 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -191,6 +191,7 @@
>> /gitweb/static/gitweb.min.*
>> /config-list.h
>> /command-list.h
>> +/dist-tars
>> *.tar.gz
>> *.dsc
>> *.deb
>> diff --git a/Makefile b/Makefile
>> index 90e91a2185..bc9ce28bc3 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -3083,6 +3083,7 @@ dist: git-archive$(X) configure
>> --prefix=$(GIT_TARNAME)/ HEAD^{tree} > $(GIT_TARNAME).tar
>> @$(RM) -r .dist-tmp-dir
>> gzip -f -9 $(GIT_TARNAME).tar
>> + @echo $(GIT_TARNAME).tar.gz >>dist-tars
>
> Sorry, but I'd rather not to see such a longer-term "list of files
> to be removed" on the filesystem. This invites attackers to write a
> rogue test addition that writes into ../../dist-tars something like
> "~/.gitconfig" and wait for me to say "make clean".
Having said that, I also think that "make clean" target should help
your desire to keep tarballs that would not have been generated by
the current checkout (e.g. the last release), and I do not think
$(RM) git-htmldocs-*.tar.gz git-manpages-*.tar.gz
is an unconditionally better alternative to what you did in this
step.
How about moving removal of these "distribution" artifacts that are
created by "make dist$something" targets from "clean" to "distclean"?
next prev parent reply other threads:[~2020-11-05 23:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 21:09 [PATCH 7/8] Makefile: don't delete dist tarballs directly by name Ramsay Jones
2020-11-05 22:01 ` Junio C Hamano
2020-11-05 23:05 ` Junio C Hamano [this message]
2020-11-06 1:44 ` Ramsay Jones
2020-11-06 1:58 ` Junio C Hamano
2020-11-06 2:39 ` Ramsay Jones
2020-11-06 17:53 ` Junio C Hamano
2020-11-06 20:23 ` Ramsay Jones
2020-11-06 1:36 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeel7h0aj.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.