Re: [docs] [PATCH] dev-manual: add line continuations for aesthetics

["Quentin Schulz" <quentin.schulz@theobroma-systems.com>]

Hi Robert,

On Mon, Aug 30, 2021 at 05:00:39AM -0400, Robert P. J. Day wrote:
> 
> Not a fan of lengthy lines that require horizontal scrolling,
> so add line continuations.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 

It is the content of the recipe afterall, so not sure it's desired? Will
let Michael/Nicolas decide.

In any case, this code is out of sync, e.g. WITHOUT_XATTR is now
embedded in a bb.utils.contains check. Since you're sending patch for
this already, do you mind sending a patch for this too please?

Cheers,
Quentin

> ---
> 
> diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
> index 4a5011ea7..6f0ee27c7 100644
> --- a/documentation/dev-manual/common-tasks.rst
> +++ b/documentation/dev-manual/common-tasks.rst
> @@ -2331,17 +2331,39 @@ In the following example, ``mtd-utils`` is a makefile-based package::
> 
>     S = "${WORKDIR}/git"
> 
> -   EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
> +   EXTRA_OEMAKE = " \
> +       'CC=${CC}' \
> +       'RANLIB=${RANLIB}' \
> +       'AR=${AR}' \
> +       'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' \
> +       'BUILDDIR=${S}' \
> +       "
> 
>     do_install () {
> -       oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
> +       oe_runmake install \
> +           DESTDIR=${D} \
> +           SBINDIR=${sbindir} \
> +           MANDIR=${mandir} \
> +           INCLUDEDIR=${includedir}
>     }
> 
>     PACKAGES =+ "mtd-utils-jffs2 mtd-utils-ubifs mtd-utils-misc"
> 
> -   FILES:mtd-utils-jffs2 = "${sbindir}/mkfs.jffs2 ${sbindir}/jffs2dump ${sbindir}/jffs2reader ${sbindir}/sumtool"
> +   FILES:mtd-utils-jffs2 = " \
> +       ${sbindir}/mkfs.jffs2 \
> +       ${sbindir}/jffs2dump \
> +       ${sbindir}/jffs2reader \
> +       ${sbindir}/sumtool \
> +       "
>     FILES:mtd-utils-ubifs = "${sbindir}/mkfs.ubifs ${sbindir}/ubi*"
> -   FILES:mtd-utils-misc = "${sbindir}/nftl* ${sbindir}/ftl* ${sbindir}/rfd* ${sbindir}/doc* ${sbindir}/serve_image ${sbindir}/recv_image"
> +   FILES:mtd-utils-misc = " \
> +       ${sbindir}/nftl* \
> +       ${sbindir}/ftl* \
> +       ${sbindir}/rfd* \
> +       ${sbindir}/doc* \
> +       ${sbindir}/serve_image \
> +       ${sbindir}/recv_image \
> +       "
> 
>     PARALLEL_MAKE = ""
> 
> 
> -- 
> 
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                          https://urldefense.proofpoint.com/v2/url?u=http-3A__crashcourse.ca&d=DwIBAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=sH8iuVXeDgFiq6-2yFuaJA1ahW9robcDxSFcJtunA6g&s=ez81p3lImZGQIgOs21G8Sys-IEhCl0eRKgi70lFiDSU&e= 
> 
> LinkedIn:                               https://urldefense.proofpoint.com/v2/url?u=http-3A__ca.linkedin.com_in_rpjday&d=DwIBAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=sH8iuVXeDgFiq6-2yFuaJA1ahW9robcDxSFcJtunA6g&s=0YgkyEX30AN49Fm5SfWLgeNzQw7rQ_AnyZoUjBGyhtw&e= 
> ========================================================================

> 
> 
>