Re: [docs] [PATCH] dev-manual: add line continuations for aesthetics

["Michael Opdenacker" <michael.opdenacker@bootlin.com>]

Hello,

On 8/30/21 11:26 AM, Robert P. J. Day wrote:
> On Mon, 30 Aug 2021, Quentin Schulz wrote:
>
>> Hi Robert,
>>
>> On Mon, Aug 30, 2021 at 05:00:39AM -0400, Robert P. J. Day wrote:
>>> Not a fan of lengthy lines that require horizontal scrolling,
>>> so add line continuations.
>>>
>>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>>
>> It is the content of the recipe afterall, so not sure it's desired?
>> Will let Michael/Nicolas decide.


Right, not sure there's much added value in tweaking real code. I also
checked the epub and pdf output and the lines are automatically wrapped.

>>
>> In any case, this code is out of sync, e.g. WITHOUT_XATTR is now
>> embedded in a bb.utils.contains check. Since you're sending patch
>> for this already, do you mind sending a patch for this too please?
>   in cases like this, it's pretty much a given that any recipe will be
> out of date in a while, but i don't think that's a big deal -- the
> idea is just to present a *concept*, not to guarantee that the recipe
> matches exactly the current version. i am willing to be corrected,
> though.


What could be embarrassing is when the code no longer works, so this
would be a reason for keep example code reasonably up to date. However,
I agree we shouldn't try to always keep the code excerpts in sync with
the actual code. Unless we find a way to fetch the source code directly
from the git repositories ?

Cheers,

Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com