meta-arago.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
* [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
@ 2022-05-12 15:28 Aparna M
  2022-05-12 15:35 ` Ryan Eatmon
  0 siblings, 1 reply; 5+ messages in thread
From: Aparna M @ 2022-05-12 15:28 UTC (permalink / raw)
  To: meta-arago, praneeth, denis, reatmon, nm; +Cc: devarsht, s-adivi

Add ti-sci-firmware binaries required for uboot build to the
prebuilt-images directory of SDK.

Signed-off-by: Aparna M <a-m1@ti.com>
---
 meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++
 1 file changed, 3 insertions(+)

This patch is dependent on
https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279

diff --git a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
index 9ebcbb0e..d5a11f36 100644
--- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
+++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
@@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb"
 DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb"
 DEPLOY_IMAGES_NAME_append_am65xx-evm = " ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb sysfw-am65x_sr2-evm.itb"
 DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin"
+DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin"
+DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin fitImage-its.its"
+DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin ipc_echo_testb_mcu1_0_release_strip.xer5f"
 
 ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle"
 export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}"
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
  2022-05-12 15:28 [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK Aparna M
@ 2022-05-12 15:35 ` Ryan Eatmon
  2022-05-12 18:23   ` Nishanth Menon
  2022-05-13  7:57   ` M, Aparna
  0 siblings, 2 replies; 5+ messages in thread
From: Ryan Eatmon @ 2022-05-12 15:35 UTC (permalink / raw)
  To: Aparna M, meta-arago, praneeth, denis, nm; +Cc: devarsht, s-adivi



On 5/12/2022 10:28, Aparna M wrote:
> Add ti-sci-firmware binaries required for uboot build to the
> prebuilt-images directory of SDK.
> 
> Signed-off-by: Aparna M <a-m1@ti.com>
> ---
>   meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++
>   1 file changed, 3 insertions(+)
> 
> This patch is dependent on
> https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279
> 
> diff --git a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> index 9ebcbb0e..d5a11f36 100644
> --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb"
>   DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb"
>   DEPLOY_IMAGES_NAME_append_am65xx-evm = " ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb sysfw-am65x_sr2-evm.itb"
>   DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin"
> +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin"
> +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin fitImage-its.its"
> +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin ipc_echo_testb_mcu1_0_release_strip.xer5f"
>   
>   ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle"
>   export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}"


Same as the other patch on meta-ti.  I think the 
ipc_echo_testb_mcu1_0_release_strip.xer5f file needs to not be in this 
file.  The other changes are fine, but remove that one.


-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
  2022-05-12 15:35 ` Ryan Eatmon
@ 2022-05-12 18:23   ` Nishanth Menon
  2022-05-13  7:57   ` M, Aparna
  1 sibling, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2022-05-12 18:23 UTC (permalink / raw)
  To: Ryan Eatmon; +Cc: Aparna M, meta-arago, praneeth, denis, devarsht, s-adivi

On 10:35-20220512, Ryan Eatmon wrote:
> 
> 
> On 5/12/2022 10:28, Aparna M wrote:
> > Add ti-sci-firmware binaries required for uboot build to the
> > prebuilt-images directory of SDK.
> > 
> > Signed-off-by: Aparna M <a-m1@ti.com>
> > ---
> >   meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > This patch is dependent on
> > https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279
> > 
> > diff --git a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> > index 9ebcbb0e..d5a11f36 100644
> > --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> > +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> > @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb"
> >   DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb"
> >   DEPLOY_IMAGES_NAME_append_am65xx-evm = " ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb sysfw-am65x_sr2-evm.itb"
> >   DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin"
> > +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin"
> > +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin fitImage-its.its"
> > +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin ipc_echo_testb_mcu1_0_release_strip.xer5f"
> >   ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle"
> >   export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}"
> 
> 
> Same as the other patch on meta-ti.  I think the
> ipc_echo_testb_mcu1_0_release_strip.xer5f file needs to not be in this file.
> The other changes are fine, but remove that one.


I do NOT understand what purpose this serves! these are embedded in
the boot images already. $commit message claims if you dont copy these
files, system wont build? that is not true! Agreed these files are
tiny, but they confuse the user as to what are the real images used
to boot. Just switching this binary has 0 function on the deployed
images!

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
  2022-05-12 15:35 ` Ryan Eatmon
  2022-05-12 18:23   ` Nishanth Menon
@ 2022-05-13  7:57   ` M, Aparna
  2022-05-17 17:48     ` Nishanth Menon
  1 sibling, 1 reply; 5+ messages in thread
From: M, Aparna @ 2022-05-13  7:57 UTC (permalink / raw)
  To: Eatmon, Ryan, M, Aparna, meta-arago, Bajjuri, Praneeth, denis,
	Menon, Nishanth
  Cc: Thakkar, Devarsh, Adivi, Sai Sree Kartheek


On 12/05/22 21:05, Ryan Eatmon wrote:
>
>
> On 5/12/2022 10:28, Aparna M wrote:
>> Add ti-sci-firmware binaries required for uboot build to the
>> prebuilt-images directory of SDK.
>>
>> Signed-off-by: Aparna M <a-m1@ti.com>
>> ---
>>   meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> This patch is dependent on
>> https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279 
>>

As per suggestions on previous patch, this is the new patch dependency:
https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch/91076133

>>
>> diff --git 
>> a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb 
>> b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
>> index 9ebcbb0e..d5a11f36 100644
>> --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
>> +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
>> @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb"
>>   DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb"
>>   DEPLOY_IMAGES_NAME_append_am65xx-evm = " 
>> ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb 
>> sysfw-am65x_sr2-evm.itb"
>>   DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin"
>> +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin"
>> +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " 
>> ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin 
>> fitImage-its.its"
>> +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin 
>> ipc_echo_testb_mcu1_0_release_strip.xer5f"
>>     ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle"
>>   export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}"
>
>
> Same as the other patch on meta-ti.  I think the 
> ipc_echo_testb_mcu1_0_release_strip.xer5f file needs to not be in this 
> file.  The other changes are fine, but remove that one.

The ipc_echo_testb_mcu1_0_release_strip.xer5f file is required in the 
SDK for toplevel makefile uboot build for am62xx-evm. So it needs to be 
packaged in the prebuilt-images folder of the SDK.

-- 
Aparna


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
  2022-05-13  7:57   ` M, Aparna
@ 2022-05-17 17:48     ` Nishanth Menon
  0 siblings, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2022-05-17 17:48 UTC (permalink / raw)
  To: M, Aparna
  Cc: Eatmon, Ryan, meta-arago, Bajjuri, Praneeth, denis, Thakkar,
	Devarsh, Adivi, Sai Sree Kartheek

On 02:57-20220513, M, Aparna wrote:
> 
> On 12/05/22 21:05, Ryan Eatmon wrote:
> >
> >
> > On 5/12/2022 10:28, Aparna M wrote:
> >> Add ti-sci-firmware binaries required for uboot build to the
> >> prebuilt-images directory of SDK.
> >>
> >> Signed-off-by: Aparna M <a-m1@ti.com>
> >> ---
> >>   meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> This patch is dependent on
> >> https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279 
> >>
> 
> As per suggestions on previous patch, this is the new patch dependency:
> https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch/91076133
> 
> >>
> >> diff --git 
> >> a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb 
> >> b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> >> index 9ebcbb0e..d5a11f36 100644
> >> --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> >> +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb
> >> @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb"
> >>   DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb"
> >>   DEPLOY_IMAGES_NAME_append_am65xx-evm = " 
> >> ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb 
> >> sysfw-am65x_sr2-evm.itb"
> >>   DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin"
> >> +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin"
> >> +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " 
> >> ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin 
> >> fitImage-its.its"
> >> +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin 
> >> ipc_echo_testb_mcu1_0_release_strip.xer5f"
> >>     ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle"
> >>   export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}"
> >
> >
> > Same as the other patch on meta-ti.  I think the 
> > ipc_echo_testb_mcu1_0_release_strip.xer5f file needs to not be in this 
> > file.  The other changes are fine, but remove that one.
> 
> The ipc_echo_testb_mcu1_0_release_strip.xer5f file is required in the 
> SDK for toplevel makefile uboot build for am62xx-evm. So it needs to be 
> packaged in the prebuilt-images folder of the SDK.


I dont understand why are we forcing this dependency? u-boot is built
from source, the firmwares are in linux-firmware repositories. why
are'nt the top level makefiles using the linux-firmware repo to pick
up the correct binaries?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-17 17:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 15:28 [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK Aparna M
2022-05-12 15:35 ` Ryan Eatmon
2022-05-12 18:23   ` Nishanth Menon
2022-05-13  7:57   ` M, Aparna
2022-05-17 17:48     ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).