meta-arm.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][langdale] arm/classes: Ensure patch files are sorted in apply_local_src_patches
@ 2023-01-10 13:38 Peter Hoyes
  2023-01-10 18:27 ` Jon Mason
  2023-01-13 18:05 ` Jon Mason
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Hoyes @ 2023-01-10 13:38 UTC (permalink / raw)
  To: meta-arm; +Cc: Diego.Sueiro, Peter Hoyes

From: Peter Hoyes <Peter.Hoyes@arm.com>

apply_local_src_patches.bbclass was added in a previous patch to handle
the application of patch files located inside the fetched source code.

find is used to collect the patch files which does not guarantee the
order of its output. Pipe the output of find into sort to ensure patch
files are applied in the correct order.

Issue-Id: SCM-5864
Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
Change-Id: I1082fb7a726a7745289a5aa8bb6447bef57a94b0
---
 meta-arm/classes/apply_local_src_patches.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-arm/classes/apply_local_src_patches.bbclass b/meta-arm/classes/apply_local_src_patches.bbclass
index daa85f4c..e1939353 100644
--- a/meta-arm/classes/apply_local_src_patches.bbclass
+++ b/meta-arm/classes/apply_local_src_patches.bbclass
@@ -32,7 +32,7 @@ apply_local_src_patches() {
     export QUILT_PATCHES=./patches-extra
     mkdir -p patches-extra
 
-    for patch in $(find $input_dir -type f -name *.patch -or -name *.diff)
+    for patch in $(find $input_dir -type f -name *.patch -or -name *.diff | sort)
     do
         patch_basename=`basename $patch`
         if ! quilt applied $patch_basename >/dev/null ; then
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH][langdale] arm/classes: Ensure patch files are sorted in apply_local_src_patches
  2023-01-10 13:38 [PATCH][langdale] arm/classes: Ensure patch files are sorted in apply_local_src_patches Peter Hoyes
@ 2023-01-10 18:27 ` Jon Mason
  2023-01-13 18:05 ` Jon Mason
  1 sibling, 0 replies; 3+ messages in thread
From: Jon Mason @ 2023-01-10 18:27 UTC (permalink / raw)
  To: meta-arm, Peter Hoyes; +Cc: Diego.Sueiro, Peter Hoyes

On Tue, 10 Jan 2023 13:38:59 +0000, Peter Hoyes wrote:
> apply_local_src_patches.bbclass was added in a previous patch to handle
> the application of patch files located inside the fetched source code.
> 
> find is used to collect the patch files which does not guarantee the
> order of its output. Pipe the output of find into sort to ensure patch
> files are applied in the correct order.

Applied, thanks!

[1/1] arm/classes: Ensure patch files are sorted in apply_local_src_patches
      commit: 8b95c97a00c9b6dea4221726c0ef58c6c4a3175f

Best regards,
-- 
Jon Mason <jon.mason@arm.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][langdale] arm/classes: Ensure patch files are sorted in apply_local_src_patches
  2023-01-10 13:38 [PATCH][langdale] arm/classes: Ensure patch files are sorted in apply_local_src_patches Peter Hoyes
  2023-01-10 18:27 ` Jon Mason
@ 2023-01-13 18:05 ` Jon Mason
  1 sibling, 0 replies; 3+ messages in thread
From: Jon Mason @ 2023-01-13 18:05 UTC (permalink / raw)
  To: meta-arm, Peter Hoyes; +Cc: Peter Hoyes, Diego.Sueiro

On Tue, 10 Jan 2023 13:38:59 +0000, Peter Hoyes wrote:
> apply_local_src_patches.bbclass was added in a previous patch to handle
> the application of patch files located inside the fetched source code.
> 
> find is used to collect the patch files which does not guarantee the
> order of its output. Pipe the output of find into sort to ensure patch
> files are applied in the correct order.

Applied, thanks!

[1/1] arm/classes: Ensure patch files are sorted in apply_local_src_patches
      commit: 8b95c97a00c9b6dea4221726c0ef58c6c4a3175f

Best regards,
-- 
Jon Mason <jon.mason@arm.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-13 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 13:38 [PATCH][langdale] arm/classes: Ensure patch files are sorted in apply_local_src_patches Peter Hoyes
2023-01-10 18:27 ` Jon Mason
2023-01-13 18:05 ` Jon Mason

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).