* [meta-virtualization][PATCH 1/3] image-oci-umoci: properly handle tags other than latest @ 2022-07-12 12:26 Vasileios Anagnostopoulos 2022-07-12 12:26 ` [meta-virtualization][PATCH 2/3] image-oci-umoci: add parameter for stop signal Vasileios Anagnostopoulos 2022-07-12 12:26 ` [meta-virtualization][PATCH 3/3] image-oci-umoci: skip parent directory in tar Vasileios Anagnostopoulos 0 siblings, 2 replies; 9+ messages in thread From: Vasileios Anagnostopoulos @ 2022-07-12 12:26 UTC (permalink / raw) To: meta-virtualization; +Cc: Pascal Bach From: Pascal Bach <pascal.bach@siemens.com> Signed-off-by: Pascal Bach <pascal.bach@siemens.com> --- classes/image-oci-umoci.inc | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/classes/image-oci-umoci.inc b/classes/image-oci-umoci.inc index 4fe96ea..b159614 100644 --- a/classes/image-oci-umoci.inc +++ b/classes/image-oci-umoci.inc @@ -58,48 +58,48 @@ IMAGE_CMD:oci() { bbdebug 1 "OCI: configuring image" if [ -n "${OCI_IMAGE_LABELS}" ]; then for l in ${OCI_IMAGE_LABELS}; do - bbdebug 1 "OCI: umoci config --image $image_name --config.label $l" - umoci config --image $image_name --config.label $l + bbdebug 1 "OCI: umoci config --image $image_name:${OCI_IMAGE_TAG} --config.label $l" + umoci config --image $image_name:${OCI_IMAGE_TAG} --config.label $l done fi if [ -n "${OCI_IMAGE_ENV_VARS}" ]; then for l in ${OCI_IMAGE_ENV_VARS}; do - bbdebug 1 "umoci config --image $image_name --config.env $l" - umoci config --image $image_name --config.env $l + bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --config.env $l" + umoci config --image $image_name:${OCI_IMAGE_TAG} --config.env $l done fi if [ -n "${OCI_IMAGE_PORTS}" ]; then for l in ${OCI_IMAGE_PORTS}; do - bbdebug 1 "umoci config --image $image_name --config.exposedports $l" - umoci config --image $image_name --config.exposedports $l + bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --config.exposedports $l" + umoci config --image $image_name:${OCI_IMAGE_TAG} --config.exposedports $l done fi if [ -n "${OCI_IMAGE_RUNTIME_UID}" ]; then - bbdebug 1 "umoci config --image $image_name --config.user ${OCI_IMAGE_RUNTIME_UID}" - umoci config --image $image_name --config.user ${OCI_IMAGE_RUNTIME_UID} + bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --config.user ${OCI_IMAGE_RUNTIME_UID}" + umoci config --image $image_name:${OCI_IMAGE_TAG} --config.user ${OCI_IMAGE_RUNTIME_UID} fi if [ -n "${OCI_IMAGE_WORKINGDIR}" ]; then - bbdebug 1 "umoci config --image $image_name --config.workingdir ${OCI_IMAGE_WORKINGDIR}" - umoci config --image $image_name --config.workingdir ${OCI_IMAGE_WORKINGDIR} + bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --config.workingdir ${OCI_IMAGE_WORKINGDIR}" + umoci config --image $image_name:${OCI_IMAGE_TAG} --config.workingdir ${OCI_IMAGE_WORKINGDIR} fi if [ -n "${OCI_IMAGE_OS}" ]; then - bbdebug 1 "umoci config --image $image_name --os ${OCI_IMAGE_OS}" - umoci config --image $image_name --os ${OCI_IMAGE_OS} + bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --os ${OCI_IMAGE_OS}" + umoci config --image $image_name:${OCI_IMAGE_TAG} --os ${OCI_IMAGE_OS} fi - bbdebug 1 "umoci config --image $image_name --architecture ${OCI_IMAGE_ARCH}" - umoci config --image $image_name --architecture ${OCI_IMAGE_ARCH} + bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --architecture ${OCI_IMAGE_ARCH}" + umoci config --image $image_name:${OCI_IMAGE_TAG} --architecture ${OCI_IMAGE_ARCH} # NOTE: umoci doesn't currently expose setting the architecture variant, # so if you need it use sloci instead if [ -n "${OCI_IMAGE_SUBARCH}" ]; then bbnote "OCI: image subarch is set to: ${OCI_IMAGE_SUBARCH}, but umoci does not" bbnote " expose variants. use sloci instead if this is important" fi - umoci config --image $image_name --config.entrypoint ${OCI_IMAGE_ENTRYPOINT} + umoci config --image $image_name:${OCI_IMAGE_TAG} --config.entrypoint ${OCI_IMAGE_ENTRYPOINT} if [ -n "${OCI_IMAGE_ENTRYPOINT_ARGS}" ]; then - umoci config --image $image_name --config.cmd "${OCI_IMAGE_ENTRYPOINT_ARGS}" + umoci config --image $image_name:${OCI_IMAGE_TAG} --config.cmd "${OCI_IMAGE_ENTRYPOINT_ARGS}" fi - umoci config --image $image_name --author ${OCI_IMAGE_AUTHOR_EMAIL} + umoci config --image $image_name:${OCI_IMAGE_TAG} --author ${OCI_IMAGE_AUTHOR_EMAIL} # make a tar version of the image direcotry if [ -n "${OCI_IMAGE_TAR_OUTPUT}" ]; then -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [meta-virtualization][PATCH 2/3] image-oci-umoci: add parameter for stop signal 2022-07-12 12:26 [meta-virtualization][PATCH 1/3] image-oci-umoci: properly handle tags other than latest Vasileios Anagnostopoulos @ 2022-07-12 12:26 ` Vasileios Anagnostopoulos 2022-07-12 12:26 ` [meta-virtualization][PATCH 3/3] image-oci-umoci: skip parent directory in tar Vasileios Anagnostopoulos 1 sibling, 0 replies; 9+ messages in thread From: Vasileios Anagnostopoulos @ 2022-07-12 12:26 UTC (permalink / raw) To: meta-virtualization; +Cc: Vasileios Anagnostopoulos Add an optional parameter that allows to override the stop signal that is used. Signed-off-by: Vasileios Anagnostopoulos <vasileios.anagnostopoulos@siemens.com> --- classes/image-oci-umoci.inc | 4 ++++ classes/image-oci.bbclass | 1 + 2 files changed, 5 insertions(+) diff --git a/classes/image-oci-umoci.inc b/classes/image-oci-umoci.inc index b159614..f941795 100644 --- a/classes/image-oci-umoci.inc +++ b/classes/image-oci-umoci.inc @@ -82,6 +82,10 @@ IMAGE_CMD:oci() { bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --config.workingdir ${OCI_IMAGE_WORKINGDIR}" umoci config --image $image_name:${OCI_IMAGE_TAG} --config.workingdir ${OCI_IMAGE_WORKINGDIR} fi + if [ -n "${OCI_IMAGE_STOPSIGNAL}" ]; then + bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --config.stopsignal ${OCI_IMAGE_STOPSIGNAL}" + umoci config --image $image_name:${OCI_IMAGE_TAG} --config.stopsignal ${OCI_IMAGE_STOPSIGNAL} + fi if [ -n "${OCI_IMAGE_OS}" ]; then bbdebug 1 "umoci config --image $image_name:${OCI_IMAGE_TAG} --os ${OCI_IMAGE_OS}" umoci config --image $image_name:${OCI_IMAGE_TAG} --os ${OCI_IMAGE_OS} diff --git a/classes/image-oci.bbclass b/classes/image-oci.bbclass index 7a39d27..9ddb88b 100644 --- a/classes/image-oci.bbclass +++ b/classes/image-oci.bbclass @@ -58,6 +58,7 @@ OCI_IMAGE_SUBARCH ?= "${@oci_map_subarch(d.getVar('TARGET_ARCH'), d.getVar('TUNE OCI_IMAGE_ENTRYPOINT ?= "sh" OCI_IMAGE_ENTRYPOINT_ARGS ?= "" OCI_IMAGE_WORKINGDIR ?= "" +OCI_IMAGE_STOPSIGNAL ?= "" # List of ports to expose from a container running this image: # PORT[/PROT] -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [meta-virtualization][PATCH 3/3] image-oci-umoci: skip parent directory in tar 2022-07-12 12:26 [meta-virtualization][PATCH 1/3] image-oci-umoci: properly handle tags other than latest Vasileios Anagnostopoulos 2022-07-12 12:26 ` [meta-virtualization][PATCH 2/3] image-oci-umoci: add parameter for stop signal Vasileios Anagnostopoulos @ 2022-07-12 12:26 ` Vasileios Anagnostopoulos 2022-07-12 21:16 ` Bruce Ashfield 1 sibling, 1 reply; 9+ messages in thread From: Vasileios Anagnostopoulos @ 2022-07-12 12:26 UTC (permalink / raw) To: meta-virtualization; +Cc: Vasileios Anagnostopoulos Skip the inclusion of the parent directory in the tar file. Most tools expect a tar file without it. An example of this use case is skopeo, where the skopeo copy oci-archive command will not work with the generate tar file. Signed-off-by: Vasileios Anagnostopoulos <vasileios.anagnostopoulos@siemens.com> --- classes/image-oci-umoci.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/classes/image-oci-umoci.inc b/classes/image-oci-umoci.inc index f941795..771f288 100644 --- a/classes/image-oci-umoci.inc +++ b/classes/image-oci-umoci.inc @@ -107,7 +107,7 @@ IMAGE_CMD:oci() { # make a tar version of the image direcotry if [ -n "${OCI_IMAGE_TAR_OUTPUT}" ]; then - tar -cf "$image_name.tar" "$image_name" + tar -cf "$image_name.tar" -C "$image_name" . fi # We could make this optional, since the bundle is directly runnable via runc -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [meta-virtualization][PATCH 3/3] image-oci-umoci: skip parent directory in tar 2022-07-12 12:26 ` [meta-virtualization][PATCH 3/3] image-oci-umoci: skip parent directory in tar Vasileios Anagnostopoulos @ 2022-07-12 21:16 ` Bruce Ashfield 2022-07-13 7:19 ` [PATCH " Vasileios Anagnostopoulos 0 siblings, 1 reply; 9+ messages in thread From: Bruce Ashfield @ 2022-07-12 21:16 UTC (permalink / raw) To: Vasileios Anagnostopoulos; +Cc: meta-virtualization On Tue, Jul 12, 2022 at 8:27 AM Vasileios Anagnostopoulos <vasileios.anagnostopoulos@siemens.com> wrote: > > Skip the inclusion of the parent directory in the tar file. > Most tools expect a tar file without it. An example of this > use case is skopeo, where the skopeo copy oci-archive command > will not work with the generate tar file. The tar file was never actually intended to be used in that way, hence why the directory is maintained. It is just there for easier transport of the oci image directory, and the existing workflow is that multiple of these are copied and untar'd .. with this, they'll clobber each other and break. We could potentially create a new mode to support this .. I need to think on it a bit more first. Bruce > > Signed-off-by: Vasileios Anagnostopoulos <vasileios.anagnostopoulos@siemens.com> > --- > classes/image-oci-umoci.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/classes/image-oci-umoci.inc b/classes/image-oci-umoci.inc > index f941795..771f288 100644 > --- a/classes/image-oci-umoci.inc > +++ b/classes/image-oci-umoci.inc > @@ -107,7 +107,7 @@ IMAGE_CMD:oci() { > > # make a tar version of the image direcotry > if [ -n "${OCI_IMAGE_TAR_OUTPUT}" ]; then > - tar -cf "$image_name.tar" "$image_name" > + tar -cf "$image_name.tar" -C "$image_name" . > fi > > # We could make this optional, since the bundle is directly runnable via runc > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#7443): https://lists.yoctoproject.org/g/meta-virtualization/message/7443 > Mute This Topic: https://lists.yoctoproject.org/mt/92331697/1050810 > Group Owner: meta-virtualization+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] image-oci-umoci: skip parent directory in tar 2022-07-12 21:16 ` Bruce Ashfield @ 2022-07-13 7:19 ` Vasileios Anagnostopoulos 2022-07-13 20:36 ` [meta-virtualization] " Bruce Ashfield 0 siblings, 1 reply; 9+ messages in thread From: Vasileios Anagnostopoulos @ 2022-07-13 7:19 UTC (permalink / raw) To: meta-virtualization [-- Attachment #1: Type: text/plain, Size: 852 bytes --] Hello Bruce, How do you generate the images and import them? Could you describe a bit more the use case? With podman for example you can load the image by using `podman load -i build-oci/tmp/deploy/images/capricorn-64/name-of-the-image-capricorn-64-20220713063601.rootfs.tar` Usually, the tools that support the oci image format also support the oci-archive image format. An exception is docker that does not support the oci image format and I have first to transform it using skopeo. What is the advantage of first un-taring the image and then doing the import? Probably the other 2 patches that I send it with this one ( https://lists.yoctoproject.org/g/meta-virtualization/message/7442 , https://lists.yoctoproject.org/g/meta-virtualization/message/7441 ) are still relevant, because they are fixing other minor issues. Vasileios [-- Attachment #2: Type: text/html, Size: 38162 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar 2022-07-13 7:19 ` [PATCH " Vasileios Anagnostopoulos @ 2022-07-13 20:36 ` Bruce Ashfield 2022-07-14 6:49 ` Anagnostopoulos, Vasileios [not found] ` <17019F65456D67C8.559@lists.yoctoproject.org> 0 siblings, 2 replies; 9+ messages in thread From: Bruce Ashfield @ 2022-07-13 20:36 UTC (permalink / raw) To: Vasileios Anagnostopoulos; +Cc: meta-virtualization On Wed, Jul 13, 2022 at 3:19 AM Vasileios Anagnostopoulos <vasileios.anagnostopoulos@siemens.com> wrote: > > Hello Bruce, > > How do you generate the images and import them? Could you describe a bit more the use case? > > With podman for example you can load the image by using `podman load -i build-oci/tmp/deploy/images/capricorn-64/name-of-the-image-capricorn-64-20220713063601.rootfs.tar` > > Usually, the tools that support the oci image format also support the oci-archive image format. An exception is docker that does not support the oci image format and I have first to transform it using skopeo. > > What is the advantage of first un-taring the image and then doing the import? > There's no advantage, it's just the support for the OCI image format when I added it, was around the oci image, not the oci-archive, and it was designed around oci-image-tools, runc, and directly executing / manipulating the images. The tgz version was something I added after, to make it easier to copy them around, stage them, and otherwise collect artifacts. docker, podman or any other specific runtime wasn't the target. skopeo was from the beginning the tool that was used to copy/import the images, and that was with the oci: type .. not with the tarballs .. in those flows as well. I'm just pondering the right way to not break existing layouts and flows, and that will take me a bit longer. > Probably the other 2 patches that I send it with this one (https://lists.yoctoproject.org/g/meta-virtualization/message/7442, https://lists.yoctoproject.org/g/meta-virtualization/message/7441) are still relevant, because they are fixing other minor issues. > Yep, I still have those tagged in my "to-review" and "to-test" queues. Cheers, Bruce > > > Vasileios > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#7451): https://lists.yoctoproject.org/g/meta-virtualization/message/7451 > Mute This Topic: https://lists.yoctoproject.org/mt/92331697/1050810 > Group Owner: meta-virtualization+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar 2022-07-13 20:36 ` [meta-virtualization] " Bruce Ashfield @ 2022-07-14 6:49 ` Anagnostopoulos, Vasileios [not found] ` <17019F65456D67C8.559@lists.yoctoproject.org> 1 sibling, 0 replies; 9+ messages in thread From: Anagnostopoulos, Vasileios @ 2022-07-14 6:49 UTC (permalink / raw) To: Bruce Ashfield; +Cc: meta-virtualization Hello Bruce, Ok. Thank you for the extra info! Let me know if I can help in any way. Vasileios -----Original Message----- From: Bruce Ashfield <bruce.ashfield@gmail.com> Sent: Wednesday, 13 July 2022 22:37 To: Anagnostopoulos, Vasileios (SI BP R&D ZG FW ITW) <vasileios.anagnostopoulos@siemens.com> Cc: meta-virtualization@lists.yoctoproject.org Subject: Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar On Wed, Jul 13, 2022 at 3:19 AM Vasileios Anagnostopoulos <vasileios.anagnostopoulos@siemens.com> wrote: > > Hello Bruce, > > How do you generate the images and import them? Could you describe a bit more the use case? > > With podman for example you can load the image by using `podman load > -i > build-oci/tmp/deploy/images/capricorn-64/name-of-the-image-capricorn-6 > 4-20220713063601.rootfs.tar` > > Usually, the tools that support the oci image format also support the oci-archive image format. An exception is docker that does not support the oci image format and I have first to transform it using skopeo. > > What is the advantage of first un-taring the image and then doing the import? > There's no advantage, it's just the support for the OCI image format when I added it, was around the oci image, not the oci-archive, and it was designed around oci-image-tools, runc, and directly executing / manipulating the images. The tgz version was something I added after, to make it easier to copy them around, stage them, and otherwise collect artifacts. docker, podman or any other specific runtime wasn't the target. skopeo was from the beginning the tool that was used to copy/import the images, and that was with the oci: type .. not with the tarballs .. in those flows as well. I'm just pondering the right way to not break existing layouts and flows, and that will take me a bit longer. > Probably the other 2 patches that I send it with this one (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7442&data=05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7Ce7c7815f43d3483c14f508da650f6d65%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933414173777208%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RD4LV6MF%2BnRRQ8XoWpfskOl3UqEBIEMWLATbhT9Ny%2B4%3D&reserved=0, https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7441&data=05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7Ce7c7815f43d3483c14f508da650f6d65%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933414173777208%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Ump5aMIAv2jgdVmJHsXqhlS8ls6ywPV3jQv2F0%2BoCoo%3D&reserved=0) are still relevant, because they are fixing other minor issues. > Yep, I still have those tagged in my "to-review" and "to-test" queues. Cheers, Bruce > > > Vasileios > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#7451): > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist > s.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7451&data > =05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7Ce7c7815f43d3483c1 > 4f508da650f6d65%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933414 > 173777208%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vhWe9v3YtsxGI > Lew09eaASExIkXzQu%2BspPMmcnqg%2FkY%3D&reserved=0 > Mute This Topic: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist > s.yoctoproject.org%2Fmt%2F92331697%2F1050810&data=05%7C01%7Cvasile > ios.anagnostopoulos%40siemens.com%7Ce7c7815f43d3483c14f508da650f6d65%7 > C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933414173777208%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=76OW1JHk0VvjDBeL6j8MfSKMq6fwU7 > U%2BJE5DwyzGQHY%3D&reserved=0 Group Owner: > meta-virtualization+owner@lists.yoctoproject.org > Unsubscribe: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist > s.yoctoproject.org%2Fg%2Fmeta-virtualization%2Funsub&data=05%7C01% > 7Cvasileios.anagnostopoulos%40siemens.com%7Ce7c7815f43d3483c14f508da65 > 0f6d65%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933414173777208 > %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6I > k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WQKeT%2FXON37v1fW1uIc5 > GMW29oqVZSdMzvJvLS7NQEM%3D&reserved=0 [bruce.ashfield@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <17019F65456D67C8.559@lists.yoctoproject.org>]
* RE: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar [not found] ` <17019F65456D67C8.559@lists.yoctoproject.org> @ 2022-07-18 11:51 ` Anagnostopoulos, Vasileios 2022-07-18 12:43 ` Bruce Ashfield 0 siblings, 1 reply; 9+ messages in thread From: Anagnostopoulos, Vasileios @ 2022-07-18 11:51 UTC (permalink / raw) To: Anagnostopoulos, Vasileios, Bruce Ashfield; +Cc: meta-virtualization Hello Bruce, Thank you for merging the changes for the image-oci-umoci in the master branch! I was wondering, if it makes sense to also back port these changes to the kirkstone branch? If yes, should I send new patches for the kirkostone branch? Vasileios -----Original Message----- From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Vasileios Anagnostopoulos via lists.yoctoproject.org Sent: Thursday, 14 July 2022 08:50 To: Bruce Ashfield <bruce.ashfield@gmail.com> Cc: meta-virtualization@lists.yoctoproject.org Subject: Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar Hello Bruce, Ok. Thank you for the extra info! Let me know if I can help in any way. Vasileios -----Original Message----- From: Bruce Ashfield <bruce.ashfield@gmail.com> Sent: Wednesday, 13 July 2022 22:37 To: Anagnostopoulos, Vasileios (SI BP R&D ZG FW ITW) <vasileios.anagnostopoulos@siemens.com> Cc: meta-virtualization@lists.yoctoproject.org Subject: Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar On Wed, Jul 13, 2022 at 3:19 AM Vasileios Anagnostopoulos <vasileios.anagnostopoulos@siemens.com> wrote: > > Hello Bruce, > > How do you generate the images and import them? Could you describe a bit more the use case? > > With podman for example you can load the image by using `podman load > -i > build-oci/tmp/deploy/images/capricorn-64/name-of-the-image-capricorn-6 > 4-20220713063601.rootfs.tar` > > Usually, the tools that support the oci image format also support the oci-archive image format. An exception is docker that does not support the oci image format and I have first to transform it using skopeo. > > What is the advantage of first un-taring the image and then doing the import? > There's no advantage, it's just the support for the OCI image format when I added it, was around the oci image, not the oci-archive, and it was designed around oci-image-tools, runc, and directly executing / manipulating the images. The tgz version was something I added after, to make it easier to copy them around, stage them, and otherwise collect artifacts. docker, podman or any other specific runtime wasn't the target. skopeo was from the beginning the tool that was used to copy/import the images, and that was with the oci: type .. not with the tarballs .. in those flows as well. I'm just pondering the right way to not break existing layouts and flows, and that will take me a bit longer. > Probably the other 2 patches that I send it with this one (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7442&data=05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7C45180cb757f947e2f63008da656510d4%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933782366613603%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OnmF%2BmqKwRl0uBfYVswDG7Ko3f62BOMwFyzqQ3zOwjU%3D&reserved=0, https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7441&data=05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7C45180cb757f947e2f63008da656510d4%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933782366613603%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Bo56q8uJz5WdxSdKh3rzpdw4n9EguCgbgihXmlNPBIM%3D&reserved=0) are still relevant, because they are fixing other minor issues. > Yep, I still have those tagged in my "to-review" and "to-test" queues. Cheers, Bruce > > > Vasileios > > > > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar 2022-07-18 11:51 ` Anagnostopoulos, Vasileios @ 2022-07-18 12:43 ` Bruce Ashfield 0 siblings, 0 replies; 9+ messages in thread From: Bruce Ashfield @ 2022-07-18 12:43 UTC (permalink / raw) To: Anagnostopoulos, Vasileios; +Cc: meta-virtualization On Mon, Jul 18, 2022 at 7:51 AM Anagnostopoulos, Vasileios <vasileios.anagnostopoulos@siemens.com> wrote: > > Hello Bruce, > > Thank you for merging the changes for the image-oci-umoci in the master branch! I was wondering, if it makes sense to also back port these changes to the kirkstone branch? If yes, should I send new patches for the kirkostone branch? > I can do cherry picks. the tag change could easily be described as a bug fix (since I did have other tag support already in sloci), the stop signal is technically a "new feature", which I avoid backporting .. but it is a new feature with no ability to impact existing functionality. To summarize the rambling first paragraph, I can cherry pick the two changes to kirkstone :) Bruce > Vasileios > > -----Original Message----- > From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Vasileios Anagnostopoulos via lists.yoctoproject.org > Sent: Thursday, 14 July 2022 08:50 > To: Bruce Ashfield <bruce.ashfield@gmail.com> > Cc: meta-virtualization@lists.yoctoproject.org > Subject: Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar > > Hello Bruce, > > Ok. Thank you for the extra info! Let me know if I can help in any way. > > Vasileios > > -----Original Message----- > From: Bruce Ashfield <bruce.ashfield@gmail.com> > Sent: Wednesday, 13 July 2022 22:37 > To: Anagnostopoulos, Vasileios (SI BP R&D ZG FW ITW) <vasileios.anagnostopoulos@siemens.com> > Cc: meta-virtualization@lists.yoctoproject.org > Subject: Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent directory in tar > > On Wed, Jul 13, 2022 at 3:19 AM Vasileios Anagnostopoulos <vasileios.anagnostopoulos@siemens.com> wrote: > > > > Hello Bruce, > > > > How do you generate the images and import them? Could you describe a bit more the use case? > > > > With podman for example you can load the image by using `podman load > > -i > > build-oci/tmp/deploy/images/capricorn-64/name-of-the-image-capricorn-6 > > 4-20220713063601.rootfs.tar` > > > > Usually, the tools that support the oci image format also support the oci-archive image format. An exception is docker that does not support the oci image format and I have first to transform it using skopeo. > > > > What is the advantage of first un-taring the image and then doing the import? > > > > There's no advantage, it's just the support for the OCI image format when I added it, was around the oci image, not the oci-archive, and it was designed around oci-image-tools, runc, and directly executing / manipulating the images. The tgz version was something I added after, to make it easier to copy them around, stage them, and otherwise collect artifacts. docker, podman or any other specific runtime wasn't the target. > > skopeo was from the beginning the tool that was used to copy/import the images, and that was with the oci: type .. not with the tarballs .. in those flows as well. > > I'm just pondering the right way to not break existing layouts and flows, and that will take me a bit longer. > > > Probably the other 2 patches that I send it with this one (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7442&data=05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7C45180cb757f947e2f63008da656510d4%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933782366613603%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OnmF%2BmqKwRl0uBfYVswDG7Ko3f62BOMwFyzqQ3zOwjU%3D&reserved=0, https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7441&data=05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7C45180cb757f947e2f63008da656510d4%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933782366613603%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Bo56q8uJz5WdxSdKh3rzpdw4n9EguCgbgihXmlNPBIM%3D&reserved=0) are still relevant, because they are fixing other minor issues. > > > > Yep, I still have those tagged in my "to-review" and "to-test" queues. > > Cheers, > > Bruce > > > > > > > Vasileios > > > > > > > > > > > -- > - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end > - "Use the force Harry" - Gandalf, Star Trek II -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-07-18 12:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 12:26 [meta-virtualization][PATCH 1/3] image-oci-umoci: properly handle tags other than latest Vasileios Anagnostopoulos
2022-07-12 12:26 ` [meta-virtualization][PATCH 2/3] image-oci-umoci: add parameter for stop signal Vasileios Anagnostopoulos
2022-07-12 12:26 ` [meta-virtualization][PATCH 3/3] image-oci-umoci: skip parent directory in tar Vasileios Anagnostopoulos
2022-07-12 21:16 ` Bruce Ashfield
2022-07-13 7:19 ` [PATCH " Vasileios Anagnostopoulos
2022-07-13 20:36 ` [meta-virtualization] " Bruce Ashfield
2022-07-14 6:49 ` Anagnostopoulos, Vasileios
[not found] ` <17019F65456D67C8.559@lists.yoctoproject.org>
2022-07-18 11:51 ` Anagnostopoulos, Vasileios
2022-07-18 12:43 ` Bruce Ashfield
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).