From: Christopher Clark <christopher.w.clark@gmail.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "Kamil Dzieżyk" <Kamil.Dziezyk@arm.com>,
"meta-virtualization@lists.yoctoproject.org"
<meta-virtualization@lists.yoctoproject.org>,
"cardoe@gentoo.org" <cardoe@gentoo.org>
Subject: Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot
Date: Mon, 17 Jan 2022 10:06:25 -0800 [thread overview]
Message-ID: <CACMJ4GYGr8Soooa4PgfpZ0TzUSHVF6+rmnk0826aFz9_-b22Yg@mail.gmail.com> (raw)
In-Reply-To: <B3561BB1-3D00-4AA5-8176-9A28789F607F@arm.com>
[-- Attachment #1: Type: text/plain, Size: 3197 bytes --]
On Mon, Jan 17, 2022 at 12:33 AM Bertrand Marquis <Bertrand.Marquis@arm.com>
wrote:
> Hi Kamil,
>
> > On 13 Jan 2022, at 11:30, Kamil Dziezyk via lists.yoctoproject.org
> <kamil.dziezyk=arm.com@lists.yoctoproject.org> wrote:
> >
> > This patch changes the location of xen.conf file, that contains list of
> kernel
> > modules to be loaded during system boot, to "${nonarch_libdir}". This is
> done
> > by removing '--with-systemd-modules-load=' flag from EXTRA_OECONF
> variable.
> >
> > Previous path based on "${systemd_unitdir}" was not considered by
> default by
> > systemd-modules-load.service.
> >
> > Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>
Acked-by: Christopher Clark <christopher.w.clark@gmail.com>
Christopher
>
> Cheers
> Bertrand
>
> > ---
> > recipes-extended/xen/xen-tools.inc | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/recipes-extended/xen/xen-tools.inc
> b/recipes-extended/xen/xen-tools.inc
> > index ca924f4..6e25046 100644
> > --- a/recipes-extended/xen/xen-tools.inc
> > +++ b/recipes-extended/xen/xen-tools.inc
> > @@ -653,10 +653,10 @@ FILES:${PN}-xm = "\
> > "
> >
> > FILES:${PN}-xencommons += "\
> > + ${nonarch_libdir}/modules-load.d/xen.conf \
> > ${sysconfdir}/default/xencommons \
> > ${sysconfdir}/init.d/xencommons \
> > ${sysconfdir}/xen/scripts/launch-xenstore \
> > - ${systemd_unitdir}/modules-load.d/xen.conf \
> > ${systemd_unitdir}/system/proc-xen.mount \
> > ${systemd_unitdir}/system/xen-qemu-dom0-disk-backend.service \
> > ${systemd_unitdir}/system/xenconsoled.service \
> > @@ -744,7 +744,6 @@ SYSTEMD_SERVICE:${PN}-xendomains =
> "xendomains.service"
> >
> > EXTRA_OECONF += " \
> > --with-systemd=${systemd_unitdir}/system \
> > - --with-systemd-modules-load=${systemd_unitdir}/modules-load.d \
> > --with-initddir=${INIT_D_DIR} \
> > --with-sysconfig-leaf-dir=default \
> > --with-system-qemu=${bindir}/qemu-system-i386 \
> > --
> > 2.17.1
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#6999):
> https://lists.yoctoproject.org/g/meta-virtualization/message/6999
> > Mute This Topic: https://lists.yoctoproject.org/mt/88394698/3619089
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
> [bertrand.marquis@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
>
[-- Attachment #2: Type: text/html, Size: 4923 bytes --]
next prev parent reply other threads:[~2022-01-17 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 11:30 [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot Kamil Dziezyk
2022-01-13 11:30 ` [PATCH v3 2/2] xen: Clear TUNE_CCARGS for Xen build for aarch64 machines Kamil Dziezyk
2022-01-17 8:33 ` [meta-virtualization] " Bertrand Marquis
2022-01-17 18:04 ` Christopher Clark
2022-01-17 8:33 ` [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot Bertrand Marquis
2022-01-17 18:06 ` Christopher Clark [this message]
2022-01-19 3:44 ` Bruce Ashfield
2022-01-19 12:39 ` Diego Sueiro
2022-01-19 18:21 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACMJ4GYGr8Soooa4PgfpZ0TzUSHVF6+rmnk0826aFz9_-b22Yg@mail.gmail.com \
--to=christopher.w.clark@gmail.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Kamil.Dziezyk@arm.com \
--cc=cardoe@gentoo.org \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).