Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot

From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Diego Sueiro <Diego.Sueiro@arm.com>
Cc: "Kamil Dzieżyk" <Kamil.Dziezyk@arm.com>,
	"meta-virtualization@lists.yoctoproject.org"
	<meta-virtualization@lists.yoctoproject.org>,
	"christopher.w.clark@gmail.com" <christopher.w.clark@gmail.com>,
	"cardoe@gentoo.org" <cardoe@gentoo.org>, nd <nd@arm.com>
Subject: Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot
Date: Wed, 19 Jan 2022 13:21:23 -0500	[thread overview]
Message-ID: <CADkTA4MN2ZhaaAN+3nk7V2UMsxfyDDXXqCQwO4=JUwPiPy+QhQ@mail.gmail.com> (raw)
In-Reply-To: <AM6PR08MB34615E150DB7600831CD308792599@AM6PR08MB3461.eurprd08.prod.outlook.com>

On Wed, Jan 19, 2022 at 7:39 AM Diego Sueiro <Diego.Sueiro@arm.com> wrote:
>
> Hello Bruce,
>
> Thanks for getting this merged.
>
> We consider these patches as bug fixing and in this case is it possible to have them backported (cherry picked) to honister branch?
>

Agreed. they are bug fixes, so I've done the cherry pick to honister.

Bruce

> Cheers,
>
> --
> Diego Sueiro
>
> >-----Original Message-----
> >From: meta-virtualization@lists.yoctoproject.org <meta-
> >virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield via
> >lists.yoctoproject.org
> >Sent: 19 January 2022 03:44
> >To: Kamil Dzieżyk <Kamil.Dziezyk@arm.com>
> >Cc: meta-virtualization@lists.yoctoproject.org;
> >christopher.w.clark@gmail.com; cardoe@gentoo.org
> >Subject: Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related
> >kernel modules during system boot
> >
> >merged.
> >
> >Bruce
> >
> >In message: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related
> >kernel modules during system boot on 13/01/2022 Kamil Dziezyk wrote:
> >
> >> This patch changes the location of xen.conf file, that contains list
> >> of kernel modules to be loaded during system boot, to
> >> "${nonarch_libdir}". This is done by removing '--with-systemd-modules-
> >load=' flag from EXTRA_OECONF variable.
> >>
> >> Previous path based on "${systemd_unitdir}" was not considered by
> >> default by systemd-modules-load.service.
> >>
> >> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
> >> ---
> >>  recipes-extended/xen/xen-tools.inc | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/recipes-extended/xen/xen-tools.inc
> >> b/recipes-extended/xen/xen-tools.inc
> >> index ca924f4..6e25046 100644
> >> --- a/recipes-extended/xen/xen-tools.inc
> >> +++ b/recipes-extended/xen/xen-tools.inc
> >> @@ -653,10 +653,10 @@ FILES:${PN}-xm = "\
> >>      "
> >>
> >>  FILES:${PN}-xencommons += "\
> >> +    ${nonarch_libdir}/modules-load.d/xen.conf \
> >>      ${sysconfdir}/default/xencommons \
> >>      ${sysconfdir}/init.d/xencommons \
> >>      ${sysconfdir}/xen/scripts/launch-xenstore \
> >> -    ${systemd_unitdir}/modules-load.d/xen.conf \
> >>      ${systemd_unitdir}/system/proc-xen.mount \
> >>      ${systemd_unitdir}/system/xen-qemu-dom0-disk-backend.service \
> >>      ${systemd_unitdir}/system/xenconsoled.service \ @@ -744,7 +744,6
> >> @@ SYSTEMD_SERVICE:${PN}-xendomains = "xendomains.service"
> >>
> >>  EXTRA_OECONF += " \
> >>      --with-systemd=${systemd_unitdir}/system \
> >> -    --with-systemd-modules-load=${systemd_unitdir}/modules-load.d \
> >>      --with-initddir=${INIT_D_DIR} \
> >>      --with-sysconfig-leaf-dir=default \
> >>      --with-system-qemu=${bindir}/qemu-system-i386 \
> >> --
> >> 2.17.1
> >>
> >> IMPORTANT NOTICE: The contents of this email and any attachments are
> >confidential and may also be privileged. If you are not the intended recipient,
> >please notify the sender immediately and do not disclose the contents to any
> >other person, use it for any purpose, or store or copy the information in any
> >medium. Thank you.
> >
> >>
> >>
> >>
> >
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II