meta-virtualization.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Jose Quaresma <quaresma.jose@gmail.com>
Cc: meta-virtualization@lists.yoctoproject.org,
	Jose Quaresma <jose.quaresma@foundries.io>
Subject: Re: [meta-virtualization][kirkstone][master][PATCH 2/4] kubernetes: install the binaries in OE standard places
Date: Tue, 9 Aug 2022 09:19:14 -0400	[thread overview]
Message-ID: <CADkTA4OGLGXrRWaEVJMpUKs_X3F3nJf1Y7LUQP4SziXXPaBJ2g@mail.gmail.com> (raw)
In-Reply-To: <20220809121619.32258-2-jose.quaresma@foundries.io>

You must have something different in your environment, I'm not seeing
any of these same issues.

Cheers,

Bruce

On Tue, Aug 9, 2022 at 8:16 AM Jose Quaresma <quaresma.jose@gmail.com> wrote:
>
> - The env BIN_PREFIX is there from the beginning but there are no references to it,
> also fix a fatal QA errors installed-vs-shipped.
>
> ERROR: kubernetes-1_v1.23.6+gitfbcfa33018159c033aee77b0d5456df6771aa9b5-r0 do_package: QA Issue: kubernetes: Files/directories were installed but not shipped in any package:
>   /bin
>   /bin/k8s-init
> Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> kubernetes: 2 installed and not shipped files. [installed-vs-shipped]
> ERROR: kubernetes-1_v1.23.6+gitfbcfa33018159c033aee77b0d5456df6771aa9b5-r0 do_package: Fatal QA errors were found, failing task.
>
> Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
> ---
>  recipes-containers/kubernetes/kubernetes_git.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/recipes-containers/kubernetes/kubernetes_git.bb b/recipes-containers/kubernetes/kubernetes_git.bb
> index e9460d4..82b75b1 100644
> --- a/recipes-containers/kubernetes/kubernetes_git.bb
> +++ b/recipes-containers/kubernetes/kubernetes_git.bb
> @@ -103,8 +103,8 @@ do_install() {
>      install -m 0644 ${WORKDIR}/git/release/cmd/kubepkg/templates/latest/deb/kubeadm/10-kubeadm.conf  ${D}${systemd_unitdir}/system/kubelet.service.d/
>
>      if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
> -       install -d "${D}${BIN_PREFIX}/bin"
> -       install -m 755 "${WORKDIR}/k8s-init" "${D}${BIN_PREFIX}/bin"
> +       install -d ${D}${bindir}
> +       install -m 755 ${WORKDIR}/k8s-init ${D}${bindir}
>
>         install -d ${D}${sysconfdir}/sysctl.d
>         install -m 0644 "${WORKDIR}/99-kubernetes.conf" "${D}${sysconfdir}/sysctl.d"
> @@ -141,7 +141,7 @@ FILES:kube-proxy = "${bindir}/kube-proxy"
>  FILES:${PN}-misc = "${bindir} ${sysconfdir}/sysctl.d"
>
>  ALLOW_EMPTY:${PN}-host = "1"
> -FILE:${PN}-host = "${BIN_PREFIX}/bin/k8s-init"
> +FILE:${PN}-host = "${bindir}/k8s-init"
>  RDEPENDS:${PN}-host = "${PN}"
>
>  RRECOMMENDS:${PN} = "\
> --
> 2.37.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7496): https://lists.yoctoproject.org/g/meta-virtualization/message/7496
> Mute This Topic: https://lists.yoctoproject.org/mt/92913426/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


  reply	other threads:[~2022-08-09 13:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 12:16 [meta-virtualization][kirkstone][master][PATCH 1/4] nerdctl: install the binaries in OE standard places Jose Quaresma
2022-08-09 12:16 ` [meta-virtualization][kirkstone][master][PATCH 2/4] kubernetes: " Jose Quaresma
2022-08-09 13:19   ` Bruce Ashfield [this message]
2022-08-09 13:33     ` Jose Quaresma
2022-08-09 13:43       ` Bruce Ashfield
2022-08-09 14:02         ` Jose Quaresma
2022-08-09 14:21           ` Bruce Ashfield
     [not found]           ` <1709B323FD9DD073.19746@lists.yoctoproject.org>
2022-08-09 15:05             ` Bruce Ashfield
2022-08-09 16:35               ` Jose Quaresma
2022-08-09 17:06                 ` Bruce Ashfield
2022-08-09 17:36                   ` Jose Quaresma
2022-08-09 18:15                     ` Bruce Ashfield
2022-08-09 12:16 ` [meta-virtualization][kirkstone][master][PATCH 3/4] kubernetes: replace tabs with spaces for identation Jose Quaresma
2022-08-09 12:16 ` [meta-virtualization][kirkstone][master][PATCH 4/4] k3s: install the binaries in OE standard places Jose Quaresma
2022-08-09 13:18 ` [meta-virtualization][kirkstone][master][PATCH 1/4] nerdctl: " Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADkTA4OGLGXrRWaEVJMpUKs_X3F3nJf1Y7LUQP4SziXXPaBJ2g@mail.gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=jose.quaresma@foundries.io \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=quaresma.jose@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).