Re: [meta-virtualization][kirkstone][master][PATCH 2/4] kubernetes: install the binaries in OE standard places

[Jose Quaresma <quaresma.jose@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3423 bytes --]

Hi Bruce,

Bruce Ashfield <bruce.ashfield@gmail.com> escreveu no dia terça, 9/08/2022
à(s) 14:19:

> You must have something different in your environment, I'm not seeing
> any of these same issues.
>

Maybe because you have the BIN_PREFIX defined somewhere in your distro or
local.conf
BIN_PREFIX is defined only in k3s recipe BIN_PREFIX ?=
"${exec_prefix}/local"

Jose


>
> Cheers,
>
> Bruce
>
> On Tue, Aug 9, 2022 at 8:16 AM Jose Quaresma <quaresma.jose@gmail.com>
> wrote:
> >
> > - The env BIN_PREFIX is there from the beginning but there are no
> references to it,
> > also fix a fatal QA errors installed-vs-shipped.
> >
> > ERROR:
> kubernetes-1_v1.23.6+gitfbcfa33018159c033aee77b0d5456df6771aa9b5-r0
> do_package: QA Issue: kubernetes: Files/directories were installed but not
> shipped in any package:
> >   /bin
> >   /bin/k8s-init
> > Please set FILES such that these items are packaged. Alternatively if
> they are unneeded, avoid installing them or delete them within do_install.
> > kubernetes: 2 installed and not shipped files. [installed-vs-shipped]
> > ERROR:
> kubernetes-1_v1.23.6+gitfbcfa33018159c033aee77b0d5456df6771aa9b5-r0
> do_package: Fatal QA errors were found, failing task.
> >
> > Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
> > ---
> >  recipes-containers/kubernetes/kubernetes_git.bb | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/recipes-containers/kubernetes/kubernetes_git.bb
> b/recipes-containers/kubernetes/kubernetes_git.bb
> > index e9460d4..82b75b1 100644
> > --- a/recipes-containers/kubernetes/kubernetes_git.bb
> > +++ b/recipes-containers/kubernetes/kubernetes_git.bb
> > @@ -103,8 +103,8 @@ do_install() {
> >      install -m 0644
> ${WORKDIR}/git/release/cmd/kubepkg/templates/latest/deb/kubeadm/10-kubeadm.conf
> ${D}${systemd_unitdir}/system/kubelet.service.d/
> >
> >      if
> ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
> > -       install -d "${D}${BIN_PREFIX}/bin"
> > -       install -m 755 "${WORKDIR}/k8s-init" "${D}${BIN_PREFIX}/bin"
> > +       install -d ${D}${bindir}
> > +       install -m 755 ${WORKDIR}/k8s-init ${D}${bindir}
> >
> >         install -d ${D}${sysconfdir}/sysctl.d
> >         install -m 0644 "${WORKDIR}/99-kubernetes.conf"
> "${D}${sysconfdir}/sysctl.d"
> > @@ -141,7 +141,7 @@ FILES:kube-proxy = "${bindir}/kube-proxy"
> >  FILES:${PN}-misc = "${bindir} ${sysconfdir}/sysctl.d"
> >
> >  ALLOW_EMPTY:${PN}-host = "1"
> > -FILE:${PN}-host = "${BIN_PREFIX}/bin/k8s-init"
> > +FILE:${PN}-host = "${bindir}/k8s-init"
> >  RDEPENDS:${PN}-host = "${PN}"
> >
> >  RRECOMMENDS:${PN} = "\
> > --
> > 2.37.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#7496):
> https://lists.yoctoproject.org/g/meta-virtualization/message/7496
> > Mute This Topic: https://lists.yoctoproject.org/mt/92913426/1050810
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
> [bruce.ashfield@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>


-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 5555 bytes --]