[master][scarthgap][meta-virtualization][PATCH] kubernetes: skip textrel QA warning

[master][scarthgap][meta-virtualization][PATCH] kubernetes: skip textrel QA warning

[changqing.li]

From: Changqing Li <changqing.li@windriver.com>

-buildmode=pie need cgo is enabled, but for kubernetes, some build
targets are static, and cgo is disable in build script directly, refer
[1]. If we add -buildmode=pie by default, will cause these static target
build failed with error "-buildmode=pie requires external (cgo) linking,
but cgo is not enabled".

This warning is acceptable, so just skip it.

[1] https://github.com/kubernetes/kubernetes/blob/master/hack/lib/golang.sh#L811

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 recipes-containers/kubernetes/kubernetes_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-containers/kubernetes/kubernetes_git.bb b/recipes-containers/kubernetes/kubernetes_git.bb
index d7874dfa..044175eb 100644
--- a/recipes-containers/kubernetes/kubernetes_git.bb
+++ b/recipes-containers/kubernetes/kubernetes_git.bb
@@ -126,7 +126,7 @@ PACKAGES =+ "kubeadm kubectl kubelet kube-proxy ${PN}-misc ${PN}-host"
 ALLOW_EMPTY:${PN} = "1"
 INSANE_SKIP:${PN} += "ldflags already-stripped"
 INSANE_SKIP:${PN}-misc += "ldflags already-stripped textrel"
-INSANE_SKIP:kubelet += "ldflags already-stripped"
+INSANE_SKIP:${MLPREFIX}kubelet += "ldflags already-stripped textrel"
 
 # Note: we are explicitly *not* adding docker to the rdepends, since we allow
 #       backends like cri-o to be used.
-- 
2.25.1

Re: [master][scarthgap][meta-virtualization][PATCH] kubernetes: skip textrel QA warning

[Bruce Ashfield]

merged.

Bruce

In message: [master][scarthgap][meta-virtualization][PATCH] kubernetes: skip textrel QA warning
on 30/04/2024 Changqing Li via lists.yoctoproject.org wrote:

> From: Changqing Li <changqing.li@windriver.com>
> 
> -buildmode=pie need cgo is enabled, but for kubernetes, some build
> targets are static, and cgo is disable in build script directly, refer
> [1]. If we add -buildmode=pie by default, will cause these static target
> build failed with error "-buildmode=pie requires external (cgo) linking,
> but cgo is not enabled".
> 
> This warning is acceptable, so just skip it.
> 
> [1] https://github.com/kubernetes/kubernetes/blob/master/hack/lib/golang.sh#L811
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  recipes-containers/kubernetes/kubernetes_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-containers/kubernetes/kubernetes_git.bb b/recipes-containers/kubernetes/kubernetes_git.bb
> index d7874dfa..044175eb 100644
> --- a/recipes-containers/kubernetes/kubernetes_git.bb
> +++ b/recipes-containers/kubernetes/kubernetes_git.bb
> @@ -126,7 +126,7 @@ PACKAGES =+ "kubeadm kubectl kubelet kube-proxy ${PN}-misc ${PN}-host"
>  ALLOW_EMPTY:${PN} = "1"
>  INSANE_SKIP:${PN} += "ldflags already-stripped"
>  INSANE_SKIP:${PN}-misc += "ldflags already-stripped textrel"
> -INSANE_SKIP:kubelet += "ldflags already-stripped"
> +INSANE_SKIP:${MLPREFIX}kubelet += "ldflags already-stripped textrel"
>  
>  # Note: we are explicitly *not* adding docker to the rdepends, since we allow
>  #       backends like cri-o to be used.
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8706): https://lists.yoctoproject.org/g/meta-virtualization/message/8706
> Mute This Topic: https://lists.yoctoproject.org/mt/105816435/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>