* [PATCH] toaster: Added validation to stop import if there is a build in progress
@ 2023-12-14 19:44 Marlon Rodriguez Garcia
0 siblings, 0 replies; only message in thread
From: Marlon Rodriguez Garcia @ 2023-12-14 19:44 UTC (permalink / raw)
To: bitbake-devel, toaster; +Cc: Marlon Rodriguez Garcia
Added validation to prevent simultaneous imports from running because the database fails at runtime.
The option to create a queue was taken into consideration. However, it will require the use of Celery https://pypi.org/project/celery/ or Background Task https://pypi.org/project/django-background-tasks/ which require the use of external services and multiple dependencies.
If required we could explore the alternative in the future.
Signed-off-by: Marlon Rodriguez Garcia <marlon.rodriguez-garcia@savoirfairelinux.com>
---
lib/toaster/toastergui/templates/command_line_builds.html | 6 +++++-
lib/toaster/toastergui/views.py | 8 ++++++++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/lib/toaster/toastergui/templates/command_line_builds.html b/lib/toaster/toastergui/templates/command_line_builds.html
index fcbe80d8..05db6727 100644
--- a/lib/toaster/toastergui/templates/command_line_builds.html
+++ b/lib/toaster/toastergui/templates/command_line_builds.html
@@ -152,7 +152,11 @@ function _ajax_update(file, all, dir){
type: "POST",
data: {file: file, all: all, dir: dir},
success:function(data){
- window.location = '/toastergui/builds/'
+ if (data['response']=='building'){
+ location.reload()
+ } else {
+ window.location = '/toastergui/builds/'
+ }
},
complete:function(data){
},
diff --git a/lib/toaster/toastergui/views.py b/lib/toaster/toastergui/views.py
index 3b5b9f5b..40aed265 100644
--- a/lib/toaster/toastergui/views.py
+++ b/lib/toaster/toastergui/views.py
@@ -2018,6 +2018,14 @@ class CommandLineBuilds(TemplateView):
logs_dir = request.POST.get('dir')
all_files = request.POST.get('all')
+ # check if a build is already in progress
+ if Build.objects.filter(outcome=Build.IN_PROGRESS):
+ messages.add_message(
+ self.request,
+ messages.ERROR,
+ "A build is already in progress. Please wait for it to complete before starting a new build."
+ )
+ return JsonResponse({'response': 'building'})
imported_files = EventLogsImports.objects.all()
try:
if all_files == 'true':
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-12-14 19:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-14 19:44 [PATCH] toaster: Added validation to stop import if there is a build in progress Marlon Rodriguez Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).