From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, martin.petersen@oracle.com,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
target-devel@vger.kernel.org, haris.iqbal@ionos.com,
jinpu.wang@ionos.com, manoj@linux.ibm.com, mrochs@linux.ibm.com,
ukrishn@linux.ibm.com, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com,
dm-devel@redhat.com
Subject: Re: remove REQ_OP_WRITE_SAME v2
Date: Wed, 09 Feb 2022 13:00:26 -0500 [thread overview]
Message-ID: <yq1wni3sz4k.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220209082828.2629273-1-hch@lst.de> (Christoph Hellwig's message of "Wed, 9 Feb 2022 09:28:21 +0100")
Christoph,
> Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the
> kernel there is very little use left for REQ_OP_WRITE_SAME. We only
> have two callers left, and both just export optional protocol features
> to remote systems: DRBD and the target code.
No particular objections from me. I had a half-baked series to do the
same thing.
One thing I would like is to either pull this series through SCSI or do
the block pieces in a post merge branch because I'm about to post my
discard/zeroing rework and that's going to clash with your changes.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, manoj@linux.ibm.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, philipp.reisner@linbit.com,
linux-block@vger.kernel.org, dm-devel@redhat.com,
target-devel@vger.kernel.org, haris.iqbal@ionos.com,
ukrishn@linux.ibm.com, lars.ellenberg@linbit.com,
drbd-dev@lists.linbit.com, jinpu.wang@ionos.com,
mrochs@linux.ibm.com
Subject: Re: [dm-devel] remove REQ_OP_WRITE_SAME v2
Date: Wed, 09 Feb 2022 13:00:26 -0500 [thread overview]
Message-ID: <yq1wni3sz4k.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220209082828.2629273-1-hch@lst.de> (Christoph Hellwig's message of "Wed, 9 Feb 2022 09:28:21 +0100")
Christoph,
> Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the
> kernel there is very little use left for REQ_OP_WRITE_SAME. We only
> have two callers left, and both just export optional protocol features
> to remote systems: DRBD and the target code.
No particular objections from me. I had a half-baked series to do the
same thing.
One thing I would like is to either pull this series through SCSI or do
the block pieces in a post merge branch because I'm about to post my
discard/zeroing rework and that's going to clash with your changes.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-02-09 18:00 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 8:28 remove REQ_OP_WRITE_SAME v2 Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] " Christoph Hellwig
2022-02-09 8:28 ` [PATCH 1/7] cxlflash: query write_zeroes limit for zeroing Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] " Christoph Hellwig
2022-02-09 8:43 ` Chaitanya Kulkarni
2022-02-09 8:43 ` [dm-devel] " Chaitanya Kulkarni
2022-02-09 8:28 ` [PATCH 2/7] drbd: drop REQ_OP_WRITE_SAME support Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] " Christoph Hellwig
2022-02-09 8:28 ` [PATCH 3/7] rnbd: drop WRITE_SAME support Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] " Christoph Hellwig
2022-02-09 8:44 ` Chaitanya Kulkarni
2022-02-09 8:44 ` [dm-devel] " Chaitanya Kulkarni
2022-02-09 9:05 ` Guoqing Jiang
2022-02-09 9:05 ` [dm-devel] " Guoqing Jiang
2022-02-09 9:13 ` Jinpu Wang
2022-02-09 9:13 ` [dm-devel] " Jinpu Wang
2022-02-09 9:21 ` Guoqing Jiang
2022-02-09 9:21 ` [dm-devel] " Guoqing Jiang
2022-02-09 10:16 ` Jinpu Wang
2022-02-09 10:16 ` [dm-devel] " Jinpu Wang
2022-02-09 14:04 ` Christoph Hellwig
2022-02-09 14:04 ` [dm-devel] " Christoph Hellwig
2022-02-09 14:08 ` Jinpu Wang
2022-02-09 14:08 ` [dm-devel] " Jinpu Wang
2022-02-09 8:28 ` [PATCH 4/7] sd: remove write same support Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] " Christoph Hellwig
2022-02-09 8:45 ` Chaitanya Kulkarni
2022-02-09 8:45 ` [dm-devel] " Chaitanya Kulkarni
2022-02-09 8:28 ` [PATCH 5/7] md: drop WRITE_SAME support Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] " Christoph Hellwig
2022-02-09 8:28 ` [PATCH 6/7] dm: remove write same support Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] " Christoph Hellwig
2022-02-16 18:45 ` Mike Snitzer
2022-02-16 18:45 ` [dm-devel] " Mike Snitzer
2022-02-09 8:28 ` [PATCH 7/7] block: remove REQ_OP_WRITE_SAME support Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] " Christoph Hellwig
2022-02-09 8:46 ` Chaitanya Kulkarni
2022-02-09 8:46 ` [dm-devel] " Chaitanya Kulkarni
2022-02-20 1:44 ` Martin K. Petersen
2022-02-20 1:44 ` [dm-devel] " Martin K. Petersen
2022-02-22 7:38 ` Christoph Hellwig
2022-02-22 7:38 ` Christoph Hellwig
2022-02-23 1:58 ` Martin K. Petersen
2022-02-23 1:58 ` [dm-devel] " Martin K. Petersen
2022-02-09 8:47 ` remove REQ_OP_WRITE_SAME v2 Chaitanya Kulkarni
2022-02-09 8:47 ` [dm-devel] " Chaitanya Kulkarni
2022-02-09 18:00 ` Martin K. Petersen [this message]
2022-02-09 18:00 ` Martin K. Petersen
2022-02-10 5:51 ` Christoph Hellwig
2022-02-10 5:51 ` [dm-devel] " Christoph Hellwig
2022-02-17 3:07 ` Jens Axboe
2022-02-17 3:07 ` [dm-devel] " Jens Axboe
2022-02-17 6:43 ` Christoph Hellwig
2022-02-17 6:43 ` [dm-devel] " Christoph Hellwig
2022-02-18 4:27 ` Martin K. Petersen
2022-02-18 4:27 ` [dm-devel] " Martin K. Petersen
2022-02-19 23:33 ` Martin K. Petersen
2022-02-19 23:33 ` [dm-devel] " Martin K. Petersen
2022-02-28 3:43 ` Martin K. Petersen
2022-02-28 3:43 ` [dm-devel] " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wni3sz4k.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=jinpu.wang@ionos.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manoj@linux.ibm.com \
--cc=mrochs@linux.ibm.com \
--cc=philipp.reisner@linbit.com \
--cc=target-devel@vger.kernel.org \
--cc=ukrishn@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.