From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
target-devel@vger.kernel.org,
Pavel Zakharov <pavel.zakharov@delphix.com>,
Mike Christie <mchristi@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "target/core: Inline transport_lun_remove_cmd()"
Date: Wed, 12 Feb 2020 23:51:24 +0000 [thread overview]
Message-ID: <yq1wo8rs6tf.fsf@oracle.com> (raw)
In-Reply-To: <20200210051202.12934-1-bvanassche@acm.org> (Bart Van Assche's message of "Sun, 9 Feb 2020 21:12:02 -0800")
Bart,
> Commit 83f85b8ec305 postponed the percpu_ref_put(&se_cmd->se_lun->lun_ref)
> call from command completion to the time when the final command reference is
> dropped. That approach is not compatible with the iSCSI target driver
> because the iSCSI target driver keeps the command with the highest stat_sn
> after it has completed until the next command is received (see also
> iscsit_ack_from_expstatsn()). Fix this regression by reverting commit
> 83f85b8ec305.
Applied to 5.6/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
target-devel@vger.kernel.org,
Pavel Zakharov <pavel.zakharov@delphix.com>,
Mike Christie <mchristi@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "target/core: Inline transport_lun_remove_cmd()"
Date: Wed, 12 Feb 2020 18:51:24 -0500 [thread overview]
Message-ID: <yq1wo8rs6tf.fsf@oracle.com> (raw)
In-Reply-To: <20200210051202.12934-1-bvanassche@acm.org> (Bart Van Assche's message of "Sun, 9 Feb 2020 21:12:02 -0800")
Bart,
> Commit 83f85b8ec305 postponed the percpu_ref_put(&se_cmd->se_lun->lun_ref)
> call from command completion to the time when the final command reference is
> dropped. That approach is not compatible with the iSCSI target driver
> because the iSCSI target driver keeps the command with the highest stat_sn
> after it has completed until the next command is received (see also
> iscsit_ack_from_expstatsn()). Fix this regression by reverting commit
> 83f85b8ec305.
Applied to 5.6/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-02-12 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 5:12 [PATCH] Revert "target/core: Inline transport_lun_remove_cmd()" Bart Van Assche
2020-02-10 5:12 ` Bart Van Assche
2020-02-10 15:35 ` Pavel Zakharov
2020-02-10 15:35 ` Pavel Zakharov
2020-02-12 23:51 ` Martin K. Petersen [this message]
2020-02-12 23:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wo8rs6tf.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=mchristi@redhat.com \
--cc=pavel.zakharov@delphix.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.