From: "Måns Rullgård" <mans@mansr.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <broonie@kernel.org>,
<linux-kernel@vger.kernel.org>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Wenyou Yang <wenyou.yang@atmel.com>, <linux-spi@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform
Date: Thu, 28 Jan 2016 16:00:13 +0000 [thread overview]
Message-ID: <yw1x37thk836.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <1453913312-18108-1-git-send-email-nicolas.ferre@atmel.com> (Nicolas Ferre's message of "Wed, 27 Jan 2016 17:48:32 +0100")
Nicolas Ferre <nicolas.ferre@atmel.com> writes:
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>
> The non-DT platform that uses this driver (actually the AVR32) was taking a bad
> branch for determining if the IP would use gpio for CS.
> Adding the presence of DT as a condition fixes this issue.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> [nicolas.ferre@atmel.com: extract from ml discussion]
> Reported-by: Mans Rullgard <mans@mansr.com>
> Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
> Cc: <stable@vger.kernel.org> # 4.2+
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Tested-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/spi/spi-atmel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index aebad36391c9..8feac599e9ab 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
>
> as->use_cs_gpios = true;
> if (atmel_spi_is_v2(as) &&
> + pdev->dev.of_node &&
> !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
> as->use_cs_gpios = false;
> master->num_chipselect = 4;
> --
> 2.1.3
>
--
Måns Rullgård
WARNING: multiple messages have this Message-ID (diff)
From: "Måns Rullgård" <mans@mansr.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <broonie@kernel.org>,
<linux-kernel@vger.kernel.org>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Wenyou Yang <wenyou.yang@atmel.com>, <linux-spi@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform
Date: Thu, 28 Jan 2016 16:00:13 +0000 [thread overview]
Message-ID: <yw1x37thk836.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <1453913312-18108-1-git-send-email-nicolas.ferre@atmel.com> (Nicolas Ferre's message of "Wed, 27 Jan 2016 17:48:32 +0100")
Nicolas Ferre <nicolas.ferre@atmel.com> writes:
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>
> The non-DT platform that uses this driver (actually the AVR32) was taking a bad
> branch for determining if the IP would use gpio for CS.
> Adding the presence of DT as a condition fixes this issue.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> [nicolas.ferre@atmel.com: extract from ml discussion]
> Reported-by: Mans Rullgard <mans@mansr.com>
> Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
> Cc: <stable@vger.kernel.org> # 4.2+
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Tested-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/spi/spi-atmel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index aebad36391c9..8feac599e9ab 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
>
> as->use_cs_gpios = true;
> if (atmel_spi_is_v2(as) &&
> + pdev->dev.of_node &&
> !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
> as->use_cs_gpios = false;
> master->num_chipselect = 4;
> --
> 2.1.3
>
--
M�ns Rullg�rd
WARNING: multiple messages have this Message-ID (diff)
From: "Måns Rullgård" <mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
To: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cyrille Pitchen
<cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform
Date: Thu, 28 Jan 2016 16:00:13 +0000 [thread overview]
Message-ID: <yw1x37thk836.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <1453913312-18108-1-git-send-email-nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> (Nicolas Ferre's message of "Wed, 27 Jan 2016 17:48:32 +0100")
Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> writes:
> From: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>
> The non-DT platform that uses this driver (actually the AVR32) was taking a bad
> branch for determining if the IP would use gpio for CS.
> Adding the presence of DT as a condition fixes this issue.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> [nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org: extract from ml discussion]
> Reported-by: Mans Rullgard <mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
> Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # 4.2+
> Signed-off-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Tested-by: Mans Rullgard <mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/spi/spi-atmel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index aebad36391c9..8feac599e9ab 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
>
> as->use_cs_gpios = true;
> if (atmel_spi_is_v2(as) &&
> + pdev->dev.of_node &&
> !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
> as->use_cs_gpios = false;
> master->num_chipselect = 4;
> --
> 2.1.3
>
--
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mans@mansr.com (Måns Rullgård)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform
Date: Thu, 28 Jan 2016 16:00:13 +0000 [thread overview]
Message-ID: <yw1x37thk836.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <1453913312-18108-1-git-send-email-nicolas.ferre@atmel.com> (Nicolas Ferre's message of "Wed, 27 Jan 2016 17:48:32 +0100")
Nicolas Ferre <nicolas.ferre@atmel.com> writes:
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>
> The non-DT platform that uses this driver (actually the AVR32) was taking a bad
> branch for determining if the IP would use gpio for CS.
> Adding the presence of DT as a condition fixes this issue.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> [nicolas.ferre at atmel.com: extract from ml discussion]
> Reported-by: Mans Rullgard <mans@mansr.com>
> Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
> Cc: <stable@vger.kernel.org> # 4.2+
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Tested-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/spi/spi-atmel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index aebad36391c9..8feac599e9ab 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
>
> as->use_cs_gpios = true;
> if (atmel_spi_is_v2(as) &&
> + pdev->dev.of_node &&
> !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
> as->use_cs_gpios = false;
> master->num_chipselect = 4;
> --
> 2.1.3
>
--
M?ns Rullg?rd
next prev parent reply other threads:[~2016-01-28 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 16:48 [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform Nicolas Ferre
2016-01-27 16:48 ` Nicolas Ferre
2016-01-27 16:48 ` Nicolas Ferre
2016-01-28 16:00 ` Måns Rullgård [this message]
2016-01-28 16:00 ` Måns Rullgård
2016-01-28 16:00 ` Måns Rullgård
2016-01-28 16:00 ` Måns Rullgård
2016-01-28 22:52 ` Applied "spi: atmel: fix gpio chip-select in case of non-DT platform" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1x37thk836.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=stable@vger.kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.