From: lijiang <lijiang@redhat.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: dan.j.williams@intel.com, brijesh.singh@amd.com, bhe@redhat.com,
thomas.lendacky@amd.com, tiwai@suse.de, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, baiyaowei@cmss.chinamobile.com, hpa@zytor.com,
tglx@linutronix.de, bp@suse.de, dyoung@redhat.com,
akpm@linux-foundation.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 0/3] find_next_iomem_res() fixes
Date: Wed, 26 Sep 2018 17:22:55 +0800 [thread overview]
Message-ID: <1894f2ba-42ab-c044-ea0c-63eab98d9815@redhat.com> (raw)
In-Reply-To: <153782698067.130337.12079523922130875402.stgit@bhelgaas-glaptop.roam.corp.google.com>
在 2018年09月25日 06:14, Bjorn Helgaas 写道:
> Hi Lianbo,
>
> These three patches are a possible replacement for your first patch
> ("[PATCH 1/3 v3] resource: fix an error which walks through iomem
> resources").
>
> I think the interface of find_next_iomem_res() can be improved to make
> the code easier to read and also avoid the errors you're fixing.
>
> I can't test these, so they've only been compiled. If you can test
> them and if you like them, feel free to incorporate them into your
> series. If not, just drop them (but please at least fix the same
> error in walk_system_ram_range()).
>
Hi, Bjorn
Sorry for my late reply about this. No need to incorporate them into
my patch series, you might freely submit them to upstream.
I will test your patches whether it can also work well for my case, and
you will get feedback about my test later.
Thanks.
Lianbo
> ---
>
> Bjorn Helgaas (3):
> x86/kexec: Correct KEXEC_BACKUP_SRC_END off-by-one error
> resource: Include resource end in walk_*() interfaces
> resource: Fix find_next_iomem_res() iteration issue
>
>
> arch/x86/include/asm/kexec.h | 2 -
> kernel/resource.c | 96 ++++++++++++++++++------------------------
> 2 files changed, 43 insertions(+), 55 deletions(-)
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
WARNING: multiple messages have this Message-ID (diff)
From: lijiang <lijiang@redhat.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: thomas.lendacky@amd.com, brijesh.singh@amd.com,
akpm@linux-foundation.org, bhe@redhat.com, tiwai@suse.de,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
baiyaowei@cmss.chinamobile.com, hpa@zytor.com,
dan.j.williams@intel.com, bp@suse.de, dyoung@redhat.com,
tglx@linutronix.de, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 0/3] find_next_iomem_res() fixes
Date: Wed, 26 Sep 2018 17:22:55 +0800 [thread overview]
Message-ID: <1894f2ba-42ab-c044-ea0c-63eab98d9815@redhat.com> (raw)
In-Reply-To: <153782698067.130337.12079523922130875402.stgit@bhelgaas-glaptop.roam.corp.google.com>
在 2018年09月25日 06:14, Bjorn Helgaas 写道:
> Hi Lianbo,
>
> These three patches are a possible replacement for your first patch
> ("[PATCH 1/3 v3] resource: fix an error which walks through iomem
> resources").
>
> I think the interface of find_next_iomem_res() can be improved to make
> the code easier to read and also avoid the errors you're fixing.
>
> I can't test these, so they've only been compiled. If you can test
> them and if you like them, feel free to incorporate them into your
> series. If not, just drop them (but please at least fix the same
> error in walk_system_ram_range()).
>
Hi, Bjorn
Sorry for my late reply about this. No need to incorporate them into
my patch series, you might freely submit them to upstream.
I will test your patches whether it can also work well for my case, and
you will get feedback about my test later.
Thanks.
Lianbo
> ---
>
> Bjorn Helgaas (3):
> x86/kexec: Correct KEXEC_BACKUP_SRC_END off-by-one error
> resource: Include resource end in walk_*() interfaces
> resource: Fix find_next_iomem_res() iteration issue
>
>
> arch/x86/include/asm/kexec.h | 2 -
> kernel/resource.c | 96 ++++++++++++++++++------------------------
> 2 files changed, 43 insertions(+), 55 deletions(-)
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2018-09-26 9:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 7:32 [PATCH 0/3 v3] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2018-09-21 7:32 ` Lianbo Jiang
2018-09-21 7:32 ` [PATCH 1/3 v3] resource: fix an error which walks through iomem resources Lianbo Jiang
2018-09-21 7:32 ` Lianbo Jiang
2018-09-24 17:52 ` Bjorn Helgaas
2018-09-24 17:52 ` Bjorn Helgaas
2018-09-25 7:08 ` lijiang
2018-09-25 7:08 ` lijiang
2018-09-24 22:14 ` [PATCH 0/3] find_next_iomem_res() fixes Bjorn Helgaas
2018-09-24 22:14 ` Bjorn Helgaas
2018-09-24 22:14 ` [PATCH 1/3] x86/kexec: Correct KEXEC_BACKUP_SRC_END off-by-one error Bjorn Helgaas
2018-09-24 22:14 ` Bjorn Helgaas
2018-09-24 22:14 ` [PATCH 2/3] resource: Include resource end in walk_*() interfaces Bjorn Helgaas
2018-09-24 22:14 ` Bjorn Helgaas
2018-09-24 22:15 ` [PATCH 3/3] resource: Fix find_next_iomem_res() iteration issue Bjorn Helgaas
2018-09-24 22:15 ` Bjorn Helgaas
2018-09-25 8:58 ` Baoquan He
2018-09-25 8:58 ` Baoquan He
2018-09-25 11:20 ` Baoquan He
2018-09-25 11:20 ` Baoquan He
2018-09-27 5:27 ` lijiang
2018-09-27 5:27 ` lijiang
2018-09-27 14:03 ` Bjorn Helgaas
2018-09-27 14:03 ` Bjorn Helgaas
2018-09-28 5:09 ` lijiang
2018-09-28 5:09 ` lijiang
2018-09-28 13:10 ` Borislav Petkov
2018-09-28 13:10 ` Borislav Petkov
2018-09-26 9:22 ` lijiang [this message]
2018-09-26 9:22 ` [PATCH 0/3] find_next_iomem_res() fixes lijiang
2018-09-26 13:36 ` lijiang
2018-09-26 13:36 ` lijiang
2018-09-21 7:32 ` [PATCH 2/3 v3] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name Lianbo Jiang
2018-09-21 7:32 ` Lianbo Jiang
2018-09-21 7:32 ` [PATCH 3/3 v3] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
2018-09-21 7:32 ` Lianbo Jiang
2018-10-16 2:56 ` [PATCH 0/3 v3] add reserved e820 ranges to the " Dave Young
2018-10-16 2:56 ` Dave Young
2018-10-16 3:45 ` lijiang
2018-10-16 3:45 ` lijiang
2018-09-27 14:21 [PATCH 0/3] find_next_iomem_res() fixes Bjorn Helgaas
2018-09-27 14:21 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1894f2ba-42ab-c044-ea0c-63eab98d9815@redhat.com \
--to=lijiang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=bhe@redhat.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dyoung@redhat.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tiwai@suse.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.