From: Michal Simek <michal.simek@xilinx.com> To: Rob Herring <robh@kernel.org>, Michal Simek <michal.simek@xilinx.com> Cc: <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>, <git@xilinx.com>, Piyush Mehta <piyush.mehta@xilinx.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-usb@vger.kernel.org> Subject: Re: [PATCH v2 1/2] dt-bindings: usb: misc: Add binding for Microchip usb5744 hub Date: Thu, 11 Feb 2021 10:35:19 +0100 [thread overview] Message-ID: <584bfee2-17a6-5935-b61c-b49824bcf857@xilinx.com> (raw) In-Reply-To: <20210210222241.GA2901449@robh.at.kernel.org> Hi Rob, On 2/10/21 11:22 PM, Rob Herring wrote: > On Tue, Feb 09, 2021 at 11:48:09AM +0100, Michal Simek wrote: >> From: Piyush Mehta <piyush.mehta@xilinx.com> >> >> Added dt binding for usb5744 driver. >> >> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> Changes in v2: None >> >> .../bindings/usb/microchip,usb5744.yaml | 56 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 57 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/usb/microchip,usb5744.yaml >> >> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml >> new file mode 100644 >> index 000000000000..fe222f6db81d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/usb/microchip,usb5744.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Bindings for the Microchip USB5744 4-port Hub Controller >> + >> +description: >> + Microchip’s USB5744 SmartHub™ IC is a 4 port, SuperSpeed (SS)/Hi-Speed (HS), >> + low power, low pin count configurable and fully compliant with the USB 3.1 >> + Gen 1 specification. The USB5744 also supports Full Speed (FS) and Low Speed >> + (LS) USB signaling, offering complete coverage of all defined USB operating >> + speeds. The new SuperSpeed hubs operate in parallel with the USB 2.0 >> + controller, so 5 Gbps SuperSpeed data transfers are not affected by slower >> + USB 2.0 traffic. >> + >> +maintainers: >> + - Piyush Mehta <piyush.mehta@xilinx.com> >> + - Michal Simek <michal.simek@xilinx.com> >> + >> +properties: >> + compatible: >> + const: microchip,usb5744 >> + >> + reg: >> + maxItems: 1 >> + description: | >> + Specifies the i2c slave address, it is required and should be 0x2d >> + if I2C is used. > > If I2C is not used, then this should be underneath the USB host as a USB > device. That also implies a different compatible string. I'd suggest you > just say I2C is required if that's your use. We can't say that i2c is required because we have both cases. One is really usb hub connected over i2c which at least requires to send one smbus command to start operate. But it can be extended to add more features - limit speeds, disable ports, etc. And the second is really the same usb hub without i2c connected which runs in default mode. But reset is required to ensure proper reset sequence. Hub also have external clock chip which is not handled now because it is just crystal on the board but if you want I can also model it via fixed clock and call clock enable for it. It is the same use case as is with Documentation/devicetree/bindings/usb/usb3503.txt Can you please elaborate why different compatible string should be used? It is still the same device and not quite sure why different compatible string should be used. Do you also want to example where this node is the part of usb node? > > 'const: 0x2d' instead of maxItems is the schema to express the address > if fixed. Will fix. Thanks, Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com> To: Rob Herring <robh@kernel.org>, Michal Simek <michal.simek@xilinx.com> Cc: devicetree@vger.kernel.org, monstr@monstr.eu, Piyush Mehta <piyush.mehta@xilinx.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, git@xilinx.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] dt-bindings: usb: misc: Add binding for Microchip usb5744 hub Date: Thu, 11 Feb 2021 10:35:19 +0100 [thread overview] Message-ID: <584bfee2-17a6-5935-b61c-b49824bcf857@xilinx.com> (raw) In-Reply-To: <20210210222241.GA2901449@robh.at.kernel.org> Hi Rob, On 2/10/21 11:22 PM, Rob Herring wrote: > On Tue, Feb 09, 2021 at 11:48:09AM +0100, Michal Simek wrote: >> From: Piyush Mehta <piyush.mehta@xilinx.com> >> >> Added dt binding for usb5744 driver. >> >> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> Changes in v2: None >> >> .../bindings/usb/microchip,usb5744.yaml | 56 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 57 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/usb/microchip,usb5744.yaml >> >> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml >> new file mode 100644 >> index 000000000000..fe222f6db81d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/usb/microchip,usb5744.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Bindings for the Microchip USB5744 4-port Hub Controller >> + >> +description: >> + Microchip’s USB5744 SmartHub™ IC is a 4 port, SuperSpeed (SS)/Hi-Speed (HS), >> + low power, low pin count configurable and fully compliant with the USB 3.1 >> + Gen 1 specification. The USB5744 also supports Full Speed (FS) and Low Speed >> + (LS) USB signaling, offering complete coverage of all defined USB operating >> + speeds. The new SuperSpeed hubs operate in parallel with the USB 2.0 >> + controller, so 5 Gbps SuperSpeed data transfers are not affected by slower >> + USB 2.0 traffic. >> + >> +maintainers: >> + - Piyush Mehta <piyush.mehta@xilinx.com> >> + - Michal Simek <michal.simek@xilinx.com> >> + >> +properties: >> + compatible: >> + const: microchip,usb5744 >> + >> + reg: >> + maxItems: 1 >> + description: | >> + Specifies the i2c slave address, it is required and should be 0x2d >> + if I2C is used. > > If I2C is not used, then this should be underneath the USB host as a USB > device. That also implies a different compatible string. I'd suggest you > just say I2C is required if that's your use. We can't say that i2c is required because we have both cases. One is really usb hub connected over i2c which at least requires to send one smbus command to start operate. But it can be extended to add more features - limit speeds, disable ports, etc. And the second is really the same usb hub without i2c connected which runs in default mode. But reset is required to ensure proper reset sequence. Hub also have external clock chip which is not handled now because it is just crystal on the board but if you want I can also model it via fixed clock and call clock enable for it. It is the same use case as is with Documentation/devicetree/bindings/usb/usb3503.txt Can you please elaborate why different compatible string should be used? It is still the same device and not quite sure why different compatible string should be used. Do you also want to example where this node is the part of usb node? > > 'const: 0x2d' instead of maxItems is the schema to express the address > if fixed. Will fix. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-11 9:41 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-09 10:48 [PATCH v2 0/2] usb: misc: Add support for Microchip USB5744 Michal Simek 2021-02-09 10:48 ` Michal Simek 2021-02-09 10:48 ` [PATCH v2 1/2] dt-bindings: usb: misc: Add binding for Microchip usb5744 hub Michal Simek 2021-02-09 10:48 ` Michal Simek 2021-02-10 22:22 ` Rob Herring 2021-02-10 22:22 ` Rob Herring 2021-02-11 9:35 ` Michal Simek [this message] 2021-02-11 9:35 ` Michal Simek 2021-02-11 14:42 ` Rob Herring 2021-02-11 14:42 ` Rob Herring 2021-02-24 13:37 ` Michal Simek 2021-02-24 13:37 ` Michal Simek 2021-03-04 20:02 ` Rob Herring 2021-03-04 20:02 ` Rob Herring 2021-02-09 10:48 ` [PATCH v2 2/2] usb: misc: usb5744: Add support for USB hub controller Michal Simek 2021-02-09 10:48 ` Michal Simek 2021-02-09 11:20 ` Greg Kroah-Hartman 2021-02-09 11:20 ` Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=584bfee2-17a6-5935-b61c-b49824bcf857@xilinx.com \ --to=michal.simek@xilinx.com \ --cc=devicetree@vger.kernel.org \ --cc=git@xilinx.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=monstr@monstr.eu \ --cc=piyush.mehta@xilinx.com \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.