* [PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a
@ 2021-08-10 3:57 Guenter Roeck
2021-08-10 8:49 ` Cédric Le Goater
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2021-08-10 3:57 UTC (permalink / raw)
To: Cédric Le Goater
Cc: Peter Maydell, Andrew Jeffery, qemu-devel, qemu-arm,
Joel Stanley, Guenter Roeck
According to its dts file in the Linux kernel, we need mac0 and mac1 enabled
instead of mac1 and mac2. Also, g220a is based on aspeed-g5 (ast2500) which
doesn't even have the third interface.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
hw/arm/aspeed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index ecf0c9cfac..20e3a77160 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -997,7 +997,7 @@ static void aspeed_machine_g220a_class_init(ObjectClass *oc, void *data)
amc->fmc_model = "n25q512a";
amc->spi_model = "mx25l25635e";
amc->num_cs = 2;
- amc->macs_mask = ASPEED_MAC1_ON | ASPEED_MAC2_ON;
+ amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON;
amc->i2c_init = g220a_bmc_i2c_init;
mc->default_ram_size = 1024 * MiB;
mc->default_cpus = mc->min_cpus = mc->max_cpus =
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a
2021-08-10 3:57 [PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a Guenter Roeck
@ 2021-08-10 8:49 ` Cédric Le Goater
0 siblings, 0 replies; 2+ messages in thread
From: Cédric Le Goater @ 2021-08-10 8:49 UTC (permalink / raw)
To: Guenter Roeck
Cc: Peter Maydell, Andrew Jeffery, qemu-devel, qemu-arm,
Joel Stanley, John Wang
Cc: John Wang
On 8/10/21 5:57 AM, Guenter Roeck wrote:
> According to its dts file in the Linux kernel, we need mac0 and mac1 enabled
> instead of mac1 and mac2. Also, g220a is based on aspeed-g5 (ast2500) which
> doesn't even have the third interface.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> hw/arm/aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index ecf0c9cfac..20e3a77160 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -997,7 +997,7 @@ static void aspeed_machine_g220a_class_init(ObjectClass *oc, void *data)
> amc->fmc_model = "n25q512a";
> amc->spi_model = "mx25l25635e";
> amc->num_cs = 2;
> - amc->macs_mask = ASPEED_MAC1_ON | ASPEED_MAC2_ON;
> + amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON;
> amc->i2c_init = g220a_bmc_i2c_init;
> mc->default_ram_size = 1024 * MiB;
> mc->default_cpus = mc->min_cpus = mc->max_cpus =
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-10 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 3:57 [PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a Guenter Roeck
2021-08-10 8:49 ` Cédric Le Goater
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.