[PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a

[PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a

[Guenter Roeck]

According to its dts file in the Linux kernel, we need mac0 and mac1 enabled
instead of mac1 and mac2. Also, g220a is based on aspeed-g5 (ast2500) which
doesn't even have the third interface.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 hw/arm/aspeed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index ecf0c9cfac..20e3a77160 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -997,7 +997,7 @@ static void aspeed_machine_g220a_class_init(ObjectClass *oc, void *data)
     amc->fmc_model = "n25q512a";
     amc->spi_model = "mx25l25635e";
     amc->num_cs    = 2;
-    amc->macs_mask  = ASPEED_MAC1_ON | ASPEED_MAC2_ON;
+    amc->macs_mask  = ASPEED_MAC0_ON | ASPEED_MAC1_ON;
     amc->i2c_init  = g220a_bmc_i2c_init;
     mc->default_ram_size = 1024 * MiB;
     mc->default_cpus = mc->min_cpus = mc->max_cpus =
-- 
2.25.1

Re: [PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a

[Cédric Le Goater]

Cc: John Wang

On 8/10/21 5:57 AM, Guenter Roeck wrote:
> According to its dts file in the Linux kernel, we need mac0 and mac1 enabled
> instead of mac1 and mac2. Also, g220a is based on aspeed-g5 (ast2500) which
> doesn't even have the third interface.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>  hw/arm/aspeed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index ecf0c9cfac..20e3a77160 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -997,7 +997,7 @@ static void aspeed_machine_g220a_class_init(ObjectClass *oc, void *data)
>      amc->fmc_model = "n25q512a";
>      amc->spi_model = "mx25l25635e";
>      amc->num_cs    = 2;
> -    amc->macs_mask  = ASPEED_MAC1_ON | ASPEED_MAC2_ON;
> +    amc->macs_mask  = ASPEED_MAC0_ON | ASPEED_MAC1_ON;
>      amc->i2c_init  = g220a_bmc_i2c_init;
>      mc->default_ram_size = 1024 * MiB;
>      mc->default_cpus = mc->min_cpus = mc->max_cpus =
>