* [PATCH] omap-serial: Allow IXON and IXOFF to be disabled.
@ 2011-07-14 18:49 Nick Pelly
2011-07-15 5:37 ` Govindraj
0 siblings, 1 reply; 4+ messages in thread
From: Nick Pelly @ 2011-07-14 18:49 UTC (permalink / raw)
To: linux-omap; +Cc: Nick Pelly
Fixes logic bug that software flow control cannot be disabled, because
serial_omap_configure_xonxoff() is not called if both IXON and IXOFF bits
are cleared.
Signed-off-by: Nick Pelly <npelly@google.com>
---
drivers/tty/serial/omap-serial.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 47cadf4..6d3ec14 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -806,8 +806,7 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios,
serial_omap_set_mctrl(&up->port, up->port.mctrl);
/* Software Flow Control Configuration */
- if (termios->c_iflag & (IXON | IXOFF))
- serial_omap_configure_xonxoff(up, termios);
+ serial_omap_configure_xonxoff(up, termios);
spin_unlock_irqrestore(&up->port.lock, flags);
dev_dbg(up->port.dev, "serial_omap_set_termios+%d\n", up->pdev->id);
--
1.7.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] omap-serial: Allow IXON and IXOFF to be disabled.
2011-07-14 18:49 [PATCH] omap-serial: Allow IXON and IXOFF to be disabled Nick Pelly
@ 2011-07-15 5:37 ` Govindraj
2011-07-18 23:09 ` Nick Pelly
0 siblings, 1 reply; 4+ messages in thread
From: Govindraj @ 2011-07-15 5:37 UTC (permalink / raw)
To: Nick Pelly; +Cc: linux-omap
On Fri, Jul 15, 2011 at 12:19 AM, Nick Pelly <npelly@google.com> wrote:
> Fixes logic bug that software flow control cannot be disabled, because
> serial_omap_configure_xonxoff() is not called if both IXON and IXOFF bits
> are cleared.
>
Thanks, Good Point.
need to send to this patch to linux-serial@vger.kernel.org,
CC'ing "Greg Kroah-Hartman <gregkh@suse.de>"
will be merged through tty tree.
feel free to add
Acked-by: Govindraj.R <govindraj.raja@ti.com>
Tested-by: Govindraj.R <govindraj.raja@ti.com>
--
Thanks,
Govindraj.R
> Signed-off-by: Nick Pelly <npelly@google.com>
> ---
> drivers/tty/serial/omap-serial.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 47cadf4..6d3ec14 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -806,8 +806,7 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios,
>
> serial_omap_set_mctrl(&up->port, up->port.mctrl);
> /* Software Flow Control Configuration */
> - if (termios->c_iflag & (IXON | IXOFF))
> - serial_omap_configure_xonxoff(up, termios);
> + serial_omap_configure_xonxoff(up, termios);
>
> spin_unlock_irqrestore(&up->port.lock, flags);
> dev_dbg(up->port.dev, "serial_omap_set_termios+%d\n", up->pdev->id);
> --
> 1.7.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] omap-serial: Allow IXON and IXOFF to be disabled.
2011-07-15 5:37 ` Govindraj
@ 2011-07-18 23:09 ` Nick Pelly
0 siblings, 0 replies; 4+ messages in thread
From: Nick Pelly @ 2011-07-18 23:09 UTC (permalink / raw)
To: Govindraj; +Cc: linux-omap
On Thu, Jul 14, 2011 at 10:37 PM, Govindraj <govindraj.ti@gmail.com> wrote:
>
> On Fri, Jul 15, 2011 at 12:19 AM, Nick Pelly <npelly@google.com> wrote:
> > Fixes logic bug that software flow control cannot be disabled, because
> > serial_omap_configure_xonxoff() is not called if both IXON and IXOFF bits
> > are cleared.
> >
>
> Thanks, Good Point.
>
> need to send to this patch to linux-serial@vger.kernel.org,
> CC'ing "Greg Kroah-Hartman <gregkh@suse.de>"
>
> will be merged through tty tree.
>
> feel free to add
>
> Acked-by: Govindraj.R <govindraj.raja@ti.com>
> Tested-by: Govindraj.R <govindraj.raja@ti.com>
Done.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] omap-serial: Allow IXON and IXOFF to be disabled.
@ 2011-07-15 20:53 Nick Pelly
0 siblings, 0 replies; 4+ messages in thread
From: Nick Pelly @ 2011-07-15 20:53 UTC (permalink / raw)
To: linux-serial; +Cc: Greg Kroah-Hartman, Nick Pelly
Fixes logic bug that software flow control cannot be disabled, because
serial_omap_configure_xonxoff() is not called if both IXON and IXOFF bits
are cleared.
Signed-off-by: Nick Pelly <npelly@google.com>
Acked-by: Govindraj.R <govindraj.raja@ti.com>
Tested-by: Govindraj.R <govindraj.raja@ti.com>
---
drivers/tty/serial/omap-serial.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 0275c28..4ca2c5f 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -806,8 +806,7 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios,
serial_omap_set_mctrl(&up->port, up->port.mctrl);
/* Software Flow Control Configuration */
- if (termios->c_iflag & (IXON | IXOFF))
- serial_omap_configure_xonxoff(up, termios);
+ serial_omap_configure_xonxoff(up, termios);
spin_unlock_irqrestore(&up->port.lock, flags);
dev_dbg(up->port.dev, "serial_omap_set_termios+%d\n", up->pdev->id);
--
1.7.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-18 23:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-14 18:49 [PATCH] omap-serial: Allow IXON and IXOFF to be disabled Nick Pelly
2011-07-15 5:37 ` Govindraj
2011-07-18 23:09 ` Nick Pelly
2011-07-15 20:53 Nick Pelly
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.