[PATCH] omap-serial: Allow IXON and IXOFF to be disabled.

[PATCH] omap-serial: Allow IXON and IXOFF to be disabled.

[Nick Pelly]

Fixes logic bug that software flow control cannot be disabled, because
serial_omap_configure_xonxoff() is not called if both IXON and IXOFF bits
are cleared.

Signed-off-by: Nick Pelly <npelly@google.com>
---
 drivers/tty/serial/omap-serial.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 47cadf4..6d3ec14 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -806,8 +806,7 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios,
 
 	serial_omap_set_mctrl(&up->port, up->port.mctrl);
 	/* Software Flow Control Configuration */
-	if (termios->c_iflag & (IXON | IXOFF))
-		serial_omap_configure_xonxoff(up, termios);
+	serial_omap_configure_xonxoff(up, termios);
 
 	spin_unlock_irqrestore(&up->port.lock, flags);
 	dev_dbg(up->port.dev, "serial_omap_set_termios+%d\n", up->pdev->id);
-- 
1.7.5.2

Re: [PATCH] omap-serial: Allow IXON and IXOFF to be disabled.

[Govindraj]

On Fri, Jul 15, 2011 at 12:19 AM, Nick Pelly <npelly@google.com> wrote:
> Fixes logic bug that software flow control cannot be disabled, because
> serial_omap_configure_xonxoff() is not called if both IXON and IXOFF bits
> are cleared.
>

Thanks, Good Point.

need to send to this patch to linux-serial@vger.kernel.org,
CC'ing "Greg Kroah-Hartman <gregkh@suse.de>"

will be merged through tty tree.

feel free to add

Acked-by: Govindraj.R <govindraj.raja@ti.com>
Tested-by: Govindraj.R <govindraj.raja@ti.com>

--
Thanks,
Govindraj.R

> Signed-off-by: Nick Pelly <npelly@google.com>
> ---
>  drivers/tty/serial/omap-serial.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 47cadf4..6d3ec14 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -806,8 +806,7 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios,
>
>        serial_omap_set_mctrl(&up->port, up->port.mctrl);
>        /* Software Flow Control Configuration */
> -       if (termios->c_iflag & (IXON | IXOFF))
> -               serial_omap_configure_xonxoff(up, termios);
> +       serial_omap_configure_xonxoff(up, termios);
>
>        spin_unlock_irqrestore(&up->port.lock, flags);
>        dev_dbg(up->port.dev, "serial_omap_set_termios+%d\n", up->pdev->id);
> --
> 1.7.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] omap-serial: Allow IXON and IXOFF to be disabled.

[Nick Pelly]

On Thu, Jul 14, 2011 at 10:37 PM, Govindraj <govindraj.ti@gmail.com> wrote:
>
> On Fri, Jul 15, 2011 at 12:19 AM, Nick Pelly <npelly@google.com> wrote:
> > Fixes logic bug that software flow control cannot be disabled, because
> > serial_omap_configure_xonxoff() is not called if both IXON and IXOFF bits
> > are cleared.
> >
>
> Thanks, Good Point.
>
> need to send to this patch to linux-serial@vger.kernel.org,
> CC'ing "Greg Kroah-Hartman <gregkh@suse.de>"
>
> will be merged through tty tree.
>
> feel free to add
>
> Acked-by: Govindraj.R <govindraj.raja@ti.com>
> Tested-by: Govindraj.R <govindraj.raja@ti.com>

Done.

[PATCH] omap-serial: Allow IXON and IXOFF to be disabled.

[Nick Pelly]

Fixes logic bug that software flow control cannot be disabled, because
serial_omap_configure_xonxoff() is not called if both IXON and IXOFF bits
are cleared.

Signed-off-by: Nick Pelly <npelly@google.com>
Acked-by: Govindraj.R <govindraj.raja@ti.com>
Tested-by: Govindraj.R <govindraj.raja@ti.com>
---
 drivers/tty/serial/omap-serial.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 0275c28..4ca2c5f 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -806,8 +806,7 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios,
 
 	serial_omap_set_mctrl(&up->port, up->port.mctrl);
 	/* Software Flow Control Configuration */
-	if (termios->c_iflag & (IXON | IXOFF))
-		serial_omap_configure_xonxoff(up, termios);
+	serial_omap_configure_xonxoff(up, termios);
 
 	spin_unlock_irqrestore(&up->port.lock, flags);
 	dev_dbg(up->port.dev, "serial_omap_set_termios+%d\n", up->pdev->id);
-- 
1.7.5.2