Re: [PATCH 1 of 3 v5/leftover] libxl: enable automatic placement of guests on NUMA nodes

From: Dario Faggioli <raistlin@linux.it>
To: Andre Przywara <andre.przywara@amd.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Juergen Gross <juergen.gross@ts.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1 of 3 v5/leftover] libxl: enable automatic placement of guests on NUMA nodes
Date: Fri, 20 Jul 2012 14:54:50 +0200	[thread overview]
Message-ID: <1342788890.19530.319.camel@Solace> (raw)
In-Reply-To: <50094557.8020208@amd.com>

[-- Attachment #1.1: Type: text/plain, Size: 1395 bytes --]

On Fri, 2012-07-20 at 13:47 +0200, Andre Przywara wrote:
> > That would be nice. If you happen to have time to put something like
> > "3*nrdomains_diff+memfree_diff" and see how it goes, I'll be happy to
> > include at least that change, even in next posting.
> 
> I did that. Guests are 2 VCPUs/2GB RAM. 
>
Thanks!

> The results looked much better. 
>
That's very good to hear. :-)

>
> [snip]
>
> So without any deeper thinking this looks much better than the original 
> version and possibly good enough for Xen 4.2.
> Maybe the automated testing finds some leftovers.
> 
So, here's what we can do:

 1) I can resend the series with this change in it (i.e., number of 
   domains weighting 3 times more than free memory);

 2) I can resend the series like in 1) _but_ while also converting the 
   domain counting in vcpu counting (I checked that and it's trivial);

 3) I can resend the series like in 1) and also send a separate patch 
   turning the domain counting in vcpu counting, and we can apply that 
   after it get some testing;

Which one you like better?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel