All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 1/7] [media] timberdale: do not select TIMB_DMA
Date: Wed, 28 Jan 2015 22:17:41 +0100	[thread overview]
Message-ID: <1422479867-3370921-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1422479867-3370921-1-git-send-email-arnd@arndb.de>

The timberdale media driver requires the use of the respective
dma engine driver, but that may not be enabled, causing a
Kconfig warning:

warning: (VIDEO_TIMBERDALE) selects TIMB_DMA which has unmet direct dependencies (DMADEVICES && MFD_TIMBERDALE)

This fixes the dependency by removing the inappropriate 'select'
statement and replacing it with a direct dependency on the
drivers that provide the services this needs.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7155043c2d027 ("[media] enable COMPILE_TEST for media drivers")
---
 drivers/media/platform/Kconfig | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 765bffb49a72..6a1334be7544 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -56,10 +56,8 @@ config VIDEO_VIU
 
 config VIDEO_TIMBERDALE
 	tristate "Support for timberdale Video In/LogiWIN"
-	depends on VIDEO_V4L2 && I2C && DMADEVICES
-	depends on MFD_TIMBERDALE || COMPILE_TEST
-	select DMA_ENGINE
-	select TIMB_DMA
+	depends on VIDEO_V4L2 && I2C
+	depends on (MFD_TIMBERDALE && TIMB_DMA) || COMPILE_TEST
 	select VIDEO_ADV7180
 	select VIDEOBUF_DMA_CONTIG
 	---help---
-- 
2.1.0.rc2


WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] [media] timberdale: do not select TIMB_DMA
Date: Wed, 28 Jan 2015 22:17:41 +0100	[thread overview]
Message-ID: <1422479867-3370921-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1422479867-3370921-1-git-send-email-arnd@arndb.de>

The timberdale media driver requires the use of the respective
dma engine driver, but that may not be enabled, causing a
Kconfig warning:

warning: (VIDEO_TIMBERDALE) selects TIMB_DMA which has unmet direct dependencies (DMADEVICES && MFD_TIMBERDALE)

This fixes the dependency by removing the inappropriate 'select'
statement and replacing it with a direct dependency on the
drivers that provide the services this needs.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7155043c2d027 ("[media] enable COMPILE_TEST for media drivers")
---
 drivers/media/platform/Kconfig | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 765bffb49a72..6a1334be7544 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -56,10 +56,8 @@ config VIDEO_VIU
 
 config VIDEO_TIMBERDALE
 	tristate "Support for timberdale Video In/LogiWIN"
-	depends on VIDEO_V4L2 && I2C && DMADEVICES
-	depends on MFD_TIMBERDALE || COMPILE_TEST
-	select DMA_ENGINE
-	select TIMB_DMA
+	depends on VIDEO_V4L2 && I2C
+	depends on (MFD_TIMBERDALE && TIMB_DMA) || COMPILE_TEST
 	select VIDEO_ADV7180
 	select VIDEOBUF_DMA_CONTIG
 	---help---
-- 
2.1.0.rc2

  reply	other threads:[~2015-01-29  1:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 21:17 [PATCH 0/7] [media] ARM randconfig fixes Arnd Bergmann
2015-01-28 21:17 ` Arnd Bergmann
2015-01-28 21:17 ` Arnd Bergmann [this message]
2015-01-28 21:17   ` [PATCH 1/7] [media] timberdale: do not select TIMB_DMA Arnd Bergmann
2015-01-28 21:17 ` [PATCH 2/7] [media] radio/aimslab: use mdelay instead of udelay Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 3/7] [media] staging/davinci/vpfe/dm365: add missing dependencies Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-29 10:26   ` Lad, Prabhakar
2015-01-29 10:26     ` Lad, Prabhakar
2015-01-28 21:17 ` [PATCH 4/7] [media] siano: fix Kconfig dependencies Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 5/7] [media] gspca: add INPUT dependency Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 6/7] [media] marvell-ccic: MMP_CAMERA never worked Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:57   ` Jonathan Corbet
2015-01-28 21:57     ` Jonathan Corbet
2015-01-28 22:11   ` [PATCH v2 6/7] [media] marvell-ccic: MMP_CAMERA no longer builds Arnd Bergmann
2015-01-28 22:11     ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 7/7] [media] marvell-ccic needs VIDEOBUF2_DMA_SG Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:58   ` Jonathan Corbet
2015-01-28 21:58     ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422479867-3370921-2-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.