All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH 5/7] [media] gspca: add INPUT dependency
Date: Wed, 28 Jan 2015 22:17:45 +0100	[thread overview]
Message-ID: <1422479867-3370921-6-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1422479867-3370921-1-git-send-email-arnd@arndb.de>

The gspca  driver uses the input_event infrastructure and fails
to link if that is not available:

drivers/built-in.o: In function `gspca_disconnect':
media/usb/gspca/gspca.c:2171: undefined reference to `input_unregister_device'
drivers/built-in.o: In function `gspca_dev_probe2':
media/usb/gspca/gspca.c:2112: undefined reference to `input_allocate_device'
media/usb/gspca/gspca.c:2112: undefined reference to `input_register_device'
media/usb/gspca/gspca.c:2112: undefined reference to `input_unregister_device'
media/usb/gspca/gspca.c:2112: undefined reference to `input_free_device'
drivers/built-in.o: In function `sd_int_pkt_scan':
media/usb/gspca/pac207.c:428: undefined reference to `input_event'
drivers/built-in.o: In function `sd_int_pkt_scan':
media/usb/gspca/pac7302.c:879: undefined reference to `input_event'
drivers/built-in.o: In function `sd_int_pkt_scan':
media/usb/gspca/se401.c:612: undefined reference to `input_event'
drivers/built-in.o: In function `sd_stop0':
media/usb/gspca/xirlink_cit.c:2742: undefined reference to `input_event'
drivers/built-in.o: In function `cit_check_button':
media/usb/gspca/xirlink_cit.c:2935: undefined reference to `input_event'
drivers/built-in.o:/git/arm-soc/include/linux/input.h:414: more undefined references to `input_event' follow

This adds an explicit dependency.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Hans de Goede <hdegoede@redhat.com>
---
 drivers/media/usb/gspca/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/usb/gspca/Kconfig b/drivers/media/usb/gspca/Kconfig
index eed10d782535..2b23aad5a9f2 100644
--- a/drivers/media/usb/gspca/Kconfig
+++ b/drivers/media/usb/gspca/Kconfig
@@ -1,6 +1,7 @@
 menuconfig USB_GSPCA
 	tristate "GSPCA based webcams"
 	depends on VIDEO_V4L2
+	depends on INPUT
 	default m
 	---help---
 	  Say Y here if you want to enable selecting webcams based
-- 
2.1.0.rc2


WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] [media] gspca: add INPUT dependency
Date: Wed, 28 Jan 2015 22:17:45 +0100	[thread overview]
Message-ID: <1422479867-3370921-6-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1422479867-3370921-1-git-send-email-arnd@arndb.de>

The gspca  driver uses the input_event infrastructure and fails
to link if that is not available:

drivers/built-in.o: In function `gspca_disconnect':
media/usb/gspca/gspca.c:2171: undefined reference to `input_unregister_device'
drivers/built-in.o: In function `gspca_dev_probe2':
media/usb/gspca/gspca.c:2112: undefined reference to `input_allocate_device'
media/usb/gspca/gspca.c:2112: undefined reference to `input_register_device'
media/usb/gspca/gspca.c:2112: undefined reference to `input_unregister_device'
media/usb/gspca/gspca.c:2112: undefined reference to `input_free_device'
drivers/built-in.o: In function `sd_int_pkt_scan':
media/usb/gspca/pac207.c:428: undefined reference to `input_event'
drivers/built-in.o: In function `sd_int_pkt_scan':
media/usb/gspca/pac7302.c:879: undefined reference to `input_event'
drivers/built-in.o: In function `sd_int_pkt_scan':
media/usb/gspca/se401.c:612: undefined reference to `input_event'
drivers/built-in.o: In function `sd_stop0':
media/usb/gspca/xirlink_cit.c:2742: undefined reference to `input_event'
drivers/built-in.o: In function `cit_check_button':
media/usb/gspca/xirlink_cit.c:2935: undefined reference to `input_event'
drivers/built-in.o:/git/arm-soc/include/linux/input.h:414: more undefined references to `input_event' follow

This adds an explicit dependency.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Hans de Goede <hdegoede@redhat.com>
---
 drivers/media/usb/gspca/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/usb/gspca/Kconfig b/drivers/media/usb/gspca/Kconfig
index eed10d782535..2b23aad5a9f2 100644
--- a/drivers/media/usb/gspca/Kconfig
+++ b/drivers/media/usb/gspca/Kconfig
@@ -1,6 +1,7 @@
 menuconfig USB_GSPCA
 	tristate "GSPCA based webcams"
 	depends on VIDEO_V4L2
+	depends on INPUT
 	default m
 	---help---
 	  Say Y here if you want to enable selecting webcams based
-- 
2.1.0.rc2

  parent reply	other threads:[~2015-01-29  2:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 21:17 [PATCH 0/7] [media] ARM randconfig fixes Arnd Bergmann
2015-01-28 21:17 ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 1/7] [media] timberdale: do not select TIMB_DMA Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 2/7] [media] radio/aimslab: use mdelay instead of udelay Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 3/7] [media] staging/davinci/vpfe/dm365: add missing dependencies Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-29 10:26   ` Lad, Prabhakar
2015-01-29 10:26     ` Lad, Prabhakar
2015-01-28 21:17 ` [PATCH 4/7] [media] siano: fix Kconfig dependencies Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` Arnd Bergmann [this message]
2015-01-28 21:17   ` [PATCH 5/7] [media] gspca: add INPUT dependency Arnd Bergmann
2015-01-28 21:17 ` [PATCH 6/7] [media] marvell-ccic: MMP_CAMERA never worked Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:57   ` Jonathan Corbet
2015-01-28 21:57     ` Jonathan Corbet
2015-01-28 22:11   ` [PATCH v2 6/7] [media] marvell-ccic: MMP_CAMERA no longer builds Arnd Bergmann
2015-01-28 22:11     ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 7/7] [media] marvell-ccic needs VIDEOBUF2_DMA_SG Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:58   ` Jonathan Corbet
2015-01-28 21:58     ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422479867-3370921-6-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.