* [U-Boot] regression: setting the rpi mac address stopped working
@ 2017-03-27 8:24 Gerd Hoffmann
2017-04-01 4:22 ` Simon Glass
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2017-03-27 8:24 UTC (permalink / raw)
To: u-boot
Hi,
u-boot 2016.11 & newer doesn't set the mac address on my raspberry pi
any more, so the linux kernel picks a random mac address. Bisected to
this commit:
commit b91c6a1209e7da1a7f989d9ac35d0d8be0b7b710
Author: Simon Glass <sjg@chromium.org>
Date: Wed Oct 5 20:42:11 2016 -0600
Fix return value in trailing_strtoln()
This function should return -1 if there is no trailing integer
in the string. Instead it returns 0. Fix it by checking for this
condition at the start.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Appearently this change broke fdt_fixup_ethernet().
cheers,
Gerd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] regression: setting the rpi mac address stopped working
2017-03-27 8:24 [U-Boot] regression: setting the rpi mac address stopped working Gerd Hoffmann
@ 2017-04-01 4:22 ` Simon Glass
2017-04-01 14:49 ` Tuomas Tynkkynen
0 siblings, 1 reply; 5+ messages in thread
From: Simon Glass @ 2017-04-01 4:22 UTC (permalink / raw)
To: u-boot
Hi,
On 27 March 2017 at 02:24, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> u-boot 2016.11 & newer doesn't set the mac address on my raspberry pi
> any more, so the linux kernel picks a random mac address. Bisected to
> this commit:
>
> commit b91c6a1209e7da1a7f989d9ac35d0d8be0b7b710
> Author: Simon Glass <sjg@chromium.org>
> Date: Wed Oct 5 20:42:11 2016 -0600
>
> Fix return value in trailing_strtoln()
>
> This function should return -1 if there is no trailing integer
> in the string. Instead it returns 0. Fix it by checking for this
> condition at the start.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> Appearently this change broke fdt_fixup_ethernet().
I'm sorry to hear that. Any change you have a patch? It looks like the
latter code was relying on the bad behaviour?
Regards,
Simon
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] regression: setting the rpi mac address stopped working
2017-04-01 4:22 ` Simon Glass
@ 2017-04-01 14:49 ` Tuomas Tynkkynen
2017-04-24 12:12 ` Gerd Hoffmann
0 siblings, 1 reply; 5+ messages in thread
From: Tuomas Tynkkynen @ 2017-04-01 14:49 UTC (permalink / raw)
To: u-boot
Hi Simon, Gerd
On Fri, 31 Mar 2017 22:22:52 -0600
Simon Glass <sjg@chromium.org> wrote:
> Hi,
>
> On 27 March 2017 at 02:24, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Hi,
> >
> > u-boot 2016.11 & newer doesn't set the mac address on my raspberry pi
> > any more, so the linux kernel picks a random mac address. Bisected to
> > this commit:
> >
> > commit b91c6a1209e7da1a7f989d9ac35d0d8be0b7b710
> > Author: Simon Glass <sjg@chromium.org>
> > Date: Wed Oct 5 20:42:11 2016 -0600
> >
> > Fix return value in trailing_strtoln()
> >
> > This function should return -1 if there is no trailing integer
> > in the string. Instead it returns 0. Fix it by checking for this
> > condition at the start.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > Appearently this change broke fdt_fixup_ethernet().
>
> I'm sorry to hear that. Any change you have a patch? It looks like the
> latter code was relying on the bad behaviour?
>
https://www.mail-archive.com/u-boot at lists.denx.de/msg241949.html fixes this
problem.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-26 19:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-27 8:24 [U-Boot] regression: setting the rpi mac address stopped working Gerd Hoffmann
2017-04-01 4:22 ` Simon Glass
2017-04-01 14:49 ` Tuomas Tynkkynen
2017-04-24 12:12 ` Gerd Hoffmann
2017-04-26 19:30 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.