From: Bart Van Assche <Bart.VanAssche@wdc.com> To: "snitzer@redhat.com" <snitzer@redhat.com> Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>, "hch@infradead.org" <hch@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "osandov@fb.com" <osandov@fb.com>, "ming.lei@redhat.com" <ming.lei@redhat.com>, "axboe@kernel.dk" <axboe@kernel.dk> Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Date: Thu, 18 Jan 2018 18:47:59 +0000 [thread overview] Message-ID: <1516301278.2676.35.camel@wdc.com> (raw) In-Reply-To: <20180118183039.GA20121@redhat.com> T24gVGh1LCAyMDE4LTAxLTE4IGF0IDEzOjMwIC0wNTAwLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+ IDElIT8gIFdoZXJlIGFyZSB5b3UgZ2V0dGluZyB0aGF0IG51bWJlcj8gIE1pbmcgaGFzIGRldGFp bGVkIG1vcmUNCj4gc2lnbmlmaWNhbnQgcGVyZm9ybWFuY2UgZ2FpbnMgdGhhbiAxJS4uIGFuZCBu b3QganVzdCBvbiBscGZjICh0aG91Z2ggeW91DQo+IGtlZXAgc2VpemluZyBvbiBscGZjIGJlY2F1 c2Ugb2YgdGhlIGxvdyBxdWV1ZV9kZXB0aCBvZiAzKS4NCg0KVGhhdCdzIHdoYXQgSSBkZXJpdmVk IGZyb20gdGhlIG51bWJlcnMgeW91IHBvc3RlZCBmb3IgbnVsbF9ibGsuIElmIE1pbmcgaGFzDQpw b3N0ZWQgcGVyZm9ybWFuY2UgcmVzdWx0cyBmb3Igb3RoZXIgZHJpdmVycyB0aGFuIGxwZmMsIHBs ZWFzZSBsZXQgbWUga25vdw0Kd2hlcmUgSSBjYW4gZmluZCB0aGVzZS4gSSBoYXZlIG5vdCB5ZXQg c2VlbiB0aGVzZSBudW1iZXJzLg0KDQo+IFRoaXMgaXMgYWxsIHZlcnkgdGlyZXNvbWUuDQoNClll cywgdGhpcyBpcyB0aXJlc29tZS4gSXQgaXMgdmVyeSBhbm5veWluZyB0byBtZSB0aGF0IG90aGVy cyBrZWVwIGludHJvZHVjaW5nDQpzbyBtYW55IHJlZ3Jlc3Npb25zIGluIHN1Y2ggaW1wb3J0YW50 IHBhcnRzIG9mIHRoZSBrZXJuZWwuIEl0IGlzIGFsc28gYW5ub3lpbmcNCnRvIG1lIHRoYXQgSSBn ZXQgYmxhbWVkIGlmIEkgcmVwb3J0IGEgcmVncmVzc2lvbiBpbnN0ZWFkIG9mIHNlZWluZyB0aGF0 IHRoZQ0KcmVncmVzc2lvbiBnZXRzIGZpeGVkLg0KDQpCYXJ0Lg==
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com> To: "snitzer@redhat.com" <snitzer@redhat.com> Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>, "hch@infradead.org" <hch@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "osandov@fb.com" <osandov@fb.com>, "ming.lei@redhat.com" <ming.lei@redhat.com>, "axboe@kernel.dk" <axboe@kernel.dk> Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Date: Thu, 18 Jan 2018 18:47:59 +0000 [thread overview] Message-ID: <1516301278.2676.35.camel@wdc.com> (raw) In-Reply-To: <20180118183039.GA20121@redhat.com> On Thu, 2018-01-18 at 13:30 -0500, Mike Snitzer wrote: > 1%!? Where are you getting that number? Ming has detailed more > significant performance gains than 1%.. and not just on lpfc (though you > keep seizing on lpfc because of the low queue_depth of 3). That's what I derived from the numbers you posted for null_blk. If Ming has posted performance results for other drivers than lpfc, please let me know where I can find these. I have not yet seen these numbers. > This is all very tiresome. Yes, this is tiresome. It is very annoying to me that others keep introducing so many regressions in such important parts of the kernel. It is also annoying to me that I get blamed if I report a regression instead of seeing that the regression gets fixed. Bart.
next prev parent reply other threads:[~2018-01-18 18:47 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-18 2:41 [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Ming Lei 2018-01-18 16:50 ` Bart Van Assche 2018-01-18 17:03 ` Mike Snitzer 2018-01-18 17:03 ` Mike Snitzer 2018-01-18 17:20 ` Bart Van Assche 2018-01-18 17:20 ` Bart Van Assche 2018-01-18 18:30 ` Mike Snitzer 2018-01-18 18:47 ` Bart Van Assche [this message] 2018-01-18 18:47 ` Bart Van Assche 2018-01-18 20:11 ` Jens Axboe 2018-01-18 20:11 ` Jens Axboe 2018-01-18 20:48 ` Mike Snitzer 2018-01-18 20:58 ` Bart Van Assche 2018-01-18 20:58 ` Bart Van Assche 2018-01-18 21:23 ` Mike Snitzer 2018-01-18 21:23 ` Mike Snitzer 2018-01-18 21:37 ` Laurence Oberman 2018-01-18 21:39 ` [dm-devel] " Bart Van Assche 2018-01-18 21:39 ` Bart Van Assche 2018-01-18 21:45 ` Laurence Oberman 2018-01-18 21:45 ` Laurence Oberman 2018-01-18 22:01 ` Mike Snitzer 2018-01-18 22:18 ` Laurence Oberman 2018-01-18 22:20 ` Laurence Oberman 2018-01-18 22:20 ` Laurence Oberman 2018-01-18 22:24 ` Bart Van Assche 2018-01-18 22:24 ` Bart Van Assche 2018-01-18 22:35 ` Laurence Oberman 2018-01-18 22:39 ` Jens Axboe 2018-01-18 22:55 ` Bart Van Assche 2018-01-18 22:55 ` Bart Van Assche 2018-01-18 22:20 ` Bart Van Assche 2018-01-18 22:20 ` Bart Van Assche 2018-01-23 9:22 ` [PATCH] block: neutralize blk_insert_cloned_request IO stall regression (was: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle) Mike Snitzer 2018-01-23 10:53 ` Ming Lei 2018-01-23 12:15 ` Mike Snitzer 2018-01-23 12:17 ` Ming Lei 2018-01-23 12:43 ` Mike Snitzer 2018-01-23 16:43 ` [PATCH] " Bart Van Assche 2018-01-23 16:43 ` Bart Van Assche 2018-01-19 2:32 ` [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Ming Lei 2018-01-19 4:02 ` Jens Axboe 2018-01-19 7:26 ` Ming Lei 2018-01-19 15:20 ` Bart Van Assche 2018-01-19 15:20 ` Bart Van Assche 2018-01-19 15:25 ` Jens Axboe 2018-01-19 15:33 ` Ming Lei 2018-01-19 16:06 ` Bart Van Assche 2018-01-19 16:06 ` Bart Van Assche 2018-01-19 15:24 ` Jens Axboe 2018-01-19 15:40 ` Ming Lei 2018-01-19 15:40 ` Ming Lei 2018-01-19 15:48 ` Jens Axboe 2018-01-19 16:05 ` Ming Lei 2018-01-19 16:19 ` Jens Axboe 2018-01-19 16:26 ` Ming Lei 2018-01-19 16:27 ` Jens Axboe 2018-01-19 16:37 ` Ming Lei 2018-01-19 16:41 ` Jens Axboe 2018-01-19 16:41 ` Jens Axboe 2018-01-19 16:47 ` Mike Snitzer 2018-01-19 16:52 ` Jens Axboe 2018-01-19 17:05 ` Ming Lei 2018-01-19 17:09 ` Jens Axboe 2018-01-19 17:20 ` Ming Lei 2018-01-19 17:38 ` Jens Axboe 2018-01-19 18:24 ` Ming Lei 2018-01-19 18:24 ` Ming Lei 2018-01-19 18:33 ` Mike Snitzer 2018-01-19 23:52 ` Ming Lei 2018-01-20 4:27 ` Jens Axboe 2018-01-19 16:13 ` Mike Snitzer 2018-01-19 16:23 ` Jens Axboe 2018-01-19 23:57 ` Ming Lei 2018-01-29 22:37 ` Bart Van Assche 2018-01-19 5:09 ` Bart Van Assche 2018-01-19 5:09 ` Bart Van Assche 2018-01-19 7:34 ` Ming Lei 2018-01-19 19:47 ` Bart Van Assche 2018-01-19 19:47 ` Bart Van Assche
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1516301278.2676.35.camel@wdc.com \ --to=bart.vanassche@wdc.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=hch@infradead.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ming.lei@redhat.com \ --cc=osandov@fb.com \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.