From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "snitzer@redhat.com" <snitzer@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"osandov@fb.com" <osandov@fb.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [dm-devel] [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle
Date: Thu, 18 Jan 2018 21:39:15 +0000 [thread overview]
Message-ID: <1516311554.2676.50.camel@wdc.com> (raw)
In-Reply-To: <20180118212327.GB31679@redhat.com>
T24gVGh1LCAyMDE4LTAxLTE4IGF0IDE2OjIzIC0wNTAwLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+
IE9uIFRodSwgSmFuIDE4IDIwMTggYXQgIDM6NThQIC0wNTAwLA0KPiBCYXJ0IFZhbiBBc3NjaGUg
PEJhcnQuVmFuQXNzY2hlQHdkYy5jb20+IHdyb3RlOg0KPiANCj4gPiBPbiBUaHUsIDIwMTgtMDEt
MTggYXQgMTU6NDggLTA1MDAsIE1pa2UgU25pdHplciB3cm90ZToNCj4gPiA+IEZvciBCYXJ0J3Mg
dGVzdCB0aGUgdW5kZXJseWluZyBzY3NpLW1xIGRyaXZlciBpcyB3aGF0IGlzIHJlZ3VsYXJseQ0K
PiA+ID4gaGl0dGluZyB0aGlzIGNhc2UgaW4gX19ibGtfbXFfdHJ5X2lzc3VlX2RpcmVjdGx5KCk6
DQo+ID4gPiANCj4gPiA+ICAgICAgICAgaWYgKGJsa19tcV9oY3R4X3N0b3BwZWQoaGN0eCkgfHwg
YmxrX3F1ZXVlX3F1aWVzY2VkKHEpKQ0KPiA+DQo+ID4gVGhlc2UgbG9ja3VwcyB3ZXJlIGFsbCB0
cmlnZ2VyZWQgYnkgaW5jb3JyZWN0IGhhbmRsaW5nIG9mDQo+ID4gLnF1ZXVlX3JxKCkgcmV0dXJu
aW5nIEJMS19TVFNfUkVTT1VSQ0UuDQo+IA0KPiBQbGVhc2UgYmUgcHJlY2lzZSwgZG1fbXFfcXVl
dWVfcnEoKSdzIHJldHVybiBvZiBCTEtfU1RTX1JFU09VUkNFPw0KPiAiSW5jb3JyZWN0IiBiZWNh
dXNlIGl0IG5vIGxvbmdlciBydW5zIGJsa19tcV9kZWxheV9ydW5faHdfcXVldWUoKT8NCg0KSW4g
d2hhdCBJIHdyb3RlIEkgd2FzIHJlZmVycmluZyB0byBib3RoIGRtX21xX3F1ZXVlX3JxKCkgYW5k
IHNjc2lfcXVldWVfcnEoKS4NCldpdGggImluY29ycmVjdCIgSSBtZWFudCB0aGF0IHF1ZXVlIGxv
Y2t1cHMgYXJlIGludHJvZHVjZWQgdGhhdCBtYWtlIHVzZXINCnNwYWNlIHByb2Nlc3NlcyB1bmtp
bGxhYmxlLiBUaGF0J3MgYSBzZXZlcmUgYnVnLg0KDQo+IFBsZWFzZSB0cnkgdG8gZG8gbW9yZSB3
b3JrIGFuYWx5emluZyB0aGUgdGVzdCBjYXNlIHRoYXQgb25seSB5b3UgY2FuDQo+IGVhc2lseSBy
dW4gKGR1ZSB0byBzcnBfdGVzdCBiZWluZyBhIFBJVEEpLg0KDQpJdCBpcyBub3QgY29ycmVjdCB0
aGF0IEknbSB0aGUgb25seSBvbmUgd2hvIGlzIGFibGUgdG8gcnVuIHRoYXQgc29mdHdhcmUuDQpB
bnlvbmUgd2hvIGlzIHdpbGxpbmcgdG8gbWVyZ2UgdGhlIGxhdGVzdCBTUlAgaW5pdGlhdG9yIGFu
ZCB0YXJnZXQgZHJpdmVyDQpwYXRjaGVzIGluIGhpcyBvciBoZXIgdHJlZSBjYW4gcnVuIHRoYXQg
c29mdHdhcmUgaW4NCmFueSBWTS4gSSdtIHdvcmtpbmcgaGFyZA0Kb24gZ2V0dGluZyB0aGUgcGF0
Y2hlcyB1cHN0cmVhbSB0aGF0IG1ha2UgaXQgcG9zc2libGUgdG8gcnVuIHRoZSBzcnAtdGVzdA0K
c29mdHdhcmUgb24gYSBzZXR1cCB0aGF0IGlzIG5vdCBlcXVpcHBlZCB3aXRoIEluZmluaUJhbmQg
aGFyZHdhcmUuDQoNCj4gV2UgaGF2ZSB0aW1lIHRvIGdldCB0aGlzIHJpZ2h0LCBwbGVhc2Ugc3Rv
cCBoeXBlcnZlbnRpbGF0aW5nIGFib3V0DQo+ICJyZWdyZXNzaW9ucyIuDQoNClNvcnJ5IE1pa2Ug
YnV0IHRoYXQncyBzb21ldGhpbmcgSSBjb25zaWRlciBhcyBhbiB1bmZhaXIgY29tbWVudC4gSWYg
TWluZyBhbmQNCnlvdSB3b3JrIG9uIHBhdGNoZXMgdG9nZXRoZXIsIGl0J3MgeW91ciBqb2IgdG8g
bWFrZSBzdXJlIHRoYXQgbm8gcmVncmVzc2lvbnMNCmFyZSBpbnRyb2R1Y2VkLiBJbnN0ZWFkIG9m
IGJsYW1pbmcgbWUgYmVjYXVzZSBJIHJlcG9ydCB0aGVzZSByZWdyZXNzaW9ucyB5b3UNCnNob3Vs
ZCBiZSBncmF0ZWZ1bCB0aGF0IEkgdGFrZSB0aGUgdGltZSBhbmQgZWZmb3J0IHRvIHJlcG9ydCB0
aGVzZSByZWdyZXNzaW9ucw0KZWFybHkuIEFuZCBzaW5jZSB5b3UgYXJlIGVtcGxveWVkIGJ5IGEg
bGFyZ2Ugb3JnYW5pemF0aW9uIHRoYXQgc2VsbHMgTGludXgNCnN1cHBvcnQgc2VydmljZXMsIHlv
dXIgZW1wbG95ZXIgc2hvdWxkIGludmVzdCBpbiBkZXZlbG9waW5nIHRlc3QgY2FzZXMgdGhhdA0K
cmVhY2ggYSBoaWdoZXIgY292ZXJhZ2Ugb2YgdGhlIGRtLCBTQ1NJIGFuZCBibG9jayBsYXllciBj
b2RlLiBJIGRvbid0IHRoaW5rDQp0aGF0IGl0J3Mgbm9ybWFsIHRoYXQgbXkgdGVzdHMgZGlzY292
ZXJlZCBzZXZlcmFsIGlzc3VlcyB0aGF0IHdlcmUgbm90DQpkaXNjb3ZlcmVkIGJ5IFJlZCBIYXQn
cyBpbnRlcm5hbCB0ZXN0IHN1aXRlLiBUaGF0J3Mgc29tZXRoaW5nIFJlZCBIYXQgaGFzIHRvDQph
ZGRyZXNzLg0KDQpCYXJ0Lg==
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "snitzer@redhat.com" <snitzer@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"osandov@fb.com" <osandov@fb.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [dm-devel] [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle
Date: Thu, 18 Jan 2018 21:39:15 +0000 [thread overview]
Message-ID: <1516311554.2676.50.camel@wdc.com> (raw)
In-Reply-To: <20180118212327.GB31679@redhat.com>
On Thu, 2018-01-18 at 16:23 -0500, Mike Snitzer wrote:
> On Thu, Jan 18 2018 at 3:58P -0500,
> Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
>
> > On Thu, 2018-01-18 at 15:48 -0500, Mike Snitzer wrote:
> > > For Bart's test the underlying scsi-mq driver is what is regularly
> > > hitting this case in __blk_mq_try_issue_directly():
> > >
> > > if (blk_mq_hctx_stopped(hctx) || blk_queue_quiesced(q))
> >
> > These lockups were all triggered by incorrect handling of
> > .queue_rq() returning BLK_STS_RESOURCE.
>
> Please be precise, dm_mq_queue_rq()'s return of BLK_STS_RESOURCE?
> "Incorrect" because it no longer runs blk_mq_delay_run_hw_queue()?
In what I wrote I was referring to both dm_mq_queue_rq() and scsi_queue_rq().
With "incorrect" I meant that queue lockups are introduced that make user
space processes unkillable. That's a severe bug.
> Please try to do more work analyzing the test case that only you can
> easily run (due to srp_test being a PITA).
It is not correct that I'm the only one who is able to run that software.
Anyone who is willing to merge the latest SRP initiator and target driver
patches in his or her tree can run that software in
any VM. I'm working hard
on getting the patches upstream that make it possible to run the srp-test
software on a setup that is not equipped with InfiniBand hardware.
> We have time to get this right, please stop hyperventilating about
> "regressions".
Sorry Mike but that's something I consider as an unfair comment. If Ming and
you work on patches together, it's your job to make sure that no regressions
are introduced. Instead of blaming me because I report these regressions you
should be grateful that I take the time and effort to report these regressions
early. And since you are employed by a large organization that sells Linux
support services, your employer should invest in developing test cases that
reach a higher coverage of the dm, SCSI and block layer code. I don't think
that it's normal that my tests discovered several issues that were not
discovered by Red Hat's internal test suite. That's something Red Hat has to
address.
Bart.
next prev parent reply other threads:[~2018-01-18 21:39 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 2:41 [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Ming Lei
2018-01-18 16:50 ` Bart Van Assche
2018-01-18 17:03 ` Mike Snitzer
2018-01-18 17:03 ` Mike Snitzer
2018-01-18 17:20 ` Bart Van Assche
2018-01-18 17:20 ` Bart Van Assche
2018-01-18 18:30 ` Mike Snitzer
2018-01-18 18:47 ` Bart Van Assche
2018-01-18 18:47 ` Bart Van Assche
2018-01-18 20:11 ` Jens Axboe
2018-01-18 20:11 ` Jens Axboe
2018-01-18 20:48 ` Mike Snitzer
2018-01-18 20:58 ` Bart Van Assche
2018-01-18 20:58 ` Bart Van Assche
2018-01-18 21:23 ` Mike Snitzer
2018-01-18 21:23 ` Mike Snitzer
2018-01-18 21:37 ` Laurence Oberman
2018-01-18 21:39 ` Bart Van Assche [this message]
2018-01-18 21:39 ` [dm-devel] " Bart Van Assche
2018-01-18 21:45 ` Laurence Oberman
2018-01-18 21:45 ` Laurence Oberman
2018-01-18 22:01 ` Mike Snitzer
2018-01-18 22:18 ` Laurence Oberman
2018-01-18 22:20 ` Laurence Oberman
2018-01-18 22:20 ` Laurence Oberman
2018-01-18 22:24 ` Bart Van Assche
2018-01-18 22:24 ` Bart Van Assche
2018-01-18 22:35 ` Laurence Oberman
2018-01-18 22:39 ` Jens Axboe
2018-01-18 22:55 ` Bart Van Assche
2018-01-18 22:55 ` Bart Van Assche
2018-01-18 22:20 ` Bart Van Assche
2018-01-18 22:20 ` Bart Van Assche
2018-01-23 9:22 ` [PATCH] block: neutralize blk_insert_cloned_request IO stall regression (was: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle) Mike Snitzer
2018-01-23 10:53 ` Ming Lei
2018-01-23 12:15 ` Mike Snitzer
2018-01-23 12:17 ` Ming Lei
2018-01-23 12:43 ` Mike Snitzer
2018-01-23 16:43 ` [PATCH] " Bart Van Assche
2018-01-23 16:43 ` Bart Van Assche
2018-01-19 2:32 ` [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Ming Lei
2018-01-19 4:02 ` Jens Axboe
2018-01-19 7:26 ` Ming Lei
2018-01-19 15:20 ` Bart Van Assche
2018-01-19 15:20 ` Bart Van Assche
2018-01-19 15:25 ` Jens Axboe
2018-01-19 15:33 ` Ming Lei
2018-01-19 16:06 ` Bart Van Assche
2018-01-19 16:06 ` Bart Van Assche
2018-01-19 15:24 ` Jens Axboe
2018-01-19 15:40 ` Ming Lei
2018-01-19 15:40 ` Ming Lei
2018-01-19 15:48 ` Jens Axboe
2018-01-19 16:05 ` Ming Lei
2018-01-19 16:19 ` Jens Axboe
2018-01-19 16:26 ` Ming Lei
2018-01-19 16:27 ` Jens Axboe
2018-01-19 16:37 ` Ming Lei
2018-01-19 16:41 ` Jens Axboe
2018-01-19 16:41 ` Jens Axboe
2018-01-19 16:47 ` Mike Snitzer
2018-01-19 16:52 ` Jens Axboe
2018-01-19 17:05 ` Ming Lei
2018-01-19 17:09 ` Jens Axboe
2018-01-19 17:20 ` Ming Lei
2018-01-19 17:38 ` Jens Axboe
2018-01-19 18:24 ` Ming Lei
2018-01-19 18:24 ` Ming Lei
2018-01-19 18:33 ` Mike Snitzer
2018-01-19 23:52 ` Ming Lei
2018-01-20 4:27 ` Jens Axboe
2018-01-19 16:13 ` Mike Snitzer
2018-01-19 16:23 ` Jens Axboe
2018-01-19 23:57 ` Ming Lei
2018-01-29 22:37 ` Bart Van Assche
2018-01-19 5:09 ` Bart Van Assche
2018-01-19 5:09 ` Bart Van Assche
2018-01-19 7:34 ` Ming Lei
2018-01-19 19:47 ` Bart Van Assche
2018-01-19 19:47 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516311554.2676.50.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.